a488fc0add
When trying to run an UPDATE, this query is ran:
```sql
UPDATE `todos`
INNER JOIN `projects` ON `projects`.`id` = `todos`.`project_id`
SET `todos`.`state` = 'done'
WHERE `todos`.`user_id` = 4
AND (`todos`.`state` IN ('pending'))
AND (EXISTS
(SELECT 1
FROM `project_authorizations`
WHERE `project_authorizations`.`user_id` = 4
AND (project_authorizations.project_id = projects.id))
OR projects.visibility_level IN (10,
20))
AND `projects`.`id` IN
(SELECT `todos`.`project_id`
FROM `todos`
WHERE `todos`.`user_id` = 4
AND (`todos`.`state` IN ('pending')))
AND (`todos`.`state` != 'done')
```
But MySQL does not like the subquery used to filter on
`projects.id IN (SELECT ...`
Because the subquery queries from the same table:
> Error: You can’t specify target table ‘todos’ for update in FROM clause
So as workaround, wrap it in another subquery, where the original
subquery is aliased using the `AS` statement.
Mostly inspired by https://stackoverflow.com/a/43610081/89376
|
||
|---|---|---|
| .. | ||
| admin | ||
| concerns | ||
| access_requests_finder.rb | ||
| branches_finder.rb | ||
| contributed_projects_finder.rb | ||
| environments_finder.rb | ||
| events_finder.rb | ||
| group_finder.rb | ||
| group_members_finder.rb | ||
| group_projects_finder.rb | ||
| groups_finder.rb | ||
| issuable_finder.rb | ||
| issues_finder.rb | ||
| joined_groups_finder.rb | ||
| labels_finder.rb | ||
| members_finder.rb | ||
| merge_requests_finder.rb | ||
| milestones_finder.rb | ||
| move_to_project_finder.rb | ||
| notes_finder.rb | ||
| personal_access_tokens_finder.rb | ||
| personal_projects_finder.rb | ||
| pipeline_schedules_finder.rb | ||
| pipelines_finder.rb | ||
| projects_finder.rb | ||
| README.md | ||
| snippets_finder.rb | ||
| tags_finder.rb | ||
| todos_finder.rb | ||
| union_finder.rb | ||
| users_finder.rb | ||
Finders
This type of classes responsible for collection items based on different conditions. To prevent lookup methods in models like this:
class Project
def issues_for_user_filtered_by(user, filter)
# A lot of logic not related to project model itself
end
end
issues = project.issues_for_user_filtered_by(user, params)
Better use this:
issues = IssuesFinder.new(project, user, filter).execute
It will help keep models thiner.