6f3c490107
This refactors the AutocompleteController according to the guidelines and boundaries discussed in https://gitlab.com/gitlab-org/gitlab-ce/issues/49653. Specifically, ActiveRecord logic is moved to different finders, which are then used in the controller. View logic in turn is moved to presenters, instead of directly using ActiveRecord's "to_json" method. The finder MoveToProjectFinder is also adjusted according to the abstraction guidelines and boundaries, resulting in a much more simple finder. By using finders (and other abstractions) more actively, we can push a lot of logic out of the controller. We also remove the need for various "before_action" hooks, though this could be achieved without using finders as well. The various finders related to AutcompleteController have also been moved into a namespace. This removes the need for calling everything "AutocompleteSmurfFinder", instead you can use "Autocomplete::SmurfFinder". |
||
---|---|---|
.. | ||
admin | ||
autocomplete | ||
concerns | ||
access_requests_finder.rb | ||
awarded_emoji_finder.rb | ||
branches_finder.rb | ||
clusters_finder.rb | ||
contributed_projects_finder.rb | ||
environments_finder.rb | ||
events_finder.rb | ||
fork_projects_finder.rb | ||
group_descendants_finder.rb | ||
group_finder.rb | ||
group_members_finder.rb | ||
group_projects_finder.rb | ||
groups_finder.rb | ||
issuable_finder.rb | ||
issues_finder.rb | ||
joined_groups_finder.rb | ||
labels_finder.rb | ||
license_template_finder.rb | ||
members_finder.rb | ||
merge_request_target_project_finder.rb | ||
merge_requests_finder.rb | ||
milestones_finder.rb | ||
notes_finder.rb | ||
personal_access_tokens_finder.rb | ||
personal_projects_finder.rb | ||
pipeline_schedules_finder.rb | ||
pipelines_finder.rb | ||
projects_finder.rb | ||
README.md | ||
runner_jobs_finder.rb | ||
snippets_finder.rb | ||
tags_finder.rb | ||
todos_finder.rb | ||
union_finder.rb | ||
user_finder.rb | ||
user_recent_events_finder.rb | ||
users_finder.rb |
Finders
This type of classes responsible for collection items based on different conditions. To prevent lookup methods in models like this:
class Project
def issues_for_user_filtered_by(user, filter)
# A lot of logic not related to project model itself
end
end
issues = project.issues_for_user_filtered_by(user, params)
Better use this:
issues = IssuesFinder.new(project, user, filter).execute
It will help keep models thiner.