Douwe Maan 02591b0430 Merge branch 'disable-commenting-on-unrelatable-diff-line' into 'master' ... Disable commenting on unrelatable diff line ## What does this MR do? Fixes a bug where users can comment on diff lines that can't be commented on and attached to. This is the case for unfolded lines and lines that appear as snippets in the discussion tab. **!5864 should be merged before this MR.** ## Are there points in the code the reviewer needs to double check? 😕 ## Why was this MR needed? Comments were getting lost on the discussion feed, unable to find their related diff. ## What are the relevant issue numbers? Closes #20633. ## Screenshots (if relevant)  ## Does this MR meet the acceptance criteria? - [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - Tests - [ ] Added for this feature/bug - [ ] All builds are passing - [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [ ] Branch has no merge conflicts with `master` (if you do - rebase it please) - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !5681		2016-08-23 21:28:07 +00:00
..
admin	fixes part1 of files to start using active tense	2016-08-09 15:06:23 +01:00
atom	fixes part1 of files to start using active tense	2016-08-09 15:06:23 +01:00
boards	Fixed keyboard shortcuts not working on issue boards	2016-08-19 10:21:09 +01:00
dashboard	fixes part1 of files to start using active tense	2016-08-09 15:06:23 +01:00
groups/members	Fix a few nitpicks	2016-07-20 14:38:21 +02:00
issuables	Handle legacy sort order values	2016-08-18 23:26:07 +01:00
issues	Remove unneeded aliases	2016-08-18 14:29:48 -05:00
merge_requests	Added unfold test to parallel and added 'diff discussion' context	2016-08-23 20:45:29 +01:00
profiles	Remove sleeping and replace escaped text.	2016-08-13 00:57:40 -05:00
projects	Merge branch 'expiration-date-on-memberships' into 'master'	2016-08-19 17:08:03 +00:00
protected_branches	Move protected branches access control spec into a shared example.	2016-08-20 00:24:12 +05:30
security	Support integration with Koding (online IDE)	2016-08-19 12:10:58 -07:00
tags	Enable Style/EmptyLines cop, remove redundant ones	2016-07-01 21:56:17 +02:00
todos	Todos sorting dropdown	2016-08-19 16:14:20 -03:00
builds_spec.rb	Ensure current user can retry a build before showing the 'Retry' button	2016-07-26 11:05:46 +02:00
ci_lint_spec.rb	fixes part1 of files to start using active tense	2016-08-09 15:06:23 +01:00
commits_spec.rb	fixes part1 of files to start using active tense	2016-08-09 15:06:23 +01:00
compare_spec.rb	fixes part1 of files to start using active tense	2016-08-09 15:06:23 +01:00
container_registry_spec.rb	Show proper image ID on registry page	2016-06-21 13:08:10 +02:00
dashboard_issues_spec.rb	fixes part1 of files to start using active tense	2016-08-09 15:06:23 +01:00
dashboard_milestones_spec.rb
environments_spec.rb	Add an URL field to Environments	2016-07-29 13:54:45 +02:00
expand_collapse_diffs_spec.rb	Collapsed diffs lines/size don't accumulate to overflow diffs.	2016-07-18 14:43:28 -06:00
gitlab_flavored_markdown_spec.rb	fixes part1 of files to start using active tense	2016-08-09 15:06:23 +01:00
groups_spec.rb	Fix creating group with space in group path	2016-07-14 15:31:48 -03:00
help_pages_spec.rb	fixes part1 of files to start using active tense	2016-08-09 15:06:23 +01:00
issues_spec.rb	Revert the revert of Optimistic Locking	2016-08-22 18:43:13 +03:00
login_spec.rb	fixes part1 of files to start using active tense	2016-08-09 15:06:23 +01:00
markdown_spec.rb	Remove VideoJS and clean the integration	2016-07-20 11:36:42 +02:00
milestone_spec.rb	fixes part1 of files to start using active tense	2016-08-09 15:06:23 +01:00
notes_on_merge_requests_spec.rb	fixes part1 of files to start using active tense	2016-08-09 15:06:23 +01:00
participants_autocomplete_spec.rb	fixes part1 of files to start using active tense	2016-08-09 15:06:23 +01:00
password_reset_spec.rb
pipelines_settings_spec.rb	Create PipelinesSettingsController for showing settings page	2016-07-20 14:39:06 +02:00
profile_spec.rb	fixes part1 of files to start using active tense	2016-08-09 15:06:23 +01:00
projects_spec.rb	Fix file links on project page Files view	2016-08-23 11:01:20 +01:00
protected_branches_spec.rb	Move protected branches access control spec into a shared example.	2016-08-20 00:24:12 +05:30
runners_spec.rb	Enable RSpec/NotToNot cop and auto-correct offenses	2016-05-24 15:40:29 -04:00
search_spec.rb	Fixed enter key in search input not working	2016-08-23 14:44:28 +02:00
signup_spec.rb	Enable Style/EmptyLines cop, remove redundant ones	2016-07-01 21:56:17 +02:00
task_lists_spec.rb	Update specs to carry out changes in note factory	2016-05-29 15:03:00 -04:00
triggers_spec.rb
u2f_spec.rb	Add feature specs to cover naming and deleting U2F devices.	2016-08-18 22:12:02 +05:30
users_spec.rb	Enable Style/EmptyLines cop, remove redundant ones	2016-07-01 21:56:17 +02:00
variables_spec.rb	Updated tests	2016-08-13 00:57:40 -05:00