gitlab-org--gitlab-foss/spec
Jacob Schatz e45d6043e8 Merge branch 'js-content-for' into 'master'
Re-implement page-specific JS in a better way.

## What does this MR do?

This rebuilds the way we do page-specific JavaScript assets for a few reasons:

- The current implementation does not work with Subresource Integrity (!4808)
- The current implementation doesn't allow caching of libraries because each page we hook up with this system will have a separate application.js. Meaning that for every page that uses Ace Editor, we'd have to load Ace Editor plus any GitLab-specific scripts in the same file, making local caching of just Ace Editor impossible.
- The current implementation is rather hacky.

## Are there points in the code the reviewer needs to double check?

That Sprockets doesn't choke on this when we use precompiled assets.

## What are the relevant issue numbers?

#14372

## Does this MR meet the acceptance criteria?

- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] API support added
- Tests
  - [x] Added for this feature/bug
  - [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

cc: @jschatz1 @pavelloz

Thanks to @pavelloz for his example implementation which was very useful.

See merge request !4883
2016-06-24 20:51:02 +00:00
..
config Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
controllers Fix a wrong MR status when merge_when_build_succeeds & project.only_allow_merge_if_build_succeeds are true 2016-06-24 18:33:02 +02:00
factories Merge remote-tracking branch 'upstream/master' into feature/runner-lock-on-project 2016-06-20 14:04:14 +00:00
features Merge branch '19008_ci_dropdown_label_fix' into 'master' 2016-06-23 21:46:50 +00:00
finders Revert "squashed merge and fixed conflicts" 2016-06-16 12:59:07 +02:00
fixtures Show proper image ID on registry page 2016-06-21 13:08:10 +02:00
helpers Remove Haml helpers from the visibility level spec. 2016-06-22 16:10:26 -06:00
initializers Fix settings_spec so that it can that run by itself 2016-06-23 22:26:33 -07:00
javascripts Fix teaspoon tests. 2016-06-23 11:21:35 -06:00
lib Support for rendering/redacting multiple documents 2016-06-24 11:46:39 +02:00
mailers Fallback to group's owners/masters when a project has none 2016-06-20 12:10:37 +02:00
models Fix pagination on sorts with lots of ties 2016-06-23 15:26:50 +01:00
requests gitlab-org/gitlab-ce#17818 - add api call for issues by group 2016-06-23 16:31:48 +00:00
routing Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
services Raise a new Gitlab::Access::AccessDeniedError when permission is not enough to destroy a member 2016-06-18 06:06:34 +02:00
support Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce into feature/project-export 2016-06-16 13:04:00 +02:00
tasks/gitlab Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
views
workers Unify check branch name exist 2016-06-20 21:44:21 +02:00
factories_spec.rb Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00
rails_helper.rb
spec_helper.rb Enable Knapsack only in CI environment 2016-06-08 11:43:13 +02:00
teaspoon_env.rb Revert "Fix merge conflicts - squashed commit" 2016-06-03 11:10:17 +02:00