b4045e997f
Adds JavaScript validation for group path editing
## What does this MR do?
- Prevents group_edit form submission when special characters are included in the new group name
- Enhances gl_field_errors to support this use case and be more re-usable.
## Are there points in the code the reviewer needs to double check?
**The implementation of validation is here: 73d997046c**
The rest of the diff for this MR is augmenting gl_field_errors
## Why was this MR needed?
- Currently we allow submission and a 500 error is returned.
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/23564, https://gitlab.com/gitlab-org/gitlab-ce/issues/19756, https://gitlab.com/gitlab-org/gitlab-ce/issues/19736, https://gitlab.com/gitlab-org/gitlab-ce/issues/23922
See merge request !7041
53 lines
2 KiB
Text
53 lines
2 KiB
Text
.panel.panel-default.prepend-top-default
|
|
.panel-heading
|
|
Group settings
|
|
.panel-body
|
|
= form_for @group, html: { multipart: true, class: "form-horizontal gl-show-field-errors" }, authenticity_token: true do |f|
|
|
= form_errors(@group)
|
|
= render 'shared/group_form', f: f
|
|
|
|
.form-group
|
|
.col-sm-offset-2.col-sm-10
|
|
.image-container.s160
|
|
= image_tag group_icon(@group), alt: '', class: 'avatar group-avatar s160'
|
|
%p.light
|
|
- if @group.avatar?
|
|
You can change your group avatar here
|
|
- else
|
|
You can upload a group avatar here
|
|
= render 'shared/choose_group_avatar_button', f: f
|
|
- if @group.avatar?
|
|
%hr
|
|
= link_to 'Remove avatar', group_avatar_path(@group.to_param), data: { confirm: "Group avatar will be removed. Are you sure?"}, method: :delete, class: "btn btn-remove btn-sm remove-avatar"
|
|
|
|
= render 'shared/visibility_level', f: f, visibility_level: @group.visibility_level, can_change_visibility_level: can_change_group_visibility_level?(@group), form_model: @group
|
|
|
|
.form-group
|
|
.col-sm-offset-2.col-sm-10
|
|
= render 'shared/allow_request_access', form: f
|
|
|
|
= render 'group_lfs_settings', f: f
|
|
|
|
.form-group
|
|
%hr
|
|
= f.label :share_with_group_lock, class: 'control-label' do
|
|
Share with group lock
|
|
.col-sm-10
|
|
.checkbox
|
|
= f.check_box :share_with_group_lock
|
|
%span.descr Prevent sharing a project with another group within this group
|
|
|
|
|
|
.form-actions
|
|
= f.submit 'Save group', class: "btn btn-save"
|
|
|
|
.panel.panel-danger
|
|
.panel-heading Remove group
|
|
.panel-body
|
|
%p
|
|
Removing group will cause all child projects and resources to be removed.
|
|
%br
|
|
%strong Removed group can not be restored!
|
|
|
|
.form-actions
|
|
= link_to 'Remove Group', @group, data: {confirm: 'Removed group can not be restored! Are you sure?'}, method: :delete, class: "btn btn-remove"
|