3d7194f011
The good: - You can do a merge request for a forked commit and it will merge properly (i.e. it does work). - Push events take into account merge requests on forked projects - Tests around merge_actions now present, spinach, and other rspec tests - Satellites now clean themselves up rather then recreate The questionable: - Events only know about target projects - Project's merge requests only hold on to MR's where they are the target - All operations performed in the satellite The bad: - Duplication between project's repositories and satellites (e.g. commits_between) (for reference: http://feedback.gitlab.com/forums/176466-general/suggestions/3456722-merge-requests-between-projects-repos) Fixes: Make test repos/satellites only create when needed -Spinach/Rspec now only initialize test directory, and setup stubs (things that are relatively cheap) -project_with_code, source_project_with_code, and target_project_with_code now create/destroy their repos individually -fixed remote removal -How to merge renders properly -Update emails to show project/branches -Edit MR doesn't set target branch -Fix some failures on editing/creating merge requests, added a test -Added back a test around merge request observer -Clean up project_transfer_spec, Remove duplicate enable/disable observers -Ensure satellite lock files are cleaned up, Attempted to add some testing around these as well -Signifant speed ups for tests -Update formatting ordering in notes_on_merge_requests -Remove wiki schema update Fixes for search/search results -Search results was using by_project for a list of projects, updated this to use in_projects -updated search results to reference the correct (target) project -udpated search results to print both sides of the merge request Change-Id: I19407990a0950945cc95d62089cbcc6262dab1a8
69 lines
2.7 KiB
Gherkin
69 lines
2.7 KiB
Gherkin
Feature: Project Merge Requests
|
|
Background:
|
|
Given I sign in as a user
|
|
And I own project "Shop"
|
|
And project "Shop" have "Bug NS-04" open merge request
|
|
And project "Shop" have "Feature NS-03" closed merge request
|
|
And I visit project "Shop" merge requests page
|
|
|
|
Scenario: I should see open merge requests
|
|
Then I should see "Bug NS-04" in merge requests
|
|
And I should not see "Feature NS-03" in merge requests
|
|
|
|
Scenario: I should see closed merge requests
|
|
Given I click link "Closed"
|
|
Then I should see "Feature NS-03" in merge requests
|
|
And I should not see "Bug NS-04" in merge requests
|
|
|
|
Scenario: I should see all merge requests
|
|
Given I click link "All"
|
|
Then I should see "Feature NS-03" in merge requests
|
|
And I should see "Bug NS-04" in merge requests
|
|
|
|
Scenario: I visit merge request page
|
|
Given I click link "Bug NS-04"
|
|
Then I should see merge request "Bug NS-04"
|
|
|
|
Scenario: I close merge request page
|
|
Given I click link "Bug NS-04"
|
|
And I click link "Close"
|
|
Then I should see closed merge request "Bug NS-04"
|
|
|
|
@javascript
|
|
Scenario: I submit new unassigned merge request
|
|
Given I click link "New Merge Request"
|
|
And I submit new merge request "Wiki Feature"
|
|
Then I should see merge request "Wiki Feature"
|
|
|
|
@javascript
|
|
Scenario: I comment on a merge request
|
|
Given I visit merge request page "Bug NS-04"
|
|
And I leave a comment like "XML attached"
|
|
Then I should see comment "XML attached"
|
|
|
|
@javascript
|
|
Scenario: I comment on a merge request diff
|
|
Given project "Shop" have "Bug NS-05" open merge request with diffs inside
|
|
And I visit merge request page "Bug NS-05"
|
|
And I switch to the diff tab
|
|
And I leave a comment like "Line is wrong" on line 185 of the first file
|
|
And I switch to the merge request's comments tab
|
|
Then I should see a discussion has started on line 185
|
|
|
|
@javascript
|
|
Scenario: I comment on a line of a commit in merge request
|
|
Given project "Shop" have "Bug NS-05" open merge request with diffs inside
|
|
And I visit merge request page "Bug NS-05"
|
|
And I click on the first commit in the merge request
|
|
And I leave a comment like "Line is wrong" on line 185 of the first file
|
|
And I switch to the merge request's comments tab
|
|
Then I should see a discussion has started on commit bcf03b5de6c:L185
|
|
|
|
@javascript
|
|
Scenario: I comment on a commit in merge request
|
|
Given project "Shop" have "Bug NS-05" open merge request with diffs inside
|
|
And I visit merge request page "Bug NS-05"
|
|
And I click on the first commit in the merge request
|
|
And I leave a comment on the diff page
|
|
And I switch to the merge request's comments tab
|
|
Then I should see a discussion has started on commit bcf03b5de6c
|