gitlab-org--gitlab-foss/lib/gitlab
Douwe Maan 317206300d Merge branch 'configurable-attachment-size' into 'master'
Support configurable attachment size in Application Settings page

### What does this MR do?

This MR provides the ability to configure the maximum size of an attachment inside a note. A parameter has been added to the Application Settings page.

### Are there points in the code the reviewer needs to double check?

What should be done with the legacy note attachment validation? I added code to make the validation work with the configurable setting. I could see an issue where an admin lowers the limit from 10 megabytes to 5 megabytes, which could cause an existing model to be invalid.

### Why was this MR needed?

We often have attachments that exceed 10 MB, and it would be nice to be able to override the defaults.

### What are the relevant issue numbers / [Feature requests](http://feedback.gitlab.com/)?

See Issue #1258

### Screenshots

Before:

![Screen_Shot_2015-03-29_at_3.06.53_PM](https://gitlab.com/gitlab-org/gitlab-ce/uploads/6013a1dbc8cf61a63e93744149937fa0/Screen_Shot_2015-03-29_at_3.06.53_PM.png)

After:

![Screen_Shot_2015-03-29_at_3.12.34_PM](https://gitlab.com/gitlab-org/gitlab-ce/uploads/f3518af7e8653ba40f0a3579456da6ad/Screen_Shot_2015-03-29_at_3.12.34_PM.png)

See merge request !407
2015-04-03 08:47:55 +00:00
..
backend Merge branch 'api-internal-errors' into 'master' 2015-03-25 04:16:45 +00:00
bitbucket_import Fix OAuth2 issue importing a new project from GitHub and GitLab 2015-03-22 18:16:48 -07:00
diff Fix commit comments on first line of diff not rendering in Merge Request Discussion view. 2015-02-20 10:23:34 +01:00
github_import Fix OAuth2 issue importing a new project from GitHub and GitLab 2015-03-22 18:16:48 -07:00
gitlab_import Import GitHub, Bitbucket or GitLab.com projects owned by authenticated user into current namespace. 2015-03-31 16:34:13 +02:00
gitorious_import Add gitorious.org importer 2015-02-20 17:42:58 +00:00
graphs Refactor commits graph 2014-09-29 12:05:17 +03:00
ldap Faulty LDAP DN name escaping removed 2015-03-21 22:57:55 +01:00
middleware Revert "Increase timeout for Git-over-HTTP requests." 2015-03-19 18:29:20 -07:00
oauth Move User.cleanup_username to Namespace.cleanup_path. 2015-03-27 11:09:29 +01:00
satellite Merge pull request #9021 from nicklegr/faster_auto_merge 2015-03-25 12:18:03 -07:00
sidekiq_middleware Fix typo 2014-12-08 13:39:18 +01:00
access.rb Improve protected branches selectbox options 2015-02-03 18:12:20 -08:00
app_logger.rb Dry admin logs. 2014-10-06 00:14:46 +02:00
auth.rb Session API: Use case-insensitive authentication like in UI 2014-10-30 18:29:18 +02:00
bitbucket_import.rb Fix specs. 2015-02-24 15:07:24 +01:00
blacklist.rb Prevent people from using ci since we plan to host ci on /ci later. 2014-09-09 10:11:07 +02:00
closing_issue_extractor.rb Allow commit messages to close several issues at once (thanks @123Haynes 2015-01-20 10:45:48 +01:00
compare_result.rb Refactor compare logic for MR. Use satellites only for forks for better performance 2014-07-29 12:11:16 +03:00
config_helper.rb Make app works with strong params 2014-06-26 23:24:17 +03:00
contributions_calendar.rb Improve contribution calendar per day info 2015-03-22 14:52:44 -07:00
contributors.rb Use Contributor class instead of hash 2014-07-02 15:09:06 +03:00
current_settings.rb Support configurable attachment size via Application Settings 2015-04-02 00:04:08 -07:00
force_push_check.rb Fewer constants, more helpers. 2015-03-19 10:34:04 +01:00
git.rb Use Gitlab::Git helper methods and constants as much as possible. 2015-03-10 13:39:31 +01:00
git_access.rb Merge branch 'more-rubocop-styles' into 'master' 2015-03-25 15:37:04 +00:00
git_access_status.rb Rubocop enabled for: Use spaces inside hash literal braces 2015-02-02 20:36:54 -08:00
git_access_wiki.rb Refactor GitAccess to use instance variables. 2015-03-24 14:11:48 +01:00
git_logger.rb Dry admin logs. 2014-10-06 00:14:46 +02:00
git_ref_validator.rb fix system silent call 2014-11-06 13:07:42 +02:00
identifier.rb Remove deprecated finders 2014-01-19 23:39:56 +04:00
import_formatter.rb Add Bitbucket importer. 2015-02-24 15:07:24 +01:00
inline_diff.rb Add parenthesis to function def with arguments. 2014-10-03 09:18:46 +02:00
issues_labels.rb remove feature label 2014-10-31 17:22:16 -07:00
logger.rb Dry admin logs. 2014-10-06 00:14:46 +02:00
markdown.rb Merge branch 'username-period' into 'master' 2015-04-02 20:28:23 +00:00
markdown_helper.rb Factor markup? || gitlab_markdown? into new method 2014-10-04 17:56:12 +02:00
note_data_builder.rb Added comment notification events to HipChat and Slack services. 2015-03-06 06:54:00 -08:00
popen.rb Style/RedundantReturn enabled 2015-03-24 18:35:57 -07:00
production_logger.rb Dry admin logs. 2014-10-06 00:14:46 +02:00
project_search_results.rb Don't include system notes in issue/MR comment count. 2015-03-23 16:43:08 +01:00
push_data_builder.rb Extend push_tag event to include tag message and last commit 2015-03-21 11:25:27 +01:00
reference_extractor.rb Disable reference creation for comments surrounded by code/preformatted blocks 2015-03-19 14:37:35 -07:00
regex.rb Don't allow username to end in period. 2015-03-27 11:10:56 +01:00
search_results.rb Fix tests 2014-08-27 15:26:35 +03:00
seeder.rb Revert "Create dev fixture projects with fixed visibility" 2014-11-10 16:17:04 +02:00
sidekiq_logger.rb Dry admin logs. 2014-10-06 00:14:46 +02:00
snippet_search_results.rb Updating to persist a params snippets variable 2014-09-05 13:30:55 -04:00
theme.rb Style/RedundantReturn enabled 2015-03-24 18:35:57 -07:00
upgrader.rb Rubocop enabled for: Use spaces inside hash literal braces 2015-02-02 20:36:54 -08:00
url_builder.rb Enforce restricted visibilities for snippets 2015-03-08 17:57:08 -06:00
user_access.rb Cache LDAP check in Gitlab::UserAccess 2014-08-06 18:03:01 +02:00
utils.rb fix system silent call 2014-11-06 13:07:42 +02:00
version_info.rb Fix abort gitlab:app:check 2013-06-06 10:10:51 +09:00
visibility_level.rb Move application setting to separate variable. 2015-03-18 13:55:41 -07:00