65840591cd
Prior to this change, health checks checked for writeability of the NFS shards. Given we're moving away from that, this patch extends the checks for Gitaly to check for read and writeability. Potentially some dashboards will break, as over time these metrics will no longer appear as Prometheus doesn't get the data anymore. Observability in the circuit breaker will be reduced, but its not expected to be turned on and the circuit breaker is being removed soon too. Closes https://gitlab.com/gitlab-org/gitaly/issues/1218
163 lines
4.5 KiB
Ruby
163 lines
4.5 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe HealthController do
|
|
include StubENV
|
|
|
|
let(:json_response) { JSON.parse(response.body) }
|
|
let(:token) { Gitlab::CurrentSettings.health_check_access_token }
|
|
let(:whitelisted_ip) { '127.0.0.1' }
|
|
let(:not_whitelisted_ip) { '127.0.0.2' }
|
|
|
|
before do
|
|
allow(Settings.monitoring).to receive(:ip_whitelist).and_return([whitelisted_ip])
|
|
stub_storage_settings({}) # Hide the broken storage
|
|
stub_env('IN_MEMORY_APPLICATION_SETTINGS', 'false')
|
|
end
|
|
|
|
describe '#storage_check' do
|
|
before do
|
|
allow(Gitlab::RequestContext).to receive(:client_ip).and_return(whitelisted_ip)
|
|
end
|
|
|
|
subject { post :storage_check }
|
|
|
|
it 'checks all the configured storages' do
|
|
expect(Gitlab::Git::Storage::Checker).to receive(:check_all).and_call_original
|
|
|
|
subject
|
|
end
|
|
|
|
it 'returns the check interval' do
|
|
stub_env('IN_MEMORY_APPLICATION_SETTINGS', 'true')
|
|
stub_application_setting(circuitbreaker_check_interval: 10)
|
|
|
|
subject
|
|
|
|
expect(json_response['check_interval']).to eq(10)
|
|
end
|
|
|
|
context 'with failing storages', :broken_storage do
|
|
before do
|
|
stub_storage_settings(
|
|
broken: { path: 'tmp/tests/non-existent-repositories' }
|
|
)
|
|
end
|
|
|
|
it 'includes the failure information' do
|
|
subject
|
|
|
|
expected_results = [
|
|
{ 'storage' => 'broken', 'success' => false },
|
|
{ 'storage' => 'default', 'success' => true }
|
|
]
|
|
|
|
expect(json_response['results']).to eq(expected_results)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#readiness' do
|
|
shared_context 'endpoint responding with readiness data' do
|
|
let(:request_params) { {} }
|
|
|
|
subject { get :readiness, request_params }
|
|
|
|
it 'responds with readiness checks data' do
|
|
subject
|
|
|
|
expect(json_response['db_check']['status']).to eq('ok')
|
|
expect(json_response['cache_check']['status']).to eq('ok')
|
|
expect(json_response['queues_check']['status']).to eq('ok')
|
|
expect(json_response['shared_state_check']['status']).to eq('ok')
|
|
expect(json_response['gitaly_check']['status']).to eq('ok')
|
|
end
|
|
end
|
|
|
|
context 'accessed from whitelisted ip' do
|
|
before do
|
|
allow(Gitlab::RequestContext).to receive(:client_ip).and_return(whitelisted_ip)
|
|
end
|
|
|
|
it_behaves_like 'endpoint responding with readiness data'
|
|
end
|
|
|
|
context 'accessed from not whitelisted ip' do
|
|
before do
|
|
allow(Gitlab::RequestContext).to receive(:client_ip).and_return(not_whitelisted_ip)
|
|
end
|
|
|
|
it 'responds with resource not found' do
|
|
get :readiness
|
|
|
|
expect(response.status).to eq(404)
|
|
end
|
|
|
|
context 'accessed with valid token' do
|
|
context 'token passed in request header' do
|
|
before do
|
|
request.headers['TOKEN'] = token
|
|
end
|
|
|
|
it_behaves_like 'endpoint responding with readiness data'
|
|
end
|
|
end
|
|
|
|
context 'token passed as URL param' do
|
|
it_behaves_like 'endpoint responding with readiness data' do
|
|
let(:request_params) { { token: token } }
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#liveness' do
|
|
shared_context 'endpoint responding with liveness data' do
|
|
subject { get :liveness }
|
|
|
|
it 'responds with liveness checks data' do
|
|
subject
|
|
|
|
expect(json_response['db_check']['status']).to eq('ok')
|
|
expect(json_response['cache_check']['status']).to eq('ok')
|
|
expect(json_response['queues_check']['status']).to eq('ok')
|
|
expect(json_response['shared_state_check']['status']).to eq('ok')
|
|
end
|
|
end
|
|
|
|
context 'accessed from whitelisted ip' do
|
|
before do
|
|
allow(Gitlab::RequestContext).to receive(:client_ip).and_return(whitelisted_ip)
|
|
end
|
|
|
|
it_behaves_like 'endpoint responding with liveness data'
|
|
end
|
|
|
|
context 'accessed from not whitelisted ip' do
|
|
before do
|
|
allow(Gitlab::RequestContext).to receive(:client_ip).and_return(not_whitelisted_ip)
|
|
end
|
|
|
|
it 'responds with resource not found' do
|
|
get :liveness
|
|
|
|
expect(response.status).to eq(404)
|
|
end
|
|
|
|
context 'accessed with valid token' do
|
|
context 'token passed in request header' do
|
|
before do
|
|
request.headers['TOKEN'] = token
|
|
end
|
|
|
|
it_behaves_like 'endpoint responding with liveness data'
|
|
end
|
|
|
|
context 'token passed as URL param' do
|
|
it_behaves_like 'endpoint responding with liveness data' do
|
|
subject { get :liveness, token: token }
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|