8469f59d78
This backports all EE schema changes to CE, including EE migrations, ensuring both use the same schema. == Updated tests A spec related to ghost and support bot users had to be modified to make it pass. The spec in question assumes that the "support_bot" column exists when defining the spec. In the single codebase setup this is not the case, as the column is backported in a later migration. Any attempt to use a different schema version or use of "around" blocks to conditionally disable specs won't help, as reverting the backport migration would also drop the "support_bot" column. Removing the "support_bot" tests entirely appears to be the only solution. We also need to update some foreign key tests now that we have backported the EE columns. Fortunately, these changes are very minor. == Backporting migrations This commit moves EE specific migrations (except those for the Geo tracking database) and related files to CE, and also removes any traces of the ee/db directory. Some migrations had to be modified or removed, as they no longer work with the schema being backported. These migrations were all quite old, so we opted for removing them where modifying them would take too much time and effort. Some old migrations were modified in EE, while also existing in CE. In these cases we took the EE code, and in one case removed them entirely. It's not worth spending time trying to merge these changes somehow as we plan to remove old migrations around the release of 12.0, see https://gitlab.com/gitlab-org/gitlab-ce/issues/59177 for more details.
80 lines
2.5 KiB
Ruby
80 lines
2.5 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
# All the files/directories that should be reviewed by the DB team.
|
|
DB_FILES = [
|
|
'db/',
|
|
'app/models/project_authorization.rb',
|
|
'app/services/users/refresh_authorized_projects_service.rb',
|
|
'lib/gitlab/background_migration.rb',
|
|
'lib/gitlab/background_migration/',
|
|
'lib/gitlab/database.rb',
|
|
'lib/gitlab/database/',
|
|
'lib/gitlab/github_import.rb',
|
|
'lib/gitlab/github_import/',
|
|
'lib/gitlab/sql/',
|
|
'rubocop/cop/migration',
|
|
'ee/lib/gitlab/database/'
|
|
].freeze
|
|
|
|
SCHEMA_NOT_UPDATED_MESSAGE = <<~MSG
|
|
**New %<migrations>s added but %<schema>s wasn't updated.**
|
|
|
|
Usually, when adding new %<migrations>s, %<schema>s should be
|
|
updated too (unless the migration isn't changing the DB schema
|
|
and isn't the most recent one).
|
|
MSG
|
|
|
|
def database_paths_requiring_review(files)
|
|
to_review = []
|
|
|
|
files.each do |file|
|
|
review = DB_FILES.any? do |pattern|
|
|
file.start_with?(pattern)
|
|
end
|
|
|
|
to_review << file if review
|
|
end
|
|
|
|
to_review
|
|
end
|
|
|
|
non_geo_db_schema_updated = !git.modified_files.grep(%r{\Adb/schema\.rb}).empty?
|
|
geo_db_schema_updated = !git.modified_files.grep(%r{\Aee/db/geo/schema\.rb}).empty?
|
|
|
|
non_geo_migration_created = !git.added_files.grep(%r{\A(db/(post_)?migrate)/}).empty?
|
|
geo_migration_created = !git.added_files.grep(%r{\Aee/db/geo/(post_)?migrate/}).empty?
|
|
|
|
if non_geo_migration_created && !non_geo_db_schema_updated
|
|
warn format(SCHEMA_NOT_UPDATED_MESSAGE, migrations: 'migrations', schema: gitlab.html_link("db/schema.rb"))
|
|
end
|
|
|
|
if geo_migration_created && !geo_db_schema_updated
|
|
warn format(SCHEMA_NOT_UPDATED_MESSAGE, migrations: 'Geo migrations', schema: gitlab.html_link("ee/db/geo/schema.rb"))
|
|
end
|
|
|
|
db_paths_to_review = database_paths_requiring_review(helper.all_changed_files)
|
|
|
|
unless db_paths_to_review.empty?
|
|
message 'This merge request adds or changes files that require a ' \
|
|
'review from the Database team.'
|
|
|
|
markdown(<<~MARKDOWN.strip)
|
|
## Database Review
|
|
|
|
The following files require a review from the Database team:
|
|
|
|
* #{db_paths_to_review.map { |path| "`#{path}`" }.join("\n* ")}
|
|
|
|
To make sure these changes are reviewed, take the following steps:
|
|
|
|
1. Edit your merge request, and add `gl-database` to the list of Group
|
|
approvers.
|
|
1. Mention `@gl-database` in a separate comment, and explain what needs to be
|
|
reviewed by the team. Please don't mention the team until your changes are
|
|
ready for review.
|
|
MARKDOWN
|
|
|
|
unless gitlab.mr_labels.include?('database')
|
|
warn 'This merge request is missing the ~database label.'
|
|
end
|
|
end
|