kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
gitlab-org--gitlab-foss/spec
History
Alfredo Sumaran f4710ee83c Merge branch 'issue-13823' into 'master' 
Issue #13823: random message when all Todos are Done

## What does this MR do?

Shows a random message every time the To Do list is empty: https://gitlab.com/gitlab-org/gitlab-ce/issues/13823

## Are there points in the code the reviewer needs to double check?

It's my first contribution to GitLab so I might need some help:

 - I'm loading a yaml file in the controller. I'm not sure where would be the best place to put it.
 - I'm also having the error below running the tests but it doesn't seem related to my changes. I think I might have some issue with my config. Could you double check if the tests pass for you?

/home/pep/.rvm/gems/ruby-2.3.1/gems/actionpack-4.2.7.1/lib/action_dispatch/middleware/debug_exceptions.rb:21:in `call': No route matches [GET] "/autocomplete/users/sjobs@apple.com.json" (ActionController::RoutingError)

## Why was this MR needed?

https://gitlab.com/gitlab-org/gitlab-ce/issues/13823

## Screenshots (if relevant)

## Does this MR meet the acceptance criteria?

- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
  - [x] Added for this feature/bug
  - [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/issues/13823

See merge request !6818
2016-11-14 20:47:13 +00:00
..
bin DRY up the specs for bin/changelog 2016-11-03 17:35:06 +00:00
config Updated mail_room and added sentinel support to Reply by Email 2016-10-26 05:02:47 +02:00
controllers Merge branch 'fix-help-page-links' into 'master' 2016-11-14 10:45:56 +00:00
factories Merge branch 'fix-unathorized-cloning' into 'security' 2016-11-09 12:27:17 +01:00
features Merge branch 'issue-13823' into 'master' 2016-11-14 20:47:13 +00:00
finders Fix lightweight tags not processed correctly by GitTagPushService 2016-10-28 13:53:18 -03:00
fixtures Use separate email-friendly token for incoming email and let incoming 2016-11-07 15:55:42 +00:00
helpers Merge branch 'remove-heading-space-from-diff-content' into 'master' 2016-11-09 15:32:02 +00:00
initializers Give priority to environment variables 2016-08-03 15:48:48 +01:00
javascripts Merge branch 'improve-build-scroll-controls-responsive-behaviour' into 'master' 2016-11-08 21:41:48 +00:00
lib Merge branch 'fix/improve-naming-convention-in-ci-config' into 'master' 2016-11-14 11:59:11 +00:00
mailers Move spec/mailers/shared/notify.rb to spec/support 2016-10-22 17:51:50 -05:00
models Merge branch 'fix/error-when-invalid-branch-for-new-pipeline-used' into 'master' 2016-11-10 14:00:55 +00:00
policies Added tests for IssuePolicy 2016-11-07 12:49:24 +01:00
requests Update 8.14-rc1 migrations to minimize downtime and deploy time 2016-11-11 15:34:00 -03:00
routing Fix routing spec for group controller 2016-11-08 15:54:17 +02:00
serializers Simplify implementation of entity serializers 2016-11-04 15:00:39 +01:00
services Does not raise error when Note not found when processing NewNoteWorker 2016-11-11 22:54:11 -02:00
support Fix expanding a collapsed diff when converting a symlink to a regular file 2016-11-10 18:24:12 +01:00
tasks/gitlab Introduce better credential and error checking to rake gitlab:ldap:check 2016-11-08 15:46:10 -06:00
uploaders
views add tests for build row templates 2016-11-10 16:38:00 -06:00
workers Does not raise error when Note not found when processing NewNoteWorker 2016-11-11 22:54:11 -02:00
factories_spec.rb adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00
rails_helper.rb
rake_helper.rb Add Rake task to create/repair GitLab Shell hooks symlinks 2016-11-01 14:52:59 -05:00
simplecov_env.rb Bump SimpleCov merge timeout to 365 days 2016-08-22 13:44:14 +02:00
spec_helper.rb Fix broken commits search 2016-11-08 12:03:23 +02:00
teaspoon_env.rb Add test coverage analysis for CoffeeScript (!5052) 2016-08-07 21:52:37 +02:00