gitlab-org--gitlab-foss/app/controllers/admin
Douwe Maan d1c94f034b Merge branch 'explicit-requesters-scope' into 'master'
Exclude requesters from Project#members, Group#members and User#members

## What does this MR do?

It excludes requesters from the `Project#members`, `Group#members` and `User#members` associations, and adds new `Project#requesters` and `Group#requesters` associations.

## Are there points in the code the reviewer needs to double check?

No.

## Why was this MR needed?

Without this, if you call `project.members`, requesters are included in the results! This is at best misleading, and at worst can lead to security issues. By excluding requesters from the `#members` associations, we avoid introducing security inadvertently since you have to call the `#requesters` association explicitly to get requesters.

## What are the relevant issue numbers?

This is something I realized while fixing the security issue #19102.

## Does this MR meet the acceptance criteria?

- [x] I don't think this needs a CHANGELOG since this is an internal change
- Tests
  - [x] Added for this feature/bug
  - [ ] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

See merge request !4946
2016-07-01 22:23:26 +00:00
..
abuse_reports_controller.rb Merge branch 'meinac/gitlab-ce-change_deprecated_render_usage' 2016-05-18 12:48:23 -05:00
appearances_controller.rb Fix admin appearance settings preview 2016-06-20 13:18:18 +03:00
application_controller.rb Fix issue with impersonation 2016-04-22 23:21:56 +02:00
application_settings_controller.rb Add Application Setting to configure default Repository Path for new projects 2016-06-29 23:35:00 -04:00
applications_controller.rb Small improvements to CI 2015-01-17 16:17:34 -08:00
background_jobs_controller.rb Use Gitlab.config instead of Settings everywhere 2014-10-15 23:01:31 +02:00
broadcast_messages_controller.rb Change deprecated usage of rendering without response body 2016-03-16 03:16:25 +02:00
builds_controller.rb Show 'All' tab by default in the builds page 2016-01-04 10:21:10 -02:00
dashboard_controller.rb Explicitly define ordering in models using default_scope 2015-02-05 14:20:55 -08:00
deploy_keys_controller.rb Remove show actions from Admin and Project DeployKeys 2015-06-03 18:03:04 -04:00
groups_controller.rb Exclude requesters from Project#members, Group#members and User#members 2016-07-01 17:44:46 +02:00
health_check_controller.rb Add Changelog entry 2016-05-12 09:04:04 -07:00
hooks_controller.rb Enable Style/EmptyLines cop, remove redundant ones 2016-07-01 21:56:17 +02:00
identities_controller.rb Code style fixes and some code simplified 2016-01-08 16:26:04 -02:00
impersonations_controller.rb Log to application.log when an admin starts and stops impersonating a user 2016-05-04 09:21:34 -07:00
keys_controller.rb Change deprecated usage of rendering without response body 2016-03-16 03:16:25 +02:00
labels_controller.rb Use the configured Kaminari "per page" default 2016-03-19 17:37:54 -04:00
logs_controller.rb Added the correct hierarchy of controllers for the administrative part 2013-01-24 22:31:24 +02:00
projects_controller.rb Exclude requesters from Project#members, Group#members and User#members 2016-07-01 17:44:46 +02:00
runner_projects_controller.rb Allow admins to assign locked runners: 2016-06-28 19:55:12 +08:00
runners_controller.rb Minor runner-related code refactorings 2016-05-19 22:01:53 +02:00
services_controller.rb Improve invalidation of stored service password if the endpoint URL is changed 2015-10-15 12:07:59 +02:00
spam_logs_controller.rb Change deprecated usage of rendering without response body 2016-03-16 03:16:25 +02:00
system_info_controller.rb Catch permission denied errors and ignore the disk 2016-06-30 13:53:35 -04:00
users_controller.rb Merge branch 'meinac/gitlab-ce-change_deprecated_render_usage' 2016-05-18 12:48:23 -05:00