gitlab-org--gitlab-foss/spec/helpers
Douwe Maan d1c94f034b Merge branch 'explicit-requesters-scope' into 'master'
Exclude requesters from Project#members, Group#members and User#members

## What does this MR do?

It excludes requesters from the `Project#members`, `Group#members` and `User#members` associations, and adds new `Project#requesters` and `Group#requesters` associations.

## Are there points in the code the reviewer needs to double check?

No.

## Why was this MR needed?

Without this, if you call `project.members`, requesters are included in the results! This is at best misleading, and at worst can lead to security issues. By excluding requesters from the `#members` associations, we avoid introducing security inadvertently since you have to call the `#requesters` association explicitly to get requesters.

## What are the relevant issue numbers?

This is something I realized while fixing the security issue #19102.

## Does this MR meet the acceptance criteria?

- [x] I don't think this needs a CHANGELOG since this is an internal change
- Tests
  - [x] Added for this feature/bug
  - [ ] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

See merge request !4946
2016-07-01 22:23:26 +00:00
..
application_helper_spec.rb Correctly adds commit ID into dropdown 2016-06-18 21:49:20 +01:00
auth_helper_spec.rb Enable RSpec/NotToNot cop and auto-correct offenses 2016-05-24 15:40:29 -04:00
blob_helper_spec.rb Update SVG sanitizer to conform to SVG 1.1 2016-05-06 23:20:24 -07:00
broadcast_messages_helper_spec.rb Move `BroadcastMessage#status` to a helper since it's presentational 2016-01-13 11:49:59 -05:00
ci_status_helper_spec.rb Rename Ci::Commit to Ci::Pipeline and rename some of the ci_commit to pipeline 2016-06-02 16:59:04 +02:00
commits_helper_spec.rb Remove persistent XSS vulnerability in `commit_person_link` helper 2016-04-17 18:42:49 -04:00
diff_helper_spec.rb Create DiffFilter and change SystemNoteService#change_title to use Gitlab::Diff::InlineDiff 2016-05-18 11:15:10 -05:00
emails_helper_spec.rb
events_helper_spec.rb Clean up EventsHelper spec 2016-05-12 16:52:56 -05:00
form_helper_spec.rb Standardize the way we check for and display form errors 2016-04-04 21:37:07 -04:00
gitlab_markdown_helper_spec.rb Hook up the updated `WikiLinkFilter` to the wiki controllers. 2016-06-09 10:15:01 +05:30
gitlab_routing_helper_spec.rb UI and copywriting improvements 2016-06-14 13:18:14 +02:00
graph_helper_spec.rb
groups_helper_spec.rb Tweaks, refactoring, and specs 2016-03-20 21:04:07 +01:00
icons_helper_spec.rb
import_helper_spec.rb Fix GitHub project's link on import page when provider has a custom URL 2016-04-19 13:21:30 -03:00
issues_helper_spec.rb Remove deprecated issues_tracker and issues_tracker_id from project 2016-06-13 18:13:55 -03:00
labels_helper_spec.rb Updated label links to work correctly for filtering 2016-04-26 09:13:03 +01:00
members_helper_spec.rb Exclude requesters from Project#members, Group#members and User#members 2016-07-01 17:44:46 +02:00
merge_requests_helper_spec.rb Remove JiraIssue model and replace references with ExternalIssue 2016-06-16 01:25:18 +03:00
nav_helper_spec.rb
notes_helper_spec.rb Be explicit which project and user ID are memoized 2016-06-29 13:42:15 -07:00
notifications_helper_spec.rb Refactor notification helper and fix notification service 2016-03-30 10:44:20 +02:00
page_layout_helper_spec.rb Don't override issue page description in project layout. 2016-01-06 13:02:51 +01:00
preferences_helper_spec.rb Implementing 'Groups View' and 'TODOs View' as options for dashboard preferences. 2016-03-24 19:59:54 +01:00
projects_helper_spec.rb Refactor repository paths handling to allow multiple git mount points 2016-06-29 22:30:31 -04:00
runners_helper_spec.rb
search_helper_spec.rb Fix broken tests 2016-02-04 17:00:32 +01:00
submodule_helper_spec.rb
tab_helper_spec.rb
time_helper_spec.rb
tree_helper_spec.rb
visibility_level_helper_spec.rb Enable Style/EmptyLines cop, remove redundant ones 2016-07-01 21:56:17 +02:00