62 lines
1.8 KiB
Ruby
62 lines
1.8 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
RSpec.describe Preloaders::UserMaxAccessLevelInProjectsPreloader do
|
|
let_it_be(:user) { create(:user) }
|
|
let_it_be(:project_1) { create(:project) }
|
|
let_it_be(:project_2) { create(:project) }
|
|
let_it_be(:project_3) { create(:project) }
|
|
let_it_be(:project_4) { create(:project) }
|
|
let_it_be(:project_5) { create(:project) }
|
|
|
|
let(:projects) { [project_1, project_2, project_3, project_4, project_5] }
|
|
let(:query) { projects.each { |project| user.can?(:read_project, project) } }
|
|
|
|
before do
|
|
project_1.add_developer(user)
|
|
project_2.add_developer(user)
|
|
end
|
|
|
|
context 'without preloader' do
|
|
it 'runs some queries' do
|
|
# we have an existing N+1, one for each project for which user is not a member
|
|
# in this spec, project_3, project_4, project_5
|
|
# https://gitlab.com/gitlab-org/gitlab/-/issues/362890
|
|
ee_only_policy_check_queries = Gitlab.ee? ? 1 : 0
|
|
expect { query }.to make_queries(projects.size + 3 + ee_only_policy_check_queries)
|
|
end
|
|
end
|
|
|
|
describe '#execute', :request_store do
|
|
let(:projects_arg) { projects }
|
|
|
|
before do
|
|
Preloaders::UserMaxAccessLevelInProjectsPreloader.new(projects_arg, user).execute
|
|
end
|
|
|
|
it 'avoids N+1 queries' do
|
|
expect { query }.not_to make_queries
|
|
end
|
|
|
|
context 'when projects is an array of IDs' do
|
|
let(:projects_arg) { projects.map(&:id) }
|
|
|
|
it 'avoids N+1 queries' do
|
|
expect { query }.not_to make_queries
|
|
end
|
|
end
|
|
|
|
# Test for handling of SQL table name clashes.
|
|
context 'when projects is a relation including project_authorizations' do
|
|
let(:projects_arg) do
|
|
Project.where(id: ProjectAuthorization.where(project_id: projects).select(:project_id))
|
|
end
|
|
|
|
it 'avoids N+1 queries' do
|
|
expect { query }.not_to make_queries
|
|
end
|
|
end
|
|
end
|
|
end
|