d345591fc8
GitLab Performance Monitoring is now able to track custom events not directly related to application performance. These events include the number of tags pushed, repositories created, builds registered, etc. The use of these events is to get a better overview of how a GitLab instance is used and how that may affect performance. For example, a large number of Git pushes may have a negative impact on the underlying storage engine. Events are stored in the "events" measurement and are not prefixed with "rails_" or "sidekiq_", this makes it easier to query events with the same name triggered from different parts of the application. All events being stored in the same measurement also makes it easier to downsample data. Currently the following events are tracked: * Creating repositories * Removing repositories * Changing the default branch of a repository * Pushing a new tag * Removing an existing tag * Pushing a commit (along with the branch being pushed to) * Pushing a new branch * Removing an existing branch * Importing a repository (along with the URL we're importing) * Forking a repository (along with the source/target path) * CI builds registered (and when no build could be found) * CI builds being updated * Rails and Sidekiq exceptions Fixes gitlab-org/gitlab-ce#13720
203 lines
4.8 KiB
Ruby
203 lines
4.8 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe Gitlab::Metrics::Transaction do
|
|
let(:transaction) { described_class.new }
|
|
|
|
describe '#duration' do
|
|
it 'returns the duration of a transaction in seconds' do
|
|
transaction.run { sleep(0.5) }
|
|
|
|
expect(transaction.duration).to be >= 0.5
|
|
end
|
|
end
|
|
|
|
describe '#allocated_memory' do
|
|
it 'returns the allocated memory in bytes' do
|
|
transaction.run { 'a' * 32 }
|
|
|
|
expect(transaction.allocated_memory).to be_a_kind_of(Numeric)
|
|
end
|
|
end
|
|
|
|
describe '#run' do
|
|
it 'yields the supplied block' do
|
|
expect { |b| transaction.run(&b) }.to yield_control
|
|
end
|
|
|
|
it 'stores the transaction in the current thread' do
|
|
transaction.run do
|
|
expect(Thread.current[described_class::THREAD_KEY]).to eq(transaction)
|
|
end
|
|
end
|
|
|
|
it 'removes the transaction from the current thread upon completion' do
|
|
transaction.run { }
|
|
|
|
expect(Thread.current[described_class::THREAD_KEY]).to be_nil
|
|
end
|
|
end
|
|
|
|
describe '#add_metric' do
|
|
it 'adds a metric to the transaction' do
|
|
expect(Gitlab::Metrics::Metric).to receive(:new).
|
|
with('rails_foo', { number: 10 }, {})
|
|
|
|
transaction.add_metric('foo', number: 10)
|
|
end
|
|
end
|
|
|
|
describe '#method_call_for' do
|
|
it 'returns a MethodCall' do
|
|
method = transaction.method_call_for('Foo#bar')
|
|
|
|
expect(method).to be_an_instance_of(Gitlab::Metrics::MethodCall)
|
|
end
|
|
end
|
|
|
|
describe '#increment' do
|
|
it 'increments a counter' do
|
|
transaction.increment(:time, 1)
|
|
transaction.increment(:time, 2)
|
|
|
|
values = { duration: 0.0, time: 3, allocated_memory: a_kind_of(Numeric) }
|
|
|
|
expect(transaction).to receive(:add_metric).
|
|
with('transactions', values, {})
|
|
|
|
transaction.track_self
|
|
end
|
|
end
|
|
|
|
describe '#set' do
|
|
it 'sets a value' do
|
|
transaction.set(:number, 10)
|
|
|
|
values = {
|
|
duration: 0.0,
|
|
number: 10,
|
|
allocated_memory: a_kind_of(Numeric)
|
|
}
|
|
|
|
expect(transaction).to receive(:add_metric).
|
|
with('transactions', values, {})
|
|
|
|
transaction.track_self
|
|
end
|
|
end
|
|
|
|
describe '#add_tag' do
|
|
it 'adds a tag' do
|
|
transaction.add_tag(:foo, 'bar')
|
|
|
|
expect(transaction.tags).to eq({ foo: 'bar' })
|
|
end
|
|
end
|
|
|
|
describe '#finish' do
|
|
it 'tracks the transaction details and submits them to Sidekiq' do
|
|
expect(transaction).to receive(:track_self)
|
|
expect(transaction).to receive(:submit)
|
|
|
|
transaction.finish
|
|
end
|
|
end
|
|
|
|
describe '#track_self' do
|
|
it 'adds a metric for the transaction itself' do
|
|
values = {
|
|
duration: transaction.duration,
|
|
allocated_memory: a_kind_of(Numeric)
|
|
}
|
|
|
|
expect(transaction).to receive(:add_metric).
|
|
with('transactions', values, {})
|
|
|
|
transaction.track_self
|
|
end
|
|
end
|
|
|
|
describe '#submit' do
|
|
it 'submits the metrics to Sidekiq' do
|
|
transaction.track_self
|
|
|
|
expect(Gitlab::Metrics).to receive(:submit_metrics).
|
|
with([an_instance_of(Hash)])
|
|
|
|
transaction.submit
|
|
end
|
|
|
|
it 'adds the action as a tag for every metric' do
|
|
transaction.action = 'Foo#bar'
|
|
transaction.track_self
|
|
|
|
hash = {
|
|
series: 'rails_transactions',
|
|
tags: { action: 'Foo#bar' },
|
|
values: { duration: 0.0, allocated_memory: a_kind_of(Numeric) },
|
|
timestamp: an_instance_of(Fixnum)
|
|
}
|
|
|
|
expect(Gitlab::Metrics).to receive(:submit_metrics).
|
|
with([hash])
|
|
|
|
transaction.submit
|
|
end
|
|
|
|
it 'does not add an action tag for events' do
|
|
transaction.action = 'Foo#bar'
|
|
transaction.add_event(:meow)
|
|
|
|
hash = {
|
|
series: 'events',
|
|
tags: { event: :meow },
|
|
values: { count: 1 },
|
|
timestamp: an_instance_of(Fixnum)
|
|
}
|
|
|
|
expect(Gitlab::Metrics).to receive(:submit_metrics).
|
|
with([hash])
|
|
|
|
transaction.submit
|
|
end
|
|
end
|
|
|
|
describe '#add_event' do
|
|
it 'adds a metric' do
|
|
transaction.add_event(:meow)
|
|
|
|
expect(transaction.metrics[0]).to be_an_instance_of(Gitlab::Metrics::Metric)
|
|
end
|
|
|
|
it "does not prefix the metric's series name" do
|
|
transaction.add_event(:meow)
|
|
|
|
metric = transaction.metrics[0]
|
|
|
|
expect(metric.series).to eq(described_class::EVENT_SERIES)
|
|
end
|
|
|
|
it 'tracks a counter for every event' do
|
|
transaction.add_event(:meow)
|
|
|
|
metric = transaction.metrics[0]
|
|
|
|
expect(metric.values).to eq(count: 1)
|
|
end
|
|
|
|
it 'tracks the event name' do
|
|
transaction.add_event(:meow)
|
|
|
|
metric = transaction.metrics[0]
|
|
|
|
expect(metric.tags).to eq(event: :meow)
|
|
end
|
|
|
|
it 'allows tracking of custom tags' do
|
|
transaction.add_event(:meow, animal: 'cat')
|
|
|
|
metric = transaction.metrics[0]
|
|
|
|
expect(metric.tags).to eq(event: :meow, animal: 'cat')
|
|
end
|
|
end
|
|
end
|