ffb9b3ef18
This refactors repository caching so it's possible to selectively refresh certain caches, instead of just expiring and refreshing everything. To allow this the various methods that were cached (e.g. "tag_count" and "readme") use a similar pattern that makes expiring and refreshing their data much easier. In this new setup caches are refreshed as follows: 1. After a commit (but before running ProjectCacheWorker) we expire some basic caches such as the commit count and repository size. 2. ProjectCacheWorker will recalculate the commit count, repository size, then refresh a specific set of caches based on the list of files changed in a push payload. This requires a bunch of changes to the various methods that may be cached. For one, data should not be cached if a branch used or the entire repository does not exist. To prevent all these methods from handling this manually this is taken care of in Repository#cache_method_output. Some methods still manually check for the existence of a repository but this result is also cached. With selective flushing implemented ProjectCacheWorker no longer uses an exclusive lease for all of its work. Instead this worker only uses a lease to limit the number of times the repository size is updated as this is a fairly expensive operation.
38 lines
1.1 KiB
Ruby
38 lines
1.1 KiB
Ruby
# Worker for updating any project specific caches.
|
|
class ProjectCacheWorker
|
|
include Sidekiq::Worker
|
|
include DedicatedSidekiqQueue
|
|
|
|
LEASE_TIMEOUT = 15.minutes.to_i
|
|
|
|
# project_id - The ID of the project for which to flush the cache.
|
|
# refresh - An Array containing extra types of data to refresh such as
|
|
# `:readme` to flush the README and `:changelog` to flush the
|
|
# CHANGELOG.
|
|
def perform(project_id, refresh = [])
|
|
project = Project.find_by(id: project_id)
|
|
|
|
return unless project && project.repository.exists?
|
|
|
|
update_repository_size(project)
|
|
project.update_commit_count
|
|
|
|
project.repository.refresh_method_caches(refresh.map(&:to_sym))
|
|
end
|
|
|
|
def update_repository_size(project)
|
|
return unless try_obtain_lease_for(project.id, :update_repository_size)
|
|
|
|
Rails.logger.info("Updating repository size for project #{project.id}")
|
|
|
|
project.update_repository_size
|
|
end
|
|
|
|
private
|
|
|
|
def try_obtain_lease_for(project_id, section)
|
|
Gitlab::ExclusiveLease.
|
|
new("project_cache_worker:#{project_id}:#{section}", timeout: LEASE_TIMEOUT).
|
|
try_obtain
|
|
end
|
|
end
|