611 lines
19 KiB
Ruby
611 lines
19 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
describe Groups::ClustersController do
|
|
include AccessMatchersForController
|
|
include GoogleApi::CloudPlatformHelpers
|
|
|
|
set(:group) { create(:group) }
|
|
|
|
let(:user) { create(:user) }
|
|
|
|
before do
|
|
group.add_maintainer(user)
|
|
sign_in(user)
|
|
end
|
|
|
|
describe 'GET index' do
|
|
def go(params = {})
|
|
get :index, params: params.reverse_merge(group_id: group)
|
|
end
|
|
|
|
describe 'functionality' do
|
|
context 'when group has one or more clusters' do
|
|
let(:group) { create(:group) }
|
|
|
|
let!(:enabled_cluster) do
|
|
create(:cluster, :provided_by_gcp, cluster_type: :group_type, groups: [group])
|
|
end
|
|
|
|
let!(:disabled_cluster) do
|
|
create(:cluster, :disabled, :provided_by_gcp, :production_environment, cluster_type: :group_type, groups: [group])
|
|
end
|
|
|
|
it 'lists available clusters' do
|
|
go
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
expect(response).to render_template(:index)
|
|
expect(assigns(:clusters)).to match_array([enabled_cluster, disabled_cluster])
|
|
end
|
|
|
|
context 'when page is specified' do
|
|
let(:last_page) { group.clusters.page.total_pages }
|
|
|
|
before do
|
|
allow(Clusters::Cluster).to receive(:paginates_per).and_return(1)
|
|
create_list(:cluster, 2, :provided_by_gcp, :production_environment, cluster_type: :group_type, groups: [group])
|
|
end
|
|
|
|
it 'redirects to the page' do
|
|
go(page: last_page)
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
expect(assigns(:clusters).current_page).to eq(last_page)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when group does not have a cluster' do
|
|
let(:group) { create(:group) }
|
|
|
|
it 'returns an empty state page' do
|
|
go
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
expect(response).to render_template(:index, partial: :empty_state)
|
|
expect(assigns(:clusters)).to eq([])
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'security' do
|
|
let(:cluster) { create(:cluster, :provided_by_gcp, cluster_type: :group_type, groups: [group]) }
|
|
|
|
it { expect { go }.to be_allowed_for(:admin) }
|
|
it { expect { go }.to be_allowed_for(:owner).of(group) }
|
|
it { expect { go }.to be_allowed_for(:maintainer).of(group) }
|
|
it { expect { go }.to be_denied_for(:developer).of(group) }
|
|
it { expect { go }.to be_denied_for(:reporter).of(group) }
|
|
it { expect { go }.to be_denied_for(:guest).of(group) }
|
|
it { expect { go }.to be_denied_for(:user) }
|
|
it { expect { go }.to be_denied_for(:external) }
|
|
end
|
|
end
|
|
|
|
describe 'GET new' do
|
|
def go
|
|
get :new, params: { group_id: group }
|
|
end
|
|
|
|
describe 'functionality for new cluster' do
|
|
context 'when omniauth has been configured' do
|
|
let(:key) { 'secret-key' }
|
|
let(:session_key_for_redirect_uri) do
|
|
GoogleApi::CloudPlatform::Client.session_key_for_redirect_uri(key)
|
|
end
|
|
|
|
before do
|
|
allow(SecureRandom).to receive(:hex).and_return(key)
|
|
end
|
|
|
|
it 'has authorize_url' do
|
|
go
|
|
|
|
expect(assigns(:authorize_url)).to include(key)
|
|
expect(session[session_key_for_redirect_uri]).to eq(new_group_cluster_path(group))
|
|
end
|
|
end
|
|
|
|
context 'when omniauth has not configured' do
|
|
before do
|
|
stub_omniauth_setting(providers: [])
|
|
end
|
|
|
|
it 'does not have authorize_url' do
|
|
go
|
|
|
|
expect(assigns(:authorize_url)).to be_nil
|
|
end
|
|
end
|
|
|
|
context 'when access token is valid' do
|
|
before do
|
|
stub_google_api_validate_token
|
|
end
|
|
|
|
it 'has new object' do
|
|
go
|
|
|
|
expect(assigns(:gcp_cluster)).to be_an_instance_of(Clusters::ClusterPresenter)
|
|
end
|
|
end
|
|
|
|
context 'when access token is expired' do
|
|
before do
|
|
stub_google_api_expired_token
|
|
end
|
|
|
|
it { expect(@valid_gcp_token).to be_falsey }
|
|
end
|
|
|
|
context 'when access token is not stored in session' do
|
|
it { expect(@valid_gcp_token).to be_falsey }
|
|
end
|
|
end
|
|
|
|
describe 'functionality for existing cluster' do
|
|
it 'has new object' do
|
|
go
|
|
|
|
expect(assigns(:user_cluster)).to be_an_instance_of(Clusters::ClusterPresenter)
|
|
end
|
|
end
|
|
|
|
describe 'security' do
|
|
it { expect { go }.to be_allowed_for(:admin) }
|
|
it { expect { go }.to be_allowed_for(:owner).of(group) }
|
|
it { expect { go }.to be_allowed_for(:maintainer).of(group) }
|
|
it { expect { go }.to be_denied_for(:developer).of(group) }
|
|
it { expect { go }.to be_denied_for(:reporter).of(group) }
|
|
it { expect { go }.to be_denied_for(:guest).of(group) }
|
|
it { expect { go }.to be_denied_for(:user) }
|
|
it { expect { go }.to be_denied_for(:external) }
|
|
end
|
|
end
|
|
|
|
describe 'POST create for new cluster' do
|
|
let(:legacy_abac_param) { 'true' }
|
|
let(:params) do
|
|
{
|
|
cluster: {
|
|
name: 'new-cluster',
|
|
managed: '1',
|
|
provider_gcp_attributes: {
|
|
gcp_project_id: 'gcp-project-12345',
|
|
legacy_abac: legacy_abac_param
|
|
}
|
|
}
|
|
}
|
|
end
|
|
|
|
def go
|
|
post :create_gcp, params: params.merge(group_id: group)
|
|
end
|
|
|
|
describe 'functionality' do
|
|
context 'when access token is valid' do
|
|
before do
|
|
stub_google_api_validate_token
|
|
end
|
|
|
|
it 'creates a new cluster' do
|
|
expect(ClusterProvisionWorker).to receive(:perform_async)
|
|
expect { go }.to change { Clusters::Cluster.count }
|
|
.and change { Clusters::Providers::Gcp.count }
|
|
|
|
cluster = group.clusters.first
|
|
|
|
expect(response).to redirect_to(group_cluster_path(group, cluster))
|
|
expect(cluster).to be_gcp
|
|
expect(cluster).to be_kubernetes
|
|
expect(cluster.provider_gcp).to be_legacy_abac
|
|
expect(cluster).to be_managed
|
|
end
|
|
|
|
context 'when legacy_abac param is false' do
|
|
let(:legacy_abac_param) { 'false' }
|
|
|
|
it 'creates a new cluster with legacy_abac_disabled' do
|
|
expect(ClusterProvisionWorker).to receive(:perform_async)
|
|
expect { go }.to change { Clusters::Cluster.count }
|
|
.and change { Clusters::Providers::Gcp.count }
|
|
expect(group.clusters.first.provider_gcp).not_to be_legacy_abac
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when access token is expired' do
|
|
before do
|
|
stub_google_api_expired_token
|
|
end
|
|
|
|
it { expect(@valid_gcp_token).to be_falsey }
|
|
end
|
|
|
|
context 'when access token is not stored in session' do
|
|
it { expect(@valid_gcp_token).to be_falsey }
|
|
end
|
|
end
|
|
|
|
describe 'security' do
|
|
before do
|
|
allow_any_instance_of(described_class)
|
|
.to receive(:token_in_session).and_return('token')
|
|
allow_any_instance_of(described_class)
|
|
.to receive(:expires_at_in_session).and_return(1.hour.since.to_i.to_s)
|
|
allow_any_instance_of(GoogleApi::CloudPlatform::Client)
|
|
.to receive(:projects_zones_clusters_create) do
|
|
OpenStruct.new(
|
|
self_link: 'projects/gcp-project-12345/zones/us-central1-a/operations/ope-123',
|
|
status: 'RUNNING'
|
|
)
|
|
end
|
|
|
|
allow(WaitForClusterCreationWorker).to receive(:perform_in).and_return(nil)
|
|
end
|
|
|
|
it { expect { go }.to be_allowed_for(:admin) }
|
|
it { expect { go }.to be_allowed_for(:owner).of(group) }
|
|
it { expect { go }.to be_allowed_for(:maintainer).of(group) }
|
|
it { expect { go }.to be_denied_for(:developer).of(group) }
|
|
it { expect { go }.to be_denied_for(:reporter).of(group) }
|
|
it { expect { go }.to be_denied_for(:guest).of(group) }
|
|
it { expect { go }.to be_denied_for(:user) }
|
|
it { expect { go }.to be_denied_for(:external) }
|
|
end
|
|
end
|
|
|
|
describe 'POST create for existing cluster' do
|
|
let(:params) do
|
|
{
|
|
cluster: {
|
|
name: 'new-cluster',
|
|
managed: '1',
|
|
platform_kubernetes_attributes: {
|
|
api_url: 'http://my-url',
|
|
token: 'test'
|
|
}
|
|
}
|
|
}
|
|
end
|
|
|
|
def go
|
|
post :create_user, params: params.merge(group_id: group)
|
|
end
|
|
|
|
describe 'functionality' do
|
|
context 'when creates a cluster' do
|
|
it 'creates a new cluster' do
|
|
expect(ClusterProvisionWorker).to receive(:perform_async)
|
|
|
|
expect { go }.to change { Clusters::Cluster.count }
|
|
.and change { Clusters::Platforms::Kubernetes.count }
|
|
|
|
cluster = group.clusters.first
|
|
|
|
expect(response).to redirect_to(group_cluster_path(group, cluster))
|
|
expect(cluster).to be_user
|
|
expect(cluster).to be_kubernetes
|
|
expect(cluster).to be_managed
|
|
end
|
|
end
|
|
|
|
context 'when creates a RBAC-enabled cluster' do
|
|
let(:params) do
|
|
{
|
|
cluster: {
|
|
name: 'new-cluster',
|
|
platform_kubernetes_attributes: {
|
|
api_url: 'http://my-url',
|
|
token: 'test',
|
|
authorization_type: 'rbac'
|
|
}
|
|
}
|
|
}
|
|
end
|
|
|
|
it 'creates a new cluster' do
|
|
expect(ClusterProvisionWorker).to receive(:perform_async)
|
|
|
|
expect { go }.to change { Clusters::Cluster.count }
|
|
.and change { Clusters::Platforms::Kubernetes.count }
|
|
|
|
cluster = group.clusters.first
|
|
|
|
expect(response).to redirect_to(group_cluster_path(group, cluster))
|
|
expect(cluster).to be_user
|
|
expect(cluster).to be_kubernetes
|
|
expect(cluster).to be_platform_kubernetes_rbac
|
|
end
|
|
end
|
|
|
|
context 'when creates a user-managed cluster' do
|
|
let(:params) do
|
|
{
|
|
cluster: {
|
|
name: 'new-cluster',
|
|
managed: '0',
|
|
platform_kubernetes_attributes: {
|
|
api_url: 'http://my-url',
|
|
token: 'test',
|
|
authorization_type: 'rbac'
|
|
}
|
|
}
|
|
}
|
|
end
|
|
|
|
it 'creates a new user-managed cluster' do
|
|
go
|
|
|
|
cluster = group.clusters.first
|
|
expect(cluster.managed?).to be_falsy
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'security' do
|
|
it { expect { go }.to be_allowed_for(:admin) }
|
|
it { expect { go }.to be_allowed_for(:owner).of(group) }
|
|
it { expect { go }.to be_allowed_for(:maintainer).of(group) }
|
|
it { expect { go }.to be_denied_for(:developer).of(group) }
|
|
it { expect { go }.to be_denied_for(:reporter).of(group) }
|
|
it { expect { go }.to be_denied_for(:guest).of(group) }
|
|
it { expect { go }.to be_denied_for(:user) }
|
|
it { expect { go }.to be_denied_for(:external) }
|
|
end
|
|
end
|
|
|
|
describe 'GET cluster_status' do
|
|
let(:cluster) { create(:cluster, :providing_by_gcp, cluster_type: :group_type, groups: [group]) }
|
|
|
|
def go
|
|
get :cluster_status,
|
|
params: {
|
|
group_id: group.to_param,
|
|
id: cluster
|
|
},
|
|
format: :json
|
|
end
|
|
|
|
describe 'functionality' do
|
|
it 'responds with matching schema' do
|
|
go
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
expect(response).to match_response_schema('cluster_status')
|
|
end
|
|
|
|
it 'invokes schedule_status_update on each application' do
|
|
expect_any_instance_of(Clusters::Applications::Ingress).to receive(:schedule_status_update)
|
|
|
|
go
|
|
end
|
|
end
|
|
|
|
describe 'security' do
|
|
it { expect { go }.to be_allowed_for(:admin) }
|
|
it { expect { go }.to be_allowed_for(:owner).of(group) }
|
|
it { expect { go }.to be_allowed_for(:maintainer).of(group) }
|
|
it { expect { go }.to be_denied_for(:developer).of(group) }
|
|
it { expect { go }.to be_denied_for(:reporter).of(group) }
|
|
it { expect { go }.to be_denied_for(:guest).of(group) }
|
|
it { expect { go }.to be_denied_for(:user) }
|
|
it { expect { go }.to be_denied_for(:external) }
|
|
end
|
|
end
|
|
|
|
describe 'GET show' do
|
|
let(:cluster) { create(:cluster, :provided_by_gcp, cluster_type: :group_type, groups: [group]) }
|
|
|
|
def go
|
|
get :show,
|
|
params: {
|
|
group_id: group,
|
|
id: cluster
|
|
}
|
|
end
|
|
|
|
describe 'functionality' do
|
|
it 'renders view' do
|
|
go
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
expect(assigns(:cluster)).to eq(cluster)
|
|
end
|
|
end
|
|
|
|
describe 'security' do
|
|
it { expect { go }.to be_allowed_for(:admin) }
|
|
it { expect { go }.to be_allowed_for(:owner).of(group) }
|
|
it { expect { go }.to be_allowed_for(:maintainer).of(group) }
|
|
it { expect { go }.to be_denied_for(:developer).of(group) }
|
|
it { expect { go }.to be_denied_for(:reporter).of(group) }
|
|
it { expect { go }.to be_denied_for(:guest).of(group) }
|
|
it { expect { go }.to be_denied_for(:user) }
|
|
it { expect { go }.to be_denied_for(:external) }
|
|
end
|
|
end
|
|
|
|
describe 'PUT update' do
|
|
def go(format: :html)
|
|
put :update, params: params.merge(
|
|
group_id: group.to_param,
|
|
id: cluster,
|
|
format: format
|
|
)
|
|
end
|
|
|
|
let(:cluster) { create(:cluster, :provided_by_user, cluster_type: :group_type, groups: [group]) }
|
|
let(:domain) { 'test-domain.com' }
|
|
|
|
let(:params) do
|
|
{
|
|
cluster: {
|
|
enabled: false,
|
|
name: 'my-new-cluster-name',
|
|
managed: false,
|
|
base_domain: domain
|
|
}
|
|
}
|
|
end
|
|
|
|
it 'updates and redirects back to show page' do
|
|
go
|
|
|
|
cluster.reload
|
|
expect(response).to redirect_to(group_cluster_path(group, cluster))
|
|
expect(flash[:notice]).to eq('Kubernetes cluster was successfully updated.')
|
|
expect(cluster.enabled).to be_falsey
|
|
expect(cluster.name).to eq('my-new-cluster-name')
|
|
expect(cluster).not_to be_managed
|
|
expect(cluster.domain).to eq('test-domain.com')
|
|
end
|
|
|
|
context 'when domain is invalid' do
|
|
let(:domain) { 'http://not-a-valid-domain' }
|
|
|
|
it 'does not update cluster attributes' do
|
|
go
|
|
|
|
cluster.reload
|
|
expect(response).to render_template(:show)
|
|
expect(cluster.name).not_to eq('my-new-cluster-name')
|
|
expect(cluster.domain).not_to eq('test-domain.com')
|
|
end
|
|
end
|
|
|
|
context 'when format is json' do
|
|
context 'when changing parameters' do
|
|
context 'when valid parameters are used' do
|
|
let(:params) do
|
|
{
|
|
cluster: {
|
|
enabled: false,
|
|
name: 'my-new-cluster-name',
|
|
managed: false,
|
|
domain: domain
|
|
}
|
|
}
|
|
end
|
|
|
|
it 'updates and redirects back to show page' do
|
|
go(format: :json)
|
|
|
|
cluster.reload
|
|
expect(response).to have_http_status(:no_content)
|
|
expect(cluster.enabled).to be_falsey
|
|
expect(cluster.name).to eq('my-new-cluster-name')
|
|
expect(cluster).not_to be_managed
|
|
end
|
|
end
|
|
|
|
context 'when invalid parameters are used' do
|
|
let(:params) do
|
|
{
|
|
cluster: {
|
|
enabled: false,
|
|
name: ''
|
|
}
|
|
}
|
|
end
|
|
|
|
it 'rejects changes' do
|
|
go(format: :json)
|
|
|
|
expect(response).to have_http_status(:bad_request)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'security' do
|
|
set(:cluster) { create(:cluster, :provided_by_gcp, cluster_type: :group_type, groups: [group]) }
|
|
|
|
it { expect { go }.to be_allowed_for(:admin) }
|
|
it { expect { go }.to be_allowed_for(:owner).of(group) }
|
|
it { expect { go }.to be_allowed_for(:maintainer).of(group) }
|
|
it { expect { go }.to be_denied_for(:developer).of(group) }
|
|
it { expect { go }.to be_denied_for(:reporter).of(group) }
|
|
it { expect { go }.to be_denied_for(:guest).of(group) }
|
|
it { expect { go }.to be_denied_for(:user) }
|
|
it { expect { go }.to be_denied_for(:external) }
|
|
end
|
|
end
|
|
|
|
describe 'DELETE destroy' do
|
|
let!(:cluster) { create(:cluster, :provided_by_gcp, :production_environment, cluster_type: :group_type, groups: [group]) }
|
|
|
|
def go
|
|
delete :destroy,
|
|
params: {
|
|
group_id: group,
|
|
id: cluster
|
|
}
|
|
end
|
|
|
|
describe 'functionality' do
|
|
context 'when cluster is provided by GCP' do
|
|
context 'when cluster is created' do
|
|
it 'destroys and redirects back to clusters list' do
|
|
expect { go }
|
|
.to change { Clusters::Cluster.count }.by(-1)
|
|
.and change { Clusters::Platforms::Kubernetes.count }.by(-1)
|
|
.and change { Clusters::Providers::Gcp.count }.by(-1)
|
|
|
|
expect(response).to redirect_to(group_clusters_path(group))
|
|
expect(flash[:notice]).to eq('Kubernetes cluster integration was successfully removed.')
|
|
end
|
|
end
|
|
|
|
context 'when cluster is being created' do
|
|
let!(:cluster) { create(:cluster, :providing_by_gcp, :production_environment, cluster_type: :group_type, groups: [group]) }
|
|
|
|
it 'destroys and redirects back to clusters list' do
|
|
expect { go }
|
|
.to change { Clusters::Cluster.count }.by(-1)
|
|
.and change { Clusters::Providers::Gcp.count }.by(-1)
|
|
|
|
expect(response).to redirect_to(group_clusters_path(group))
|
|
expect(flash[:notice]).to eq('Kubernetes cluster integration was successfully removed.')
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when cluster is provided by user' do
|
|
let!(:cluster) { create(:cluster, :provided_by_user, :production_environment, cluster_type: :group_type, groups: [group]) }
|
|
|
|
it 'destroys and redirects back to clusters list' do
|
|
expect { go }
|
|
.to change { Clusters::Cluster.count }.by(-1)
|
|
.and change { Clusters::Platforms::Kubernetes.count }.by(-1)
|
|
.and change { Clusters::Providers::Gcp.count }.by(0)
|
|
|
|
expect(response).to redirect_to(group_clusters_path(group))
|
|
expect(flash[:notice]).to eq('Kubernetes cluster integration was successfully removed.')
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'security' do
|
|
set(:cluster) { create(:cluster, :provided_by_gcp, :production_environment, cluster_type: :group_type, groups: [group]) }
|
|
|
|
it { expect { go }.to be_allowed_for(:admin) }
|
|
it { expect { go }.to be_allowed_for(:owner).of(group) }
|
|
it { expect { go }.to be_allowed_for(:maintainer).of(group) }
|
|
it { expect { go }.to be_denied_for(:developer).of(group) }
|
|
it { expect { go }.to be_denied_for(:reporter).of(group) }
|
|
it { expect { go }.to be_denied_for(:guest).of(group) }
|
|
it { expect { go }.to be_denied_for(:user) }
|
|
it { expect { go }.to be_denied_for(:external) }
|
|
end
|
|
end
|
|
|
|
context 'no group_id param' do
|
|
it 'does not respond to any action without group_id param' do
|
|
expect { get :index }.to raise_error(ActionController::UrlGenerationError)
|
|
end
|
|
end
|
|
end
|