cdf3ae04f8
Rugged sometimes chops a context line in between bytes, resulting in the context line having an invalid encoding: https://github.com/libgit2/rugged/issues/716 When that happens, we will try to detect the encoding for the diff, and sometimes we'll get it wrong. If that difference in encoding results in a difference in string lengths between the diff and the underlying blobs, we'd fail to highlight any inline diffs, and return a 500 status to the user. As we're using the underlying blobs, the encoding is 'correct' anyway, so if the string range is invalid, we can just discard the inline diff highlighting. We still report to Sentry to ensure that we can investigate further in future. |
||
|---|---|---|
| .. | ||
| file_collection | ||
| formatters | ||
| diff_refs_spec.rb | ||
| file_spec.rb | ||
| highlight_spec.rb | ||
| inline_diff_markdown_marker_spec.rb | ||
| inline_diff_marker_spec.rb | ||
| inline_diff_spec.rb | ||
| line_mapper_spec.rb | ||
| parallel_diff_spec.rb | ||
| parser_spec.rb | ||
| position_spec.rb | ||
| position_tracer_spec.rb | ||