eef3609123
This also updates _some_ specs to use these new methods, just to serve as an example for others going forward, but by no means is this exhaustive. Original implementations at !5992 and !6012. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/20944
329 lines
12 KiB
Ruby
329 lines
12 KiB
Ruby
require "spec_helper"
|
|
|
|
describe ProjectTeam, models: true do
|
|
let(:master) { create(:user) }
|
|
let(:reporter) { create(:user) }
|
|
let(:guest) { create(:user) }
|
|
let(:nonmember) { create(:user) }
|
|
|
|
context 'personal project' do
|
|
let(:project) { create(:empty_project) }
|
|
|
|
before do
|
|
project.add_master(master)
|
|
project.add_reporter(reporter)
|
|
project.add_guest(guest)
|
|
end
|
|
|
|
describe 'members collection' do
|
|
it { expect(project.team.masters).to include(master) }
|
|
it { expect(project.team.masters).not_to include(guest) }
|
|
it { expect(project.team.masters).not_to include(reporter) }
|
|
it { expect(project.team.masters).not_to include(nonmember) }
|
|
end
|
|
|
|
describe 'access methods' do
|
|
it { expect(project.team.master?(master)).to be_truthy }
|
|
it { expect(project.team.master?(guest)).to be_falsey }
|
|
it { expect(project.team.master?(reporter)).to be_falsey }
|
|
it { expect(project.team.master?(nonmember)).to be_falsey }
|
|
it { expect(project.team.member?(nonmember)).to be_falsey }
|
|
it { expect(project.team.member?(guest)).to be_truthy }
|
|
it { expect(project.team.member?(reporter, Gitlab::Access::REPORTER)).to be_truthy }
|
|
it { expect(project.team.member?(guest, Gitlab::Access::REPORTER)).to be_falsey }
|
|
it { expect(project.team.member?(nonmember, Gitlab::Access::GUEST)).to be_falsey }
|
|
end
|
|
end
|
|
|
|
context 'group project' do
|
|
let(:group) { create(:group) }
|
|
let(:project) { create(:empty_project, group: group) }
|
|
|
|
before do
|
|
group.add_master(master)
|
|
group.add_reporter(reporter)
|
|
group.add_guest(guest)
|
|
|
|
# If user is a group and a project member - GitLab uses highest permission
|
|
# So we add group guest as master and add group master as guest
|
|
# to this project to test highest access
|
|
project.add_master(guest)
|
|
project.add_guest(master)
|
|
end
|
|
|
|
describe 'members collection' do
|
|
it { expect(project.team.reporters).to include(reporter) }
|
|
it { expect(project.team.masters).to include(master) }
|
|
it { expect(project.team.masters).to include(guest) }
|
|
it { expect(project.team.masters).not_to include(reporter) }
|
|
it { expect(project.team.masters).not_to include(nonmember) }
|
|
end
|
|
|
|
describe 'access methods' do
|
|
it { expect(project.team.reporter?(reporter)).to be_truthy }
|
|
it { expect(project.team.master?(master)).to be_truthy }
|
|
it { expect(project.team.master?(guest)).to be_truthy }
|
|
it { expect(project.team.master?(reporter)).to be_falsey }
|
|
it { expect(project.team.master?(nonmember)).to be_falsey }
|
|
it { expect(project.team.member?(nonmember)).to be_falsey }
|
|
it { expect(project.team.member?(guest)).to be_truthy }
|
|
it { expect(project.team.member?(guest, Gitlab::Access::MASTER)).to be_truthy }
|
|
it { expect(project.team.member?(reporter, Gitlab::Access::MASTER)).to be_falsey }
|
|
it { expect(project.team.member?(nonmember, Gitlab::Access::GUEST)).to be_falsey }
|
|
end
|
|
end
|
|
|
|
describe '#fetch_members' do
|
|
context 'personal project' do
|
|
let(:project) { create(:empty_project) }
|
|
|
|
it 'returns project members' do
|
|
user = create(:user)
|
|
project.add_guest(user)
|
|
|
|
expect(project.team.members).to contain_exactly(user)
|
|
end
|
|
|
|
it 'returns project members of a specified level' do
|
|
user = create(:user)
|
|
project.add_reporter(user)
|
|
|
|
expect(project.team.guests).to be_empty
|
|
expect(project.team.reporters).to contain_exactly(user)
|
|
end
|
|
|
|
it 'returns invited members of a group' do
|
|
group_member = create(:group_member)
|
|
|
|
project.project_group_links.create!(
|
|
group: group_member.group,
|
|
group_access: Gitlab::Access::GUEST
|
|
)
|
|
|
|
expect(project.team.members).to contain_exactly(group_member.user)
|
|
end
|
|
|
|
it 'returns invited members of a group of a specified level' do
|
|
group_member = create(:group_member)
|
|
|
|
project.project_group_links.create!(
|
|
group: group_member.group,
|
|
group_access: Gitlab::Access::REPORTER
|
|
)
|
|
|
|
expect(project.team.guests).to be_empty
|
|
expect(project.team.reporters).to contain_exactly(group_member.user)
|
|
end
|
|
end
|
|
|
|
context 'group project' do
|
|
let(:group) { create(:group) }
|
|
let(:project) { create(:empty_project, group: group) }
|
|
|
|
it 'returns project members' do
|
|
group_member = create(:group_member, group: group)
|
|
|
|
expect(project.team.members).to contain_exactly(group_member.user)
|
|
end
|
|
|
|
it 'returns project members of a specified level' do
|
|
group_member = create(:group_member, :reporter, group: group)
|
|
|
|
expect(project.team.guests).to be_empty
|
|
expect(project.team.reporters).to contain_exactly(group_member.user)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#find_member' do
|
|
context 'personal project' do
|
|
let(:project) { create(:empty_project, :public, :access_requestable) }
|
|
let(:requester) { create(:user) }
|
|
|
|
before do
|
|
project.add_master(master)
|
|
project.add_reporter(reporter)
|
|
project.add_guest(guest)
|
|
project.request_access(requester)
|
|
end
|
|
|
|
it { expect(project.team.find_member(master.id)).to be_a(ProjectMember) }
|
|
it { expect(project.team.find_member(reporter.id)).to be_a(ProjectMember) }
|
|
it { expect(project.team.find_member(guest.id)).to be_a(ProjectMember) }
|
|
it { expect(project.team.find_member(nonmember.id)).to be_nil }
|
|
it { expect(project.team.find_member(requester.id)).to be_nil }
|
|
end
|
|
|
|
context 'group project' do
|
|
let(:group) { create(:group, :access_requestable) }
|
|
let(:project) { create(:empty_project, group: group) }
|
|
let(:requester) { create(:user) }
|
|
|
|
before do
|
|
group.add_master(master)
|
|
group.add_reporter(reporter)
|
|
group.add_guest(guest)
|
|
group.request_access(requester)
|
|
end
|
|
|
|
it { expect(project.team.find_member(master.id)).to be_a(GroupMember) }
|
|
it { expect(project.team.find_member(reporter.id)).to be_a(GroupMember) }
|
|
it { expect(project.team.find_member(guest.id)).to be_a(GroupMember) }
|
|
it { expect(project.team.find_member(nonmember.id)).to be_nil }
|
|
it { expect(project.team.find_member(requester.id)).to be_nil }
|
|
end
|
|
end
|
|
|
|
describe "#human_max_access" do
|
|
it 'returns Master role' do
|
|
user = create(:user)
|
|
group = create(:group)
|
|
group.add_master(user)
|
|
|
|
project = build_stubbed(:empty_project, namespace: group)
|
|
|
|
expect(project.team.human_max_access(user.id)).to eq 'Master'
|
|
end
|
|
|
|
it 'returns Owner role' do
|
|
user = create(:user)
|
|
group = create(:group)
|
|
group.add_owner(user)
|
|
|
|
project = build_stubbed(:empty_project, namespace: group)
|
|
|
|
expect(project.team.human_max_access(user.id)).to eq 'Owner'
|
|
end
|
|
end
|
|
|
|
describe '#max_member_access' do
|
|
let(:requester) { create(:user) }
|
|
|
|
context 'personal project' do
|
|
let(:project) { create(:empty_project, :public, :access_requestable) }
|
|
|
|
context 'when project is not shared with group' do
|
|
before do
|
|
project.add_master(master)
|
|
project.add_reporter(reporter)
|
|
project.add_guest(guest)
|
|
project.request_access(requester)
|
|
end
|
|
|
|
it { expect(project.team.max_member_access(master.id)).to eq(Gitlab::Access::MASTER) }
|
|
it { expect(project.team.max_member_access(reporter.id)).to eq(Gitlab::Access::REPORTER) }
|
|
it { expect(project.team.max_member_access(guest.id)).to eq(Gitlab::Access::GUEST) }
|
|
it { expect(project.team.max_member_access(nonmember.id)).to eq(Gitlab::Access::NO_ACCESS) }
|
|
it { expect(project.team.max_member_access(requester.id)).to eq(Gitlab::Access::NO_ACCESS) }
|
|
end
|
|
|
|
context 'when project is shared with group' do
|
|
before do
|
|
group = create(:group)
|
|
project.project_group_links.create(
|
|
group: group,
|
|
group_access: Gitlab::Access::DEVELOPER)
|
|
|
|
group.add_master(master)
|
|
group.add_reporter(reporter)
|
|
end
|
|
|
|
it { expect(project.team.max_member_access(master.id)).to eq(Gitlab::Access::DEVELOPER) }
|
|
it { expect(project.team.max_member_access(reporter.id)).to eq(Gitlab::Access::REPORTER) }
|
|
it { expect(project.team.max_member_access(nonmember.id)).to eq(Gitlab::Access::NO_ACCESS) }
|
|
it { expect(project.team.max_member_access(requester.id)).to eq(Gitlab::Access::NO_ACCESS) }
|
|
|
|
context 'but share_with_group_lock is true' do
|
|
before { project.namespace.update(share_with_group_lock: true) }
|
|
|
|
it { expect(project.team.max_member_access(master.id)).to eq(Gitlab::Access::NO_ACCESS) }
|
|
it { expect(project.team.max_member_access(reporter.id)).to eq(Gitlab::Access::NO_ACCESS) }
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'group project' do
|
|
let(:group) { create(:group, :access_requestable) }
|
|
let(:project) { create(:empty_project, group: group) }
|
|
|
|
before do
|
|
group.add_master(master)
|
|
group.add_reporter(reporter)
|
|
group.add_guest(guest)
|
|
group.request_access(requester)
|
|
end
|
|
|
|
it { expect(project.team.max_member_access(master.id)).to eq(Gitlab::Access::MASTER) }
|
|
it { expect(project.team.max_member_access(reporter.id)).to eq(Gitlab::Access::REPORTER) }
|
|
it { expect(project.team.max_member_access(guest.id)).to eq(Gitlab::Access::GUEST) }
|
|
it { expect(project.team.max_member_access(nonmember.id)).to eq(Gitlab::Access::NO_ACCESS) }
|
|
it { expect(project.team.max_member_access(requester.id)).to eq(Gitlab::Access::NO_ACCESS) }
|
|
end
|
|
end
|
|
|
|
shared_examples_for "#max_member_access_for_users" do |enable_request_store|
|
|
describe "#max_member_access_for_users" do
|
|
before do
|
|
RequestStore.begin! if enable_request_store
|
|
end
|
|
|
|
after do
|
|
if enable_request_store
|
|
RequestStore.end!
|
|
RequestStore.clear!
|
|
end
|
|
end
|
|
|
|
it 'returns correct roles for different users' do
|
|
master = create(:user)
|
|
reporter = create(:user)
|
|
promoted_guest = create(:user)
|
|
guest = create(:user)
|
|
project = create(:project)
|
|
|
|
project.add_master(master)
|
|
project.add_reporter(reporter)
|
|
project.add_guest(promoted_guest)
|
|
project.add_guest(guest)
|
|
|
|
group = create(:group)
|
|
group_developer = create(:user)
|
|
second_developer = create(:user)
|
|
project.project_group_links.create(
|
|
group: group,
|
|
group_access: Gitlab::Access::DEVELOPER)
|
|
|
|
group.add_master(promoted_guest)
|
|
group.add_developer(group_developer)
|
|
group.add_developer(second_developer)
|
|
|
|
second_group = create(:group)
|
|
project.project_group_links.create(
|
|
group: second_group,
|
|
group_access: Gitlab::Access::MASTER)
|
|
second_group.add_master(second_developer)
|
|
|
|
users = [master, reporter, promoted_guest, guest, group_developer, second_developer].map(&:id)
|
|
|
|
expected = {
|
|
master.id => Gitlab::Access::MASTER,
|
|
reporter.id => Gitlab::Access::REPORTER,
|
|
promoted_guest.id => Gitlab::Access::DEVELOPER,
|
|
guest.id => Gitlab::Access::GUEST,
|
|
group_developer.id => Gitlab::Access::DEVELOPER,
|
|
second_developer.id => Gitlab::Access::MASTER
|
|
}
|
|
|
|
expect(project.team.max_member_access_for_user_ids(users)).to eq(expected)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#max_member_access_for_users with RequestStore' do
|
|
it_behaves_like "#max_member_access_for_users", true
|
|
end
|
|
|
|
describe '#max_member_access_for_users without RequestStore' do
|
|
it_behaves_like "#max_member_access_for_users", false
|
|
end
|
|
end
|