fb6a4e21d4
This brings back some of the changes in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/20339. For users using Gitaly on top of NFS, accessing the Git data directly via Rugged is more performant than Gitaly. This merge request introduces the feature flag `rugged_find_commit` to activate Rugged paths. There are also Rake tasks `gitlab:features:enable_rugged` and `gitlab:features:disable_rugged` to enable/disable these feature flags altogether. Part of four Rugged changes identified in https://gitlab.com/gitlab-org/gitlab-ce/issues/57317.
78 lines
2.5 KiB
Ruby
78 lines
2.5 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
module Gitlab
|
|
module GitalyClient
|
|
# This is a chokepoint that is meant to help us stop remove all places
|
|
# where production code (app, config, db, lib) touches Git repositories
|
|
# directly.
|
|
class StorageSettings
|
|
extend Gitlab::TemporarilyAllow
|
|
|
|
DirectPathAccessError = Class.new(StandardError)
|
|
InvalidConfigurationError = Class.new(StandardError)
|
|
|
|
INVALID_STORAGE_MESSAGE = <<~MSG.freeze
|
|
Storage is invalid because it has no `path` key.
|
|
|
|
For source installations, update your config/gitlab.yml Refer to gitlab.yml.example for an updated example.
|
|
If you're using the GitLab Development Kit, you can update your configuration running `gdk reconfigure`.
|
|
MSG
|
|
|
|
# This class will give easily recognizable NoMethodErrors
|
|
Deprecated = Class.new
|
|
|
|
MUTEX = Mutex.new
|
|
|
|
DISK_ACCESS_DENIED_FLAG = :deny_disk_access
|
|
ALLOW_KEY = :allow_disk_access
|
|
|
|
# If your code needs this method then your code needs to be fixed.
|
|
def self.allow_disk_access
|
|
temporarily_allow(ALLOW_KEY) { yield }
|
|
end
|
|
|
|
def self.disk_access_denied?
|
|
return false if rugged_enabled?
|
|
|
|
!temporarily_allowed?(ALLOW_KEY) && GitalyClient.feature_enabled?(DISK_ACCESS_DENIED_FLAG)
|
|
rescue
|
|
false # Err on the side of caution, don't break gitlab for people
|
|
end
|
|
|
|
def self.rugged_enabled?
|
|
Gitlab::Git::RuggedImpl::Repository::FEATURE_FLAGS.any? do |flag|
|
|
Feature.enabled?(flag)
|
|
end
|
|
end
|
|
|
|
def initialize(storage)
|
|
raise InvalidConfigurationError, "expected a Hash, got a #{storage.class.name}" unless storage.is_a?(Hash)
|
|
raise InvalidConfigurationError, INVALID_STORAGE_MESSAGE unless storage.has_key?('path')
|
|
|
|
# Support a nil 'path' field because some of the circuit breaker tests use it.
|
|
@legacy_disk_path = File.expand_path(storage['path'], Rails.root) if storage['path']
|
|
|
|
storage['path'] = Deprecated
|
|
@hash = storage
|
|
end
|
|
|
|
def gitaly_address
|
|
@hash.fetch(:gitaly_address)
|
|
end
|
|
|
|
def legacy_disk_path
|
|
if self.class.disk_access_denied?
|
|
raise DirectPathAccessError, "git disk access denied via the gitaly_#{DISK_ACCESS_DENIED_FLAG} feature"
|
|
end
|
|
|
|
@legacy_disk_path
|
|
end
|
|
|
|
private
|
|
|
|
def method_missing(msg, *args, &block)
|
|
@hash.public_send(msg, *args, &block) # rubocop:disable GitlabSecurity/PublicSend
|
|
end
|
|
end
|
|
end
|
|
end
|