660dcd5b7c
The importer would display a 500 error page if you attempted to import using a non-existent DNS entry. This commit rescues known network issues and consolidates them into BitbucketServer::Connection::ConnectionError`. The previous error handling in the paginator doesn't work because it returns a lazy collection. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/56154
86 lines
3.6 KiB
Ruby
86 lines
3.6 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe BitbucketServer::Connection do
|
|
let(:options) { { base_uri: 'https://test:7990', user: 'bitbucket', password: 'mypassword' } }
|
|
let(:payload) { { 'test' => 1 } }
|
|
let(:headers) { { "Content-Type" => "application/json" } }
|
|
let(:url) { 'https://test:7990/rest/api/1.0/test?something=1' }
|
|
|
|
subject { described_class.new(options) }
|
|
|
|
describe '#get' do
|
|
it 'returns JSON body' do
|
|
WebMock.stub_request(:get, url).with(headers: { 'Accept' => 'application/json' }).to_return(body: payload.to_json, status: 200, headers: headers)
|
|
|
|
expect(subject.get(url, { something: 1 })).to eq(payload)
|
|
end
|
|
|
|
it 'throws an exception if the response is not 200' do
|
|
WebMock.stub_request(:get, url).with(headers: { 'Accept' => 'application/json' }).to_return(body: payload.to_json, status: 500, headers: headers)
|
|
|
|
expect { subject.get(url) }.to raise_error(described_class::ConnectionError)
|
|
end
|
|
|
|
it 'throws an exception if the response is not JSON' do
|
|
WebMock.stub_request(:get, url).with(headers: { 'Accept' => 'application/json' }).to_return(body: 'bad data', status: 200, headers: headers)
|
|
|
|
expect { subject.get(url) }.to raise_error(described_class::ConnectionError)
|
|
end
|
|
|
|
it 'throws an exception upon a network error' do
|
|
WebMock.stub_request(:get, url).with(headers: { 'Accept' => 'application/json' }).to_raise(OpenSSL::SSL::SSLError)
|
|
|
|
expect { subject.get(url) }.to raise_error(described_class::ConnectionError)
|
|
end
|
|
end
|
|
|
|
describe '#post' do
|
|
let(:headers) { { 'Accept' => 'application/json', 'Content-Type' => 'application/json' } }
|
|
|
|
it 'returns JSON body' do
|
|
WebMock.stub_request(:post, url).with(headers: headers).to_return(body: payload.to_json, status: 200, headers: headers)
|
|
|
|
expect(subject.post(url, payload)).to eq(payload)
|
|
end
|
|
|
|
it 'throws an exception if the response is not 200' do
|
|
WebMock.stub_request(:post, url).with(headers: headers).to_return(body: payload.to_json, status: 500, headers: headers)
|
|
|
|
expect { subject.post(url, payload) }.to raise_error(described_class::ConnectionError)
|
|
end
|
|
|
|
it 'throws an exception upon a network error' do
|
|
WebMock.stub_request(:post, url).with(headers: { 'Accept' => 'application/json' }).to_raise(OpenSSL::SSL::SSLError)
|
|
|
|
expect { subject.post(url, payload) }.to raise_error(described_class::ConnectionError)
|
|
end
|
|
end
|
|
|
|
describe '#delete' do
|
|
let(:headers) { { 'Accept' => 'application/json', 'Content-Type' => 'application/json' } }
|
|
|
|
context 'branch API' do
|
|
let(:branch_path) { '/projects/foo/repos/bar/branches' }
|
|
let(:branch_url) { 'https://test:7990/rest/branch-utils/1.0/projects/foo/repos/bar/branches' }
|
|
let(:path) { }
|
|
|
|
it 'returns JSON body' do
|
|
WebMock.stub_request(:delete, branch_url).with(headers: headers).to_return(body: payload.to_json, status: 200, headers: headers)
|
|
|
|
expect(subject.delete(:branches, branch_path, payload)).to eq(payload)
|
|
end
|
|
|
|
it 'throws an exception if the response is not 200' do
|
|
WebMock.stub_request(:delete, branch_url).with(headers: headers).to_return(body: payload.to_json, status: 500, headers: headers)
|
|
|
|
expect { subject.delete(:branches, branch_path, payload) }.to raise_error(described_class::ConnectionError)
|
|
end
|
|
|
|
it 'throws an exception upon a network error' do
|
|
WebMock.stub_request(:delete, branch_url).with(headers: headers).to_raise(OpenSSL::SSL::SSLError)
|
|
|
|
expect { subject.delete(:branches, branch_path, payload) }.to raise_error(described_class::ConnectionError)
|
|
end
|
|
end
|
|
end
|
|
end
|