gitlab-org--gitlab-foss/spec/services
Dmitriy Zaporozhets 5fedc46343 Merge branch 'refactor-create-service-spec' into 'master'
Refactor create service spec

## What does this MR do?
Use let instead instance variables to cache create user operation.

Union some example into one.

## Are there points in the code the reviewer needs to double check?

## Why was this MR needed?
Time before: 1 minute 11.81 seconds

Time after: 52.47 seconds

- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- n/a [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- n/a API support added
- Tests
  - n/a Added for this feature/bug
  - [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?

See merge request !7609
2016-12-05 18:49:53 +00:00
..
auth
boards
chat_names
ci
files
groups
issuable
issues Only include EmailHelpers in mailer specs and specs using them 2016-12-01 12:17:33 +08:00
labels
members
merge_requests Merge branch 'fix/rename-mwbs-to-merge-when-pipeline-succeeds' into 'master' 2016-12-05 11:07:57 +00:00
milestones
notes
projects Merge branch 'refactor-create-service-spec' into 'master' 2016-12-05 18:49:53 +00:00
protected_branches
search
slash_commands
after_branch_delete_service_spec.rb
compare_service_spec.rb
create_deployment_service_spec.rb
create_release_service_spec.rb
create_snippet_service_spec.rb
create_tag_service_spec.rb
delete_branch_service_spec.rb
delete_merged_branches_service_spec.rb
delete_tag_service_spec.rb
delete_user_service_spec.rb
destroy_group_service_spec.rb
event_create_service_spec.rb
git_hooks_service_spec.rb
git_push_service_spec.rb Pass commit data to ProcessCommitWorker 2016-12-01 13:36:06 +01:00
git_tag_push_service_spec.rb
import_export_clean_up_service_spec.rb
notification_service_spec.rb Only include EmailHelpers in mailer specs and specs using them 2016-12-01 12:17:33 +08:00
repair_ldap_blocked_user_service_spec.rb
repository_archive_clean_up_service_spec.rb
search_service_spec.rb
system_hooks_service_spec.rb
system_note_service_spec.rb
test_hook_service_spec.rb
todo_service_spec.rb
update_release_service_spec.rb
update_snippet_service_spec.rb