580d250166
There are several changes to this module: 1. The use of an explicit stack in Participable#participants 2. Proc behaviour has been changed 3. Batch permissions checking == Explicit Stack Participable#participants no longer uses recursion to process "self" and all child objects, instead it uses an Array and processes objects in breadth-first order. This allows us to for example create a single Gitlab::ReferenceExtractor instance and pass this to any Procs. Re-using a ReferenceExtractor removes the need for running potentially many SQL queries every time a Proc is called on a new object. == Proc Behaviour Changed Previously a Proc in Participable was expected to return an Array of User instances. This has been changed and instead it's now expected that a Proc modifies the Gitlab::ReferenceExtractor passed to it. The return value of the Proc is ignored. == Permissions Checking The method Participable#participants uses Ability.users_that_can_read_project to check if the returned users have access to the project of "self" _without_ running multiple SQL queries for every user.
117 lines
3.6 KiB
Ruby
117 lines
3.6 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe Snippet, models: true do
|
|
describe 'modules' do
|
|
subject { described_class }
|
|
|
|
it { is_expected.to include_module(Gitlab::VisibilityLevel) }
|
|
it { is_expected.to include_module(Linguist::BlobHelper) }
|
|
it { is_expected.to include_module(Participable) }
|
|
it { is_expected.to include_module(Referable) }
|
|
it { is_expected.to include_module(Sortable) }
|
|
end
|
|
|
|
describe 'associations' do
|
|
it { is_expected.to belong_to(:author).class_name('User') }
|
|
it { is_expected.to belong_to(:project) }
|
|
it { is_expected.to have_many(:notes).dependent(:destroy) }
|
|
end
|
|
|
|
describe 'validation' do
|
|
it { is_expected.to validate_presence_of(:author) }
|
|
|
|
it { is_expected.to validate_presence_of(:title) }
|
|
it { is_expected.to validate_length_of(:title).is_within(0..255) }
|
|
|
|
it { is_expected.to validate_length_of(:file_name).is_within(0..255) }
|
|
|
|
it { is_expected.to validate_presence_of(:content) }
|
|
|
|
it { is_expected.to validate_inclusion_of(:visibility_level).in_array(Gitlab::VisibilityLevel.values) }
|
|
end
|
|
|
|
describe '#to_reference' do
|
|
let(:project) { create(:empty_project) }
|
|
let(:snippet) { create(:snippet, project: project) }
|
|
|
|
it 'returns a String reference to the object' do
|
|
expect(snippet.to_reference).to eq "$#{snippet.id}"
|
|
end
|
|
|
|
it 'supports a cross-project reference' do
|
|
cross = double('project')
|
|
expect(snippet.to_reference(cross)).to eq "#{project.to_reference}$#{snippet.id}"
|
|
end
|
|
end
|
|
|
|
describe '.search' do
|
|
let(:snippet) { create(:snippet) }
|
|
|
|
it 'returns snippets with a matching title' do
|
|
expect(described_class.search(snippet.title)).to eq([snippet])
|
|
end
|
|
|
|
it 'returns snippets with a partially matching title' do
|
|
expect(described_class.search(snippet.title[0..2])).to eq([snippet])
|
|
end
|
|
|
|
it 'returns snippets with a matching title regardless of the casing' do
|
|
expect(described_class.search(snippet.title.upcase)).to eq([snippet])
|
|
end
|
|
|
|
it 'returns snippets with a matching file name' do
|
|
expect(described_class.search(snippet.file_name)).to eq([snippet])
|
|
end
|
|
|
|
it 'returns snippets with a partially matching file name' do
|
|
expect(described_class.search(snippet.file_name[0..2])).to eq([snippet])
|
|
end
|
|
|
|
it 'returns snippets with a matching file name regardless of the casing' do
|
|
expect(described_class.search(snippet.file_name.upcase)).to eq([snippet])
|
|
end
|
|
end
|
|
|
|
describe '#search_code' do
|
|
let(:snippet) { create(:snippet, content: 'class Foo; end') }
|
|
|
|
it 'returns snippets with matching content' do
|
|
expect(described_class.search_code(snippet.content)).to eq([snippet])
|
|
end
|
|
|
|
it 'returns snippets with partially matching content' do
|
|
expect(described_class.search_code('class')).to eq([snippet])
|
|
end
|
|
|
|
it 'returns snippets with matching content regardless of the casing' do
|
|
expect(described_class.search_code('FOO')).to eq([snippet])
|
|
end
|
|
end
|
|
|
|
describe '#participants' do
|
|
let(:project) { create(:project, :public) }
|
|
let(:snippet) { create(:snippet, content: 'foo', project: project) }
|
|
|
|
let!(:note1) do
|
|
create(:note_on_project_snippet,
|
|
noteable: snippet,
|
|
project: project,
|
|
note: 'a')
|
|
end
|
|
|
|
let!(:note2) do
|
|
create(:note_on_project_snippet,
|
|
noteable: snippet,
|
|
project: project,
|
|
note: 'b')
|
|
end
|
|
|
|
it 'includes the snippet author' do
|
|
expect(snippet.participants).to include(snippet.author)
|
|
end
|
|
|
|
it 'includes the note authors' do
|
|
expect(snippet.participants).to include(note1.author, note2.author)
|
|
end
|
|
end
|
|
end
|