f23b1cb453
Replace MR access checks with use of MergeRequestsFinder Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867 ⚠️ - Potentially untested 💣 - No test coverage 🚥 - Test coverage of some sort exists (a test failed when error raised) 🚦 - Test coverage of return value (a test failed when nil used) ✅ - Permissions check tested - [x] 💣 app/finders/notes_finder.rb:17 - [x] ⚠️ app/views/layouts/nav/_project.html.haml:80 [`.count`] - [x] 💣 app/controllers/concerns/creates_commit.rb:84 - [x] 🚥 app/controllers/projects/commits_controller.rb:24 - [x] 🚥 app/controllers/projects/compare_controller.rb:56 - [x] 🚦 app/controllers/projects/discussions_controller.rb:29 - [x] ✅ app/controllers/projects/todos_controller.rb:27 - [x] 🚦 app/models/commit.rb:268 - [x] ✅ lib/gitlab/search_results.rb:71 - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_267_266 Memoize ` merged_merge_request(current_user)` - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_248_247 Expected side effect for `merged_merge_request!`, consider `skip_authorization: true`. - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_269_269 Scary use of unchecked `merged_merge_request?` See merge request !2033
53 lines
1.1 KiB
Ruby
53 lines
1.1 KiB
Ruby
module Milestoneish
|
|
def closed_items_count(user)
|
|
issues_visible_to_user(user).closed.size + merge_requests.closed_and_merged.size
|
|
end
|
|
|
|
def total_items_count(user)
|
|
issues_visible_to_user(user).size + merge_requests.size
|
|
end
|
|
|
|
def complete?(user)
|
|
total_items_count(user) > 0 && total_items_count(user) == closed_items_count(user)
|
|
end
|
|
|
|
def percent_complete(user)
|
|
((closed_items_count(user) * 100) / total_items_count(user)).abs
|
|
rescue ZeroDivisionError
|
|
0
|
|
end
|
|
|
|
def remaining_days
|
|
return 0 if !due_date || expired?
|
|
|
|
(due_date - Date.today).to_i
|
|
end
|
|
|
|
def elapsed_days
|
|
return 0 if !start_date || start_date.future?
|
|
|
|
(Date.today - start_date).to_i
|
|
end
|
|
|
|
def issues_visible_to_user(user)
|
|
issues.visible_to_user(user)
|
|
end
|
|
|
|
def upcoming?
|
|
start_date && start_date.future?
|
|
end
|
|
|
|
def expires_at
|
|
if due_date
|
|
if due_date.past?
|
|
"expired on #{due_date.to_s(:medium)}"
|
|
else
|
|
"expires on #{due_date.to_s(:medium)}"
|
|
end
|
|
end
|
|
end
|
|
|
|
def expired?
|
|
due_date && due_date.past?
|
|
end
|
|
end
|