4be77d0b05
If you attempt to push thousands of branches at once, the 60-second timeout will occur because GitAccess checking does a lot of work to check if the user has permission to push to a branch. This changes does two things: 1. Instead of making 1 DB query per branch push, use a memoized list of protected branches to check 2. Memoize what permissions the user has to perform on this project On a test of 10,000 branch pushes, this prevents gitlab-shell from hitting the 60-second timeout. Closes #17225
215 lines
5.7 KiB
Ruby
215 lines
5.7 KiB
Ruby
module Gitlab
|
|
class GitAccess
|
|
DOWNLOAD_COMMANDS = %w{ git-upload-pack git-upload-archive }
|
|
PUSH_COMMANDS = %w{ git-receive-pack }
|
|
|
|
attr_reader :actor, :project
|
|
|
|
def initialize(actor, project)
|
|
@actor = actor
|
|
@project = project
|
|
end
|
|
|
|
def user
|
|
return @user if defined?(@user)
|
|
|
|
@user =
|
|
case actor
|
|
when User
|
|
actor
|
|
when DeployKey
|
|
nil
|
|
when Key
|
|
actor.user
|
|
end
|
|
end
|
|
|
|
def deploy_key
|
|
actor if actor.is_a?(DeployKey)
|
|
end
|
|
|
|
def can_push_to_branch?(ref)
|
|
return false unless user
|
|
|
|
if project.protected_branch?(ref) && !project.developers_can_push_to_protected_branch?(ref)
|
|
user.can?(:push_code_to_protected_branches, project)
|
|
else
|
|
user.can?(:push_code, project)
|
|
end
|
|
end
|
|
|
|
def can_read_project?
|
|
if user
|
|
user.can?(:read_project, project)
|
|
elsif deploy_key
|
|
deploy_key.projects.include?(project)
|
|
else
|
|
false
|
|
end
|
|
end
|
|
|
|
def check(cmd, changes = nil)
|
|
unless actor
|
|
return build_status_object(false, "No user or key was provided.")
|
|
end
|
|
|
|
if user && !user_allowed?
|
|
return build_status_object(false, "Your account has been blocked.")
|
|
end
|
|
|
|
unless project && can_read_project?
|
|
return build_status_object(false, 'The project you were looking for could not be found.')
|
|
end
|
|
|
|
case cmd
|
|
when *DOWNLOAD_COMMANDS
|
|
download_access_check
|
|
when *PUSH_COMMANDS
|
|
push_access_check(changes)
|
|
else
|
|
build_status_object(false, "The command you're trying to execute is not allowed.")
|
|
end
|
|
end
|
|
|
|
def download_access_check
|
|
if user
|
|
user_download_access_check
|
|
elsif deploy_key
|
|
build_status_object(true)
|
|
else
|
|
raise 'Wrong actor'
|
|
end
|
|
end
|
|
|
|
def push_access_check(changes)
|
|
if user
|
|
user_push_access_check(changes)
|
|
elsif deploy_key
|
|
build_status_object(false, "Deploy keys are not allowed to push code.")
|
|
else
|
|
raise 'Wrong actor'
|
|
end
|
|
end
|
|
|
|
def user_download_access_check
|
|
unless user.can?(:download_code, project)
|
|
return build_status_object(false, "You are not allowed to download code from this project.")
|
|
end
|
|
|
|
build_status_object(true)
|
|
end
|
|
|
|
def user_push_access_check(changes)
|
|
if changes.blank?
|
|
return build_status_object(true)
|
|
end
|
|
|
|
unless project.repository.exists?
|
|
return build_status_object(false, "A repository for this project does not exist yet.")
|
|
end
|
|
|
|
changes = changes.lines if changes.kind_of?(String)
|
|
|
|
# Iterate over all changes to find if user allowed all of them to be applied
|
|
changes.map(&:strip).reject(&:blank?).each do |change|
|
|
status = change_access_check(change)
|
|
unless status.allowed?
|
|
# If user does not have access to make at least one change - cancel all push
|
|
return status
|
|
end
|
|
end
|
|
|
|
build_status_object(true)
|
|
end
|
|
|
|
def can_user_do_action?(action)
|
|
@permission_cache ||= {}
|
|
@permission_cache[action] ||= user.can?(action, project)
|
|
end
|
|
|
|
def change_access_check(change)
|
|
oldrev, newrev, ref = change.split(' ')
|
|
|
|
action =
|
|
if project.protected_branch?(branch_name(ref))
|
|
protected_branch_action(oldrev, newrev, branch_name(ref))
|
|
elsif (tag_ref = tag_name(ref)) && protected_tag?(tag_ref)
|
|
# Prevent any changes to existing git tag unless user has permissions
|
|
:admin_project
|
|
else
|
|
:push_code
|
|
end
|
|
|
|
unless can_user_do_action?(action)
|
|
status =
|
|
case action
|
|
when :force_push_code_to_protected_branches
|
|
build_status_object(false, "You are not allowed to force push code to a protected branch on this project.")
|
|
when :remove_protected_branches
|
|
build_status_object(false, "You are not allowed to deleted protected branches from this project.")
|
|
when :push_code_to_protected_branches
|
|
build_status_object(false, "You are not allowed to push code to protected branches on this project.")
|
|
when :admin_project
|
|
build_status_object(false, "You are not allowed to change existing tags on this project.")
|
|
else # :push_code
|
|
build_status_object(false, "You are not allowed to push code to this project.")
|
|
end
|
|
return status
|
|
end
|
|
|
|
build_status_object(true)
|
|
end
|
|
|
|
def forced_push?(oldrev, newrev)
|
|
Gitlab::ForcePushCheck.force_push?(project, oldrev, newrev)
|
|
end
|
|
|
|
private
|
|
|
|
def protected_branch_action(oldrev, newrev, branch_name)
|
|
# we dont allow force push to protected branch
|
|
if forced_push?(oldrev, newrev)
|
|
:force_push_code_to_protected_branches
|
|
elsif Gitlab::Git.blank_ref?(newrev)
|
|
# and we dont allow remove of protected branch
|
|
:remove_protected_branches
|
|
elsif project.developers_can_push_to_protected_branch?(branch_name)
|
|
:push_code
|
|
else
|
|
:push_code_to_protected_branches
|
|
end
|
|
end
|
|
|
|
def protected_tag?(tag_name)
|
|
project.repository.tag_exists?(tag_name)
|
|
end
|
|
|
|
def user_allowed?
|
|
Gitlab::UserAccess.allowed?(user)
|
|
end
|
|
|
|
def branch_name(ref)
|
|
ref = ref.to_s
|
|
if Gitlab::Git.branch_ref?(ref)
|
|
Gitlab::Git.ref_name(ref)
|
|
else
|
|
nil
|
|
end
|
|
end
|
|
|
|
def tag_name(ref)
|
|
ref = ref.to_s
|
|
if Gitlab::Git.tag_ref?(ref)
|
|
Gitlab::Git.ref_name(ref)
|
|
else
|
|
nil
|
|
end
|
|
end
|
|
|
|
protected
|
|
|
|
def build_status_object(status, message = '')
|
|
GitAccessStatus.new(status, message)
|
|
end
|
|
end
|
|
end
|