6ec53f5d48
Every project page displays a navigation menu that in turn displays the number of open issues and merge requests. This means that for every project page we run two COUNT(*) queries, each taking up roughly 30 milliseconds on GitLab.com. By caching these numbers and refreshing them whenever necessary we can reduce loading times of all these pages by up to roughly 60 milliseconds. The number of open issues does not include confidential issues. This is a trade-off to keep the code simple and to ensure refreshing the data only needs 2 COUNT(*) queries instead of 3. A downside is that if a project only has 5 confidential issues the counter will be set to 0. Because we now have 3 similar counting service classes the code previously used in Projects::ForksCountService has mostly been moved to Projects::CountService, which in turn is reused by the various service classes. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/36622
43 lines
893 B
Ruby
43 lines
893 B
Ruby
module Projects
|
|
# Base class for the various service classes that count project data (e.g.
|
|
# issues or forks).
|
|
class CountService
|
|
def initialize(project)
|
|
@project = project
|
|
end
|
|
|
|
def relation_for_count
|
|
raise(
|
|
NotImplementedError,
|
|
'"relation_for_count" must be implemented and return an ActiveRecord::Relation'
|
|
)
|
|
end
|
|
|
|
def count
|
|
Rails.cache.fetch(cache_key) { uncached_count }
|
|
end
|
|
|
|
def refresh_cache
|
|
Rails.cache.write(cache_key, uncached_count)
|
|
end
|
|
|
|
def uncached_count
|
|
relation_for_count.count
|
|
end
|
|
|
|
def delete_cache
|
|
Rails.cache.delete(cache_key)
|
|
end
|
|
|
|
def cache_key_name
|
|
raise(
|
|
NotImplementedError,
|
|
'"cache_key_name" must be implemented and return a String'
|
|
)
|
|
end
|
|
|
|
def cache_key
|
|
['projects', @project.id, cache_key_name]
|
|
end
|
|
end
|
|
end
|