b0bf92140f
Ensure external users are not able to clone disabled repositories. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/23788 See merge request !2017 Signed-off-by: Rémy Coutable <remy@rymai.me>
182 lines
4.9 KiB
Ruby
182 lines
4.9 KiB
Ruby
# Check a user's access to perform a git action. All public methods in this
|
|
# class return an instance of `GitlabAccessStatus`
|
|
module Gitlab
|
|
class GitAccess
|
|
UnauthorizedError = Class.new(StandardError)
|
|
|
|
ERROR_MESSAGES = {
|
|
upload: 'You are not allowed to upload code for this project.',
|
|
download: 'You are not allowed to download code from this project.',
|
|
deploy_key: 'Deploy keys are not allowed to push code.',
|
|
no_repo: 'A repository for this project does not exist yet.'
|
|
}
|
|
|
|
DOWNLOAD_COMMANDS = %w{ git-upload-pack git-upload-archive }
|
|
PUSH_COMMANDS = %w{ git-receive-pack }
|
|
ALL_COMMANDS = DOWNLOAD_COMMANDS + PUSH_COMMANDS
|
|
|
|
attr_reader :actor, :project, :protocol, :user_access, :authentication_abilities
|
|
|
|
def initialize(actor, project, protocol, authentication_abilities:)
|
|
@actor = actor
|
|
@project = project
|
|
@protocol = protocol
|
|
@authentication_abilities = authentication_abilities
|
|
@user_access = UserAccess.new(user, project: project)
|
|
end
|
|
|
|
def check(cmd, changes)
|
|
check_protocol!
|
|
check_active_user!
|
|
check_project_accessibility!
|
|
check_command_existence!(cmd)
|
|
|
|
case cmd
|
|
when *DOWNLOAD_COMMANDS
|
|
download_access_check
|
|
when *PUSH_COMMANDS
|
|
push_access_check(changes)
|
|
end
|
|
|
|
build_status_object(true)
|
|
rescue UnauthorizedError => ex
|
|
build_status_object(false, ex.message)
|
|
end
|
|
|
|
def download_access_check
|
|
if user
|
|
user_download_access_check
|
|
elsif deploy_key.nil? && !Guest.can?(:download_code, project)
|
|
raise UnauthorizedError, ERROR_MESSAGES[:download]
|
|
end
|
|
end
|
|
|
|
def push_access_check(changes)
|
|
if user
|
|
user_push_access_check(changes)
|
|
else
|
|
raise UnauthorizedError, ERROR_MESSAGES[deploy_key ? :deploy_key : :upload]
|
|
end
|
|
end
|
|
|
|
def user_download_access_check
|
|
unless user_can_download_code? || build_can_download_code?
|
|
raise UnauthorizedError, ERROR_MESSAGES[:download]
|
|
end
|
|
end
|
|
|
|
def user_can_download_code?
|
|
authentication_abilities.include?(:download_code) && user_access.can_do_action?(:download_code)
|
|
end
|
|
|
|
def build_can_download_code?
|
|
authentication_abilities.include?(:build_download_code) && user_access.can_do_action?(:build_download_code)
|
|
end
|
|
|
|
def user_push_access_check(changes)
|
|
unless authentication_abilities.include?(:push_code)
|
|
raise UnauthorizedError, ERROR_MESSAGES[:upload]
|
|
end
|
|
|
|
if changes.blank?
|
|
return # Allow access.
|
|
end
|
|
|
|
unless project.repository.exists?
|
|
raise UnauthorizedError, ERROR_MESSAGES[:no_repo]
|
|
end
|
|
|
|
changes_list = Gitlab::ChangesList.new(changes)
|
|
|
|
# Iterate over all changes to find if user allowed all of them to be applied
|
|
changes_list.each do |change|
|
|
status = change_access_check(change)
|
|
unless status.allowed?
|
|
# If user does not have access to make at least one change - cancel all push
|
|
raise UnauthorizedError, status.message
|
|
end
|
|
end
|
|
end
|
|
|
|
def change_access_check(change)
|
|
Checks::ChangeAccess.new(change, user_access: user_access, project: project).exec
|
|
end
|
|
|
|
def protocol_allowed?
|
|
Gitlab::ProtocolAccess.allowed?(protocol)
|
|
end
|
|
|
|
private
|
|
|
|
def check_protocol!
|
|
unless protocol_allowed?
|
|
raise UnauthorizedError, "Git access over #{protocol.upcase} is not allowed"
|
|
end
|
|
end
|
|
|
|
def check_active_user!
|
|
if user && !user_access.allowed?
|
|
raise UnauthorizedError, "Your account has been blocked."
|
|
end
|
|
end
|
|
|
|
def check_project_accessibility!
|
|
if project.blank? || !can_read_project?
|
|
raise UnauthorizedError, 'The project you were looking for could not be found.'
|
|
end
|
|
end
|
|
|
|
def check_command_existence!(cmd)
|
|
unless ALL_COMMANDS.include?(cmd)
|
|
raise UnauthorizedError, "The command you're trying to execute is not allowed."
|
|
end
|
|
end
|
|
|
|
def matching_merge_request?(newrev, branch_name)
|
|
Checks::MatchingMergeRequest.new(newrev, branch_name, project).match?
|
|
end
|
|
|
|
def deploy_key
|
|
actor if actor.is_a?(DeployKey)
|
|
end
|
|
|
|
def deploy_key_can_read_project?
|
|
if deploy_key
|
|
return true if project.public?
|
|
deploy_key.projects.include?(project)
|
|
else
|
|
false
|
|
end
|
|
end
|
|
|
|
def can_read_project?
|
|
if user
|
|
user_access.can_read_project?
|
|
elsif deploy_key
|
|
deploy_key_can_read_project?
|
|
else
|
|
Guest.can?(:read_project, project)
|
|
end
|
|
end
|
|
|
|
protected
|
|
|
|
def user
|
|
return @user if defined?(@user)
|
|
|
|
@user =
|
|
case actor
|
|
when User
|
|
actor
|
|
when DeployKey
|
|
nil
|
|
when Key
|
|
actor.user
|
|
end
|
|
end
|
|
|
|
def build_status_object(status, message = '')
|
|
Gitlab::GitAccessStatus.new(status, message)
|
|
end
|
|
end
|
|
end
|