776cea4c00
Keep-around refs for deployments were only introduced in 8.10, so any deployment created in 8.9 could have a SHA pointing to a commit that no longer exists in the repository. We can't do anything useful with those deployments, so make `#includes_commit?` always return false for those.
51 lines
1.6 KiB
Ruby
51 lines
1.6 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe Deployment, models: true do
|
|
subject { build(:deployment) }
|
|
|
|
it { is_expected.to belong_to(:project) }
|
|
it { is_expected.to belong_to(:environment) }
|
|
it { is_expected.to belong_to(:user) }
|
|
it { is_expected.to belong_to(:deployable) }
|
|
|
|
it { is_expected.to delegate_method(:name).to(:environment).with_prefix }
|
|
it { is_expected.to delegate_method(:commit).to(:project) }
|
|
it { is_expected.to delegate_method(:commit_title).to(:commit).as(:try) }
|
|
it { is_expected.to delegate_method(:manual_actions).to(:deployable).as(:try) }
|
|
|
|
it { is_expected.to validate_presence_of(:ref) }
|
|
it { is_expected.to validate_presence_of(:sha) }
|
|
|
|
describe '#includes_commit?' do
|
|
let(:project) { create(:project) }
|
|
let(:environment) { create(:environment, project: project) }
|
|
let(:deployment) do
|
|
create(:deployment, environment: environment, sha: project.commit.id)
|
|
end
|
|
|
|
context 'when there is no project commit' do
|
|
it 'returns false' do
|
|
commit = project.commit('feature')
|
|
|
|
expect(deployment.includes_commit?(commit)).to be false
|
|
end
|
|
end
|
|
|
|
context 'when they share the same tree branch' do
|
|
it 'returns true' do
|
|
commit = project.commit
|
|
|
|
expect(deployment.includes_commit?(commit)).to be true
|
|
end
|
|
end
|
|
|
|
context 'when the SHA for the deployment does not exist in the repo' do
|
|
it 'returns false' do
|
|
deployment.update(sha: Gitlab::Git::BLANK_SHA)
|
|
commit = project.commit
|
|
|
|
expect(deployment.includes_commit?(commit)).to be false
|
|
end
|
|
end
|
|
end
|
|
end
|