1a76535780
Resolve "Activity entries are not loaded fully to cover full window's height" ## What does this MR do? Fixes a bug in which a browser window large enough to encompass the default number of items in an auto-loading endless-scroll list could not trigger the loading of additional items. ## Are there points in the code the reviewer needs to double check? I refactored activities.js and pager.js into es6 syntax while I was investigating the issue. No changes were made other than some es6 flourishes and eslint conformity, so nothing should be effected, but perhaps best to double check other pages which utilize these scripts. ## Screenshots (if relevant) ![endless-scroll-fixed](/uploads/b672b606826af745528c209ab6cfe95c/endless-scroll-fixed.gif) ## Does this MR meet the acceptance criteria? - [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added - Tests - [x] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Closes #24499 See merge request !7608 |
||
---|---|---|
.. | ||
behaviors | ||
boards | ||
environments | ||
extensions | ||
fixtures | ||
graphs | ||
u2f | ||
vue_common_components | ||
.eslintrc | ||
abuse_reports_spec.js.es6 | ||
activities_spec.js.es6 | ||
application_spec.js | ||
awards_handler_spec.js | ||
build_spec.js.es6 | ||
dashboard_spec.js.es6 | ||
datetime_utility_spec.js.es6 | ||
diff_comments_store_spec.js.es6 | ||
gl_dropdown_spec.js.es6 | ||
gl_field_errors_spec.js.es6 | ||
header_spec.js | ||
issue_spec.js | ||
labels_issue_sidebar_spec.js.es6 | ||
line_highlighter_spec.js | ||
merge_request_spec.js | ||
merge_request_tabs_spec.js | ||
merge_request_widget_spec.js | ||
new_branch_spec.js | ||
notes_spec.js | ||
project_title_spec.js | ||
right_sidebar_spec.js | ||
search_autocomplete_spec.js | ||
shortcuts_issuable_spec.js | ||
spec_helper.js | ||
syntax_highlight_spec.js | ||
zen_mode_spec.js |