gitlab-org--gitlab-foss/app
Rémy Coutable f9887a10d4 Merge branch '22452-milestone-title-unnecessary-escaping-fix' into 'master'
This MR fixes a bug that unnecessary escapes reserved HTML characters for Milestone's title.  See #22452. 

## Are there points in the code the reviewer needs to double check?

- Unescaping of sanitized milestone title before it is being stored in the database. See `Milestone#title` and a private method called `Milestone#sanitize_title`
- Sufficient tests were added (Model and API tests were modified/added).

## Why was this MR needed?

To allow reserved HTML characters in a milestone's title, such as "PHP migration 5.6 -> 7.0". The text appears in 'milestones' and in a dropdown during issue creation, issue list, and in another dropdown for issue filter. 

Closes #22452

See merge request !6533
2016-09-30 09:27:28 +00:00
..
assets Fixes long commit messages overflow viewport in file tree 2016-09-29 17:40:06 +03:00
controllers Merge branch 'mr_api_todo_close' into 'master' 2016-09-30 08:50:40 +00:00
finders Use Ability.allowed? instead of current_user.can? in AccessRequestsFinder 2016-09-28 08:46:59 +02:00
helpers Review changes 2016-09-28 19:11:11 +03:00
mailers
models Allowing ">" to be used for Milestone models's title and storing the value in db as unescaped. 2016-09-29 19:28:38 -07:00
policies
services Close todos when accepting a MR via the API. 2016-09-29 14:51:12 -04:00
uploaders
validators Add '.well-known' to the list of reserved namespaces 2016-09-29 10:36:38 +02:00
views right-align dropdown menus to prevent horizontal page overflow 2016-09-29 13:28:09 -05:00
workers