gitlab-org--gitlab-foss/spec
Rémy Coutable f9887a10d4 Merge branch '22452-milestone-title-unnecessary-escaping-fix' into 'master'
This MR fixes a bug that unnecessary escapes reserved HTML characters for Milestone's title.  See #22452. 

## Are there points in the code the reviewer needs to double check?

- Unescaping of sanitized milestone title before it is being stored in the database. See `Milestone#title` and a private method called `Milestone#sanitize_title`
- Sufficient tests were added (Model and API tests were modified/added).

## Why was this MR needed?

To allow reserved HTML characters in a milestone's title, such as "PHP migration 5.6 -> 7.0". The text appears in 'milestones' and in a dropdown during issue creation, issue list, and in another dropdown for issue filter. 

Closes #22452

See merge request !6533
2016-09-30 09:27:28 +00:00
..
config Small refactor and a few documentation fixes 2016-08-04 19:02:39 +02:00
controllers fix broken repo 500 errors in UI and added relevant specs 2016-09-29 16:58:14 +02:00
factories fix broken repo 500 errors in UI and added relevant specs 2016-09-29 16:58:14 +02:00
features Merge branch 'axil/gitlab-ce-typos_runners_pages' into 'master' 2016-09-29 15:03:20 +00:00
finders New AccessRequestsFinder 2016-09-28 08:46:59 +02:00
fixtures Returns the total number of issues in the JSON response 2016-08-31 09:30:37 +01:00
helpers Merge branch 'gitlab-ce-milestone-tab-badges' into 'master' 2016-09-24 10:49:45 +00:00
initializers Give priority to environment variables 2016-08-03 15:48:48 +01:00
javascripts Send ajax request for label update only if they are changed (#19472 !5071) 2016-09-27 10:23:15 -05:00
lib Merge branch 'lfs-ssh-authorization-fix' into 'master' 2016-09-28 18:13:34 +00:00
mailers Wrap List-Unsubscribe link in angle brackets 2016-09-26 16:01:17 +01:00
models Allowing ">" to be used for Milestone models's title and storing the value in db as unescaped. 2016-09-29 19:28:38 -07:00
policies Test if issue authors can access private projects 2016-09-20 14:57:23 -03:00
requests Allowing ">" to be used for Milestone models's title and storing the value in db as unescaped. 2016-09-29 19:28:38 -07:00
routing Fix markdown help references 2016-08-26 09:38:21 -05:00
services Close todos when accepting a MR via the API. 2016-09-29 14:51:12 -04:00
support Fix permission for setting an issue's due date 2016-09-28 17:41:32 +02:00
tasks/gitlab Use File::exist? instead of File::exists? 2016-08-11 13:54:45 +03:00
uploaders
views Upgrade Devise from 4.1.1 to 4.2.0. 2016-09-27 20:08:49 -06:00
workers Added cron to prune events older than 12 months. 2016-09-07 19:41:25 +02:00
factories_spec.rb adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00
rails_helper.rb
simplecov_env.rb Bump SimpleCov merge timeout to 365 days 2016-08-22 13:44:14 +02:00
spec_helper.rb Upgrade Devise from 4.1.1 to 4.2.0. 2016-09-27 20:08:49 -06:00
teaspoon_env.rb Add test coverage analysis for CoffeeScript (!5052) 2016-08-07 21:52:37 +02:00