f9c456bd0c
Previously, we called the `peek_enabled?` method like so: prepend_before_action :set_peek_request_id, if: :peek_enabled? Now we don't have a `set_peek_request_id` method, so we don't need that line. However, the `peek_enabled?` part had a side-effect: it would also populate the request store cache for whether the performance bar was enabled for the current request or not. This commit makes that side-effect explicit, and replaces all uses of `peek_enabled?` with the more explicit `Gitlab::PerformanceBar.enabled_for_request?`. There is one spec that still sets `SafeRequestStore[:peek_enabled]` directly, because it is contrasting behaviour with and without a request store enabled. The upshot is: 1. We still set the value in one place. We make it more explicit that that's what we're doing. 2. Reading that value uses a consistent method so it's easier to find in future. |
||
---|---|---|
.. | ||
abuse_report_mailer | ||
abuse_reports | ||
admin | ||
award_emoji | ||
ci | ||
clusters | ||
dashboard | ||
devise | ||
discussions | ||
doorkeeper | ||
email_rejection_mailer | ||
errors | ||
events | ||
explore | ||
groups | ||
help | ||
ide | ||
import | ||
instance_statistics | ||
invites | ||
issues | ||
kaminari/gitlab | ||
layouts | ||
notify | ||
peek | ||
profiles | ||
projects | ||
repository_check_mailer | ||
search | ||
sent_notifications | ||
shared | ||
sherlock | ||
snippets | ||
u2f | ||
users |