f9c456bd0c
Previously, we called the `peek_enabled?` method like so: prepend_before_action :set_peek_request_id, if: :peek_enabled? Now we don't have a `set_peek_request_id` method, so we don't need that line. However, the `peek_enabled?` part had a side-effect: it would also populate the request store cache for whether the performance bar was enabled for the current request or not. This commit makes that side-effect explicit, and replaces all uses of `peek_enabled?` with the more explicit `Gitlab::PerformanceBar.enabled_for_request?`. There is one spec that still sets `SafeRequestStore[:peek_enabled]` directly, because it is contrasting behaviour with and without a request store enabled. The upshot is: 1. We still set the value in one place. We make it more explicit that that's what we're doing. 2. Reading that value uses a consistent method so it's easier to find in future. |
||
---|---|---|
.. | ||
api | ||
backup | ||
banzai | ||
bitbucket | ||
bitbucket_server | ||
constraints | ||
container_registry | ||
feature | ||
gitaly | ||
gitlab | ||
google_api | ||
json_web_token | ||
mattermost | ||
microsoft_teams | ||
object_storage | ||
omni_auth/strategies | ||
peek/views | ||
prometheus | ||
quality | ||
rspec_flaky | ||
safe_zip | ||
sentry | ||
serializers | ||
system_check | ||
after_commit_queue_spec.rb | ||
event_filter_spec.rb | ||
expand_variables_spec.rb | ||
extracts_path_spec.rb | ||
feature_spec.rb | ||
file_size_validator_spec.rb | ||
forever_spec.rb | ||
gitlab_spec.rb | ||
milestone_array_spec.rb | ||
system_check_spec.rb | ||
uploaded_file_spec.rb |