Douwe Maan f23b1cb453 Merge branch 'jej-23867-use-mr-finder-instead-of-access-check' into 'security' ... Replace MR access checks with use of MergeRequestsFinder Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867 ⚠️ - Potentially untested 💣 - No test coverage 🚥 - Test coverage of some sort exists (a test failed when error raised) 🚦 - Test coverage of return value (a test failed when nil used) ✅ - Permissions check tested - [x] 💣 app/finders/notes_finder.rb:17 - [x] ⚠️ app/views/layouts/nav/_project.html.haml:80 [`.count`] - [x] 💣 app/controllers/concerns/creates_commit.rb:84 - [x] 🚥 app/controllers/projects/commits_controller.rb:24 - [x] 🚥 app/controllers/projects/compare_controller.rb:56 - [x] 🚦 app/controllers/projects/discussions_controller.rb:29 - [x] ✅ app/controllers/projects/todos_controller.rb:27 - [x] 🚦 app/models/commit.rb:268 - [x] ✅ lib/gitlab/search_results.rb:71 - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_267_266 Memoize ` merged_merge_request(current_user)` - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_248_247 Expected side effect for `merged_merge_request!`, consider `skip_authorization: true`. - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_269_269 Scary use of unchecked `merged_merge_request?` See merge request !2033		2016-12-08 21:42:07 -03:00
..
auth
backend
badge
bitbucket_import
chat_commands
checks
ci
conflict
cycle_analytics
data_builder
database
diff
downtime_check
email
fogbugz_import
gfm
git
github_import
gitlab_import
google_code_import
graphs
import_export
ldap
markdown
metrics
middleware
o_auth
request_profiler
saml
sanitizers
sherlock
sidekiq_middleware
slash_commands
sql
template
access.rb
app_logger.rb
asciidoc.rb
auth.rb
award_emoji.rb
bitbucket_import.rb
blame.rb
changes_list.rb
chat_name_token.rb
closing_issue_extractor.rb
color_schemes.rb
config_helper.rb
contributions_calendar.rb
contributor.rb
current_settings.rb
database.rb
devise_failure.rb
downtime_check.rb
ee_compat_check.rb
emoji.rb
environment_logger.rb
exclusive_lease.rb
file_detector.rb
git.rb
git_access.rb
git_access_status.rb
git_access_wiki.rb
git_logger.rb
git_post_receive.rb
git_ref_validator.rb
gl_id.rb
gon_helper.rb
highlight.rb
identifier.rb
import_export.rb
import_formatter.rb
import_sources.rb
incoming_email.rb
issues_labels.rb
key_fingerprint.rb
lazy.rb
lfs_token.rb
logger.rb
mail_room.rb
markup_helper.rb
metrics.rb
optimistic_locking.rb
other_markup.rb
popen.rb
project_search_results.rb
protocol_access.rb
recaptcha.rb
redis.rb
reference_extractor.rb
regex.rb
repository_check_logger.rb
request_profiler.rb
routing.rb
search_results.rb
seeder.rb
sentry.rb
sherlock.rb
sidekiq_logger.rb
sidekiq_throttler.rb
snippet_search_results.rb
themes.rb
timeless.rb
upgrader.rb
uploads_transfer.rb
url_builder.rb
url_sanitizer.rb
user_access.rb
utils.rb
version_info.rb
visibility_level.rb
workhorse.rb