def2f12995
Use last_edited_at instead of updated_at for displaying issuable last change Closes #41247 See merge request gitlab-org/gitlab-ce!16406
224 lines
7.1 KiB
Ruby
224 lines
7.1 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe IssuablesHelper do
|
|
let(:label) { build_stubbed(:label) }
|
|
let(:label2) { build_stubbed(:label) }
|
|
|
|
describe '#users_dropdown_label' do
|
|
let(:user) { build_stubbed(:user) }
|
|
let(:user2) { build_stubbed(:user) }
|
|
|
|
it 'returns unassigned' do
|
|
expect(users_dropdown_label([])).to eq('Unassigned')
|
|
end
|
|
|
|
it 'returns selected user\'s name' do
|
|
expect(users_dropdown_label([user])).to eq(user.name)
|
|
end
|
|
|
|
it 'returns selected user\'s name and counter' do
|
|
expect(users_dropdown_label([user, user2])).to eq("#{user.name} + 1 more")
|
|
end
|
|
end
|
|
|
|
describe '#issuable_labels_tooltip' do
|
|
it 'returns label text' do
|
|
expect(issuable_labels_tooltip([label])).to eq(label.title)
|
|
end
|
|
|
|
it 'returns label text' do
|
|
expect(issuable_labels_tooltip([label, label2], limit: 1)).to eq("#{label.title}, and 1 more")
|
|
end
|
|
end
|
|
|
|
describe '#issuables_state_counter_text' do
|
|
let(:user) { create(:user) }
|
|
|
|
describe 'state text' do
|
|
before do
|
|
allow(helper).to receive(:issuables_count_for_state).and_return(42)
|
|
end
|
|
|
|
it 'returns "Open" when state is :opened' do
|
|
expect(helper.issuables_state_counter_text(:issues, :opened))
|
|
.to eq('<span>Open</span> <span class="badge">42</span>')
|
|
end
|
|
|
|
it 'returns "Closed" when state is :closed' do
|
|
expect(helper.issuables_state_counter_text(:issues, :closed))
|
|
.to eq('<span>Closed</span> <span class="badge">42</span>')
|
|
end
|
|
|
|
it 'returns "Merged" when state is :merged' do
|
|
expect(helper.issuables_state_counter_text(:merge_requests, :merged))
|
|
.to eq('<span>Merged</span> <span class="badge">42</span>')
|
|
end
|
|
|
|
it 'returns "All" when state is :all' do
|
|
expect(helper.issuables_state_counter_text(:merge_requests, :all))
|
|
.to eq('<span>All</span> <span class="badge">42</span>')
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#issuable_reference' do
|
|
context 'when show_full_reference truthy' do
|
|
it 'display issuable full reference' do
|
|
assign(:show_full_reference, true)
|
|
issue = build_stubbed(:issue)
|
|
|
|
expect(helper.issuable_reference(issue)).to eql(issue.to_reference(full: true))
|
|
end
|
|
end
|
|
|
|
context 'when show_full_reference falsey' do
|
|
context 'when @group present' do
|
|
it 'display issuable reference to @group' do
|
|
project = build_stubbed(:project)
|
|
|
|
assign(:show_full_reference, nil)
|
|
assign(:group, project.namespace)
|
|
|
|
issue = build_stubbed(:issue)
|
|
|
|
expect(helper.issuable_reference(issue)).to eql(issue.to_reference(project.namespace))
|
|
end
|
|
end
|
|
|
|
context 'when @project present' do
|
|
it 'display issuable reference to @project' do
|
|
project = build_stubbed(:project)
|
|
|
|
assign(:show_full_reference, nil)
|
|
assign(:group, nil)
|
|
assign(:project, project)
|
|
|
|
issue = build_stubbed(:issue)
|
|
|
|
expect(helper.issuable_reference(issue)).to eql(issue.to_reference(project))
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#issuable_filter_present?' do
|
|
it 'returns true when any key is present' do
|
|
allow(helper).to receive(:params).and_return(
|
|
ActionController::Parameters.new(milestone_title: 'Velit consectetur asperiores natus delectus.',
|
|
project_id: 'gitlabhq',
|
|
scope: 'all')
|
|
)
|
|
|
|
expect(helper.issuable_filter_present?).to be_truthy
|
|
end
|
|
|
|
it 'returns false when no key is present' do
|
|
allow(helper).to receive(:params).and_return(
|
|
ActionController::Parameters.new(project_id: 'gitlabhq',
|
|
scope: 'all')
|
|
)
|
|
|
|
expect(helper.issuable_filter_present?).to be_falsey
|
|
end
|
|
end
|
|
|
|
describe '#updated_at_by' do
|
|
let(:user) { create(:user) }
|
|
let(:unedited_issuable) { create(:issue) }
|
|
let(:edited_issuable) { create(:issue, last_edited_by: user, created_at: 3.days.ago, updated_at: 1.day.ago, last_edited_at: 2.days.ago) }
|
|
let(:edited_updated_at_by) do
|
|
{
|
|
updatedAt: edited_issuable.last_edited_at.to_time.iso8601,
|
|
updatedBy: {
|
|
name: user.name,
|
|
path: user_path(user)
|
|
}
|
|
}
|
|
end
|
|
|
|
it { expect(helper.updated_at_by(unedited_issuable)).to eq({}) }
|
|
it { expect(helper.updated_at_by(edited_issuable)).to eq(edited_updated_at_by) }
|
|
|
|
context 'when updated by a deleted user' do
|
|
let(:edited_updated_at_by) do
|
|
{
|
|
updatedAt: edited_issuable.last_edited_at.to_time.iso8601,
|
|
updatedBy: {
|
|
name: User.ghost.name,
|
|
path: user_path(User.ghost)
|
|
}
|
|
}
|
|
end
|
|
|
|
before do
|
|
user.destroy
|
|
end
|
|
|
|
it 'returns "Ghost user" as edited_by' do
|
|
expect(helper.updated_at_by(edited_issuable.reload)).to eq(edited_updated_at_by)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#issuable_initial_data' do
|
|
let(:user) { create(:user) }
|
|
|
|
before do
|
|
allow(helper).to receive(:current_user).and_return(user)
|
|
allow(helper).to receive(:can?).and_return(true)
|
|
end
|
|
|
|
it 'returns the correct json for an issue' do
|
|
issue = create(:issue, author: user, description: 'issue text')
|
|
@project = issue.project
|
|
|
|
expected_data = {
|
|
'endpoint' => "/#{@project.full_path}/issues/#{issue.iid}",
|
|
'updateEndpoint' => "/#{@project.full_path}/issues/#{issue.iid}.json",
|
|
'canUpdate' => true,
|
|
'canDestroy' => true,
|
|
'issuableRef' => "##{issue.iid}",
|
|
'markdownPreviewPath' => "/#{@project.full_path}/preview_markdown",
|
|
'markdownDocsPath' => '/help/user/markdown',
|
|
'issuableTemplates' => [],
|
|
'projectPath' => @project.path,
|
|
'projectNamespace' => @project.namespace.path,
|
|
'initialTitleHtml' => issue.title,
|
|
'initialTitleText' => issue.title,
|
|
'initialDescriptionHtml' => '<p dir="auto">issue text</p>',
|
|
'initialDescriptionText' => 'issue text',
|
|
'initialTaskStatus' => '0 of 0 tasks completed'
|
|
}
|
|
expect(JSON.parse(helper.issuable_initial_data(issue))).to eq(expected_data)
|
|
end
|
|
end
|
|
|
|
describe '#selected_labels' do
|
|
context 'if label_name param is a string' do
|
|
it 'returns a new label with title' do
|
|
allow(helper).to receive(:params)
|
|
.and_return(ActionController::Parameters.new(label_name: 'test label'))
|
|
|
|
labels = helper.selected_labels
|
|
|
|
expect(labels).to be_an(Array)
|
|
expect(labels.size).to eq(1)
|
|
expect(labels.first.title).to eq('test label')
|
|
end
|
|
end
|
|
|
|
context 'if label_name param is an array' do
|
|
it 'returns a new label with title for each element' do
|
|
allow(helper).to receive(:params)
|
|
.and_return(ActionController::Parameters.new(label_name: ['test label 1', 'test label 2']))
|
|
|
|
labels = helper.selected_labels
|
|
|
|
expect(labels).to be_an(Array)
|
|
expect(labels.size).to eq(2)
|
|
expect(labels.first.title).to eq('test label 1')
|
|
expect(labels.second.title).to eq('test label 2')
|
|
end
|
|
end
|
|
end
|
|
end
|