0fdfd2dd6e
Here was the problem: 1. When determining whether a given blob is viewable text, gitlab_git reads the first 1024 bytes and checks with Linguist whether it is a text or binary file. 2. If the blob is text, GitLab will attempt to display it. 3. However, if the text has binary characters after the first 1024 bytes, then GitLab will attempt to load the entire contents, but the encoding will be ASCII-8BIT since there are binary characters. 4. The Error 500 results when GitLab attempts to display a mix UTF-8 and ASCII-8BIT. To fix this, we load as much data as we are willing to display so that the detection will work properly. Requires an update to gitlab_git: gitlab-org/gitlab_git!86 Closes #13826
45 lines
1 KiB
Ruby
45 lines
1 KiB
Ruby
# Blob is a Rails-specific wrapper around Gitlab::Git::Blob objects
|
|
class Blob < SimpleDelegator
|
|
CACHE_TIME = 60 # Cache raw blobs referred to by a (mutable) ref for 1 minute
|
|
CACHE_TIME_IMMUTABLE = 3600 # Cache blobs referred to by an immutable reference for 1 hour
|
|
|
|
# Wrap a Gitlab::Git::Blob object, or return nil when given nil
|
|
#
|
|
# This method prevents the decorated object from evaluating to "truthy" when
|
|
# given a nil value. For example:
|
|
#
|
|
# blob = Blob.new(nil)
|
|
# puts "truthy" if blob # => "truthy"
|
|
#
|
|
# blob = Blob.decorate(nil)
|
|
# puts "truthy" if blob # No output
|
|
def self.decorate(blob)
|
|
return if blob.nil?
|
|
|
|
new(blob)
|
|
end
|
|
|
|
def no_highlighting?
|
|
size && size > 1.megabyte
|
|
end
|
|
|
|
def only_display_raw?
|
|
size && truncated?
|
|
end
|
|
|
|
def svg?
|
|
text? && language && language.name == 'SVG'
|
|
end
|
|
|
|
def to_partial_path
|
|
if lfs_pointer?
|
|
'download'
|
|
elsif image? || svg?
|
|
'image'
|
|
elsif text?
|
|
'text'
|
|
else
|
|
'download'
|
|
end
|
|
end
|
|
end
|