gitlab-org--gitlab-foss/app
Douwe Maan fdd7e3f6e9 Merge branch 'stanhu/gitlab-ce-fix-error-500-with-mr-images' into 'master'
Fix Error 500 when creating a merge request that contains an image that was deleted and added

_Originally opened at !4816 by @stanhu._

- - -

## What does this MR do?

This MR fixes an Error 500 when creating a merge request that contains an image that was deleted and added. Before, when displaying the before and after image, the code would always retrieve the image from the parent commit. However, in a diff, this could cause two different problems:
The "before" image may not actually be the image you want to compare against (regression of #14327)
It may appear as though a file was modified when it was really just added during the diff

## Are there points in the code the reviewer needs to double check?

There may be a more elegant to fix this bug.

## What are the relevant issue numbers?

Closes #3893, gitlab-org/gitlab-ee#678

See merge request !7457
2016-11-15 10:22:36 +00:00
..
assets Merge branch '21778-pinned-nav-header' into 'master' 2016-11-14 19:13:05 +00:00
controllers Merge branch '24392-lfs-helper-refactor' into 'master' 2016-11-15 10:19:51 +00:00
finders Merge branch '22481-honour-issue-visibility-for-groups' into 'security' 2016-11-09 12:24:13 +01:00
helpers Merge branch '24392-lfs-helper-refactor' into 'master' 2016-11-15 10:19:51 +00:00
mailers Merge remote-tracking branch 'upstream/master' into pipeline-notifications 2016-11-08 23:52:17 +08:00
models Merge branch 'fix-migration-changes' into 'master' 2016-11-15 03:46:02 +00:00
policies Merge branch 'pipeline-notifications' into 'master' 2016-11-09 13:41:04 +00:00
serializers Simplify implementation of entity serializers 2016-11-04 15:00:39 +01:00
services Does not raise error when Note not found when processing NewNoteWorker 2016-11-11 22:54:11 -02:00
uploaders
validators
views Merge branch 'stanhu/gitlab-ce-fix-error-500-with-mr-images' into 'master' 2016-11-15 10:22:36 +00:00
workers Does not raise error when Note not found when processing NewNoteWorker 2016-11-11 22:54:11 -02:00