Douwe Maan 6617e9bbf3 Merge branch 'fix-post-receive-external-tracker' into 'master' ... Fix post-receive errors on a push when an external issue tracker is configured ### What does this MR do? This MR improves upon !766, fixing errors upon a git push that occur only when an external issue tracker (not JIRA) is used. This MR takes into account that external issue trackers, such as JIRA, may close issues. Disabling the processing of post-receive commits when an external issue tracker is configured seems like the wrong behavior. ### Why was this MR needed? When a user adds an issue reference, the refactoring in 8f8a8ab and a6defd157 caused `project.get_issue` to be called, causing `ExternalIssue` to be returned when an external issue tracker was configured. This object does not have a `close` method, as needed in `CloseService`. Nor does it make sense to associate a `SystemNote` with this object. GitLab EE uses a [special case for JIRA](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/app/services/git_push_service.rb#L87). I would recommend moving this logic into `CloseService` too. ### What are the relevant issue numbers? * Closes #1700 * Closes #1720 See merge request !804		2015-06-15 07:42:24 +00:00
..
files	Refactor web editor	2015-06-05 15:01:38 +02:00
issues	Fix post-receive errors on a push when an external issue tracker is configured	2015-06-12 06:59:27 -07:00
merge_requests	Disable changing of the source branch in merge request update API	2015-05-29 09:40:35 -07:00
milestones
notes	Add support for Webhook note events	2015-05-21 23:48:16 -04:00
oauth2	Rubocop: no trailing newlines	2015-02-02 21:53:27 -08:00
projects	Show warning when a comment will add 10 or more people to the discussion.	2015-06-05 12:07:13 +02:00
search	An in_namespace scope is already present	2015-06-09 13:42:01 +02:00
archive_repository_service.rb	Add tests.	2015-03-31 13:37:21 +02:00
base_service.rb	Enforce restricted visibilities for snippets	2015-03-08 17:57:08 -06:00
compare_service.rb
create_branch_service.rb	Ecevute hooks and services when branches are created/deleted through web.	2015-03-13 16:07:02 +01:00
create_snippet_service.rb	Enforce restricted visibilities for snippets	2015-03-08 17:57:08 -06:00
create_tag_service.rb	Use project.commit convenience method.	2015-04-24 12:29:36 +02:00
delete_branch_service.rb	Ecevute hooks and services when branches are created/deleted through web.	2015-03-13 16:07:02 +01:00
delete_tag_service.rb	Move tag deletion to service and execute hooks and services.	2015-03-13 16:07:08 +01:00
delete_user_service.rb	Skip repo removing whem remove user or group	2015-06-03 16:16:27 +02:00
destroy_group_service.rb	Skip repo removing whem remove user or group	2015-06-03 16:16:27 +02:00
event_create_service.rb	Use PushDataBuilder where applicable.	2015-03-13 16:06:56 +01:00
git_push_service.rb	Fix post-receive errors on a push when an external issue tracker is configured	2015-06-12 06:59:27 -07:00
git_tag_push_service.rb	Use project.commit convenience method.	2015-04-24 12:29:36 +02:00
gravatar_service.rb	Improve application settings and write tests	2015-01-08 09:53:35 -08:00
issuable_base_service.rb	Support editing target branch of merge request	2015-05-29 04:08:08 -07:00
notification_service.rb	Fix.	2015-05-15 13:54:41 +02:00
system_hooks_service.rb	Added X-GitLab-Event header for web hooks	2015-05-08 16:49:03 +03:00
system_note_service.rb	Support editing target branch of merge request	2015-05-29 04:08:08 -07:00
test_hook_service.rb	Added X-GitLab-Event header for web hooks	2015-05-08 16:49:03 +03:00
update_snippet_service.rb	Enforce restricted visibilities for snippets	2015-03-08 17:57:08 -06:00