f23b1cb453
Replace MR access checks with use of MergeRequestsFinder Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867 ⚠️ - Potentially untested 💣 - No test coverage 🚥 - Test coverage of some sort exists (a test failed when error raised) 🚦 - Test coverage of return value (a test failed when nil used) ✅ - Permissions check tested - [x] 💣 app/finders/notes_finder.rb:17 - [x] ⚠️ app/views/layouts/nav/_project.html.haml:80 [`.count`] - [x] 💣 app/controllers/concerns/creates_commit.rb:84 - [x] 🚥 app/controllers/projects/commits_controller.rb:24 - [x] 🚥 app/controllers/projects/compare_controller.rb:56 - [x] 🚦 app/controllers/projects/discussions_controller.rb:29 - [x] ✅ app/controllers/projects/todos_controller.rb:27 - [x] 🚦 app/models/commit.rb:268 - [x] ✅ lib/gitlab/search_results.rb:71 - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_267_266 Memoize ` merged_merge_request(current_user)` - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_248_247 Expected side effect for `merged_merge_request!`, consider `skip_authorization: true`. - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_269_269 Scary use of unchecked `merged_merge_request?` See merge request !2033
150 lines
4.5 KiB
Ruby
150 lines
4.5 KiB
Ruby
# Controller for a specific Commit
|
|
#
|
|
# Not to be confused with CommitsController, plural.
|
|
class Projects::CommitController < Projects::ApplicationController
|
|
include CreatesCommit
|
|
include DiffForPath
|
|
include DiffHelper
|
|
|
|
# Authorize
|
|
before_action :require_non_empty_project
|
|
before_action :authorize_download_code!, except: [:cancel_builds, :retry_builds]
|
|
before_action :authorize_update_build!, only: [:cancel_builds, :retry_builds]
|
|
before_action :authorize_read_pipeline!, only: [:pipelines]
|
|
before_action :authorize_read_commit_status!, only: [:builds]
|
|
before_action :commit
|
|
before_action :define_commit_vars, only: [:show, :diff_for_path, :builds, :pipelines]
|
|
before_action :define_status_vars, only: [:show, :builds, :pipelines]
|
|
before_action :define_note_vars, only: [:show, :diff_for_path]
|
|
before_action :authorize_edit_tree!, only: [:revert, :cherry_pick]
|
|
|
|
def show
|
|
apply_diff_view_cookie!
|
|
|
|
respond_to do |format|
|
|
format.html
|
|
format.diff { render text: @commit.to_diff }
|
|
format.patch { render text: @commit.to_patch }
|
|
end
|
|
end
|
|
|
|
def diff_for_path
|
|
render_diff_for_path(@commit.diffs(diff_options))
|
|
end
|
|
|
|
def pipelines
|
|
end
|
|
|
|
def builds
|
|
end
|
|
|
|
def cancel_builds
|
|
ci_builds.running_or_pending.each(&:cancel)
|
|
|
|
redirect_back_or_default default: builds_namespace_project_commit_path(project.namespace, project, commit.sha)
|
|
end
|
|
|
|
def retry_builds
|
|
ci_builds.latest.failed.each do |build|
|
|
if build.retryable?
|
|
Ci::Build.retry(build, current_user)
|
|
end
|
|
end
|
|
|
|
redirect_back_or_default default: builds_namespace_project_commit_path(project.namespace, project, commit.sha)
|
|
end
|
|
|
|
def branches
|
|
@branches = @project.repository.branch_names_contains(commit.id)
|
|
@tags = @project.repository.tag_names_contains(commit.id)
|
|
render layout: false
|
|
end
|
|
|
|
def revert
|
|
assign_change_commit_vars(@commit.revert_branch_name)
|
|
|
|
return render_404 if @target_branch.blank?
|
|
|
|
create_commit(Commits::RevertService, success_notice: "The #{@commit.change_type_title(current_user)} has been successfully reverted.",
|
|
success_path: successful_change_path, failure_path: failed_change_path)
|
|
end
|
|
|
|
def cherry_pick
|
|
assign_change_commit_vars(@commit.cherry_pick_branch_name)
|
|
|
|
return render_404 if @target_branch.blank?
|
|
|
|
create_commit(Commits::CherryPickService, success_notice: "The #{@commit.change_type_title(current_user)} has been successfully cherry-picked.",
|
|
success_path: successful_change_path, failure_path: failed_change_path)
|
|
end
|
|
|
|
private
|
|
|
|
def successful_change_path
|
|
referenced_merge_request_url || namespace_project_commits_url(@project.namespace, @project, @target_branch)
|
|
end
|
|
|
|
def failed_change_path
|
|
referenced_merge_request_url || namespace_project_commit_url(@project.namespace, @project, params[:id])
|
|
end
|
|
|
|
def referenced_merge_request_url
|
|
if merge_request = @commit.merged_merge_request(current_user)
|
|
namespace_project_merge_request_url(@project.namespace, @project, merge_request)
|
|
end
|
|
end
|
|
|
|
def commit
|
|
@noteable = @commit ||= @project.commit(params[:id])
|
|
end
|
|
|
|
def ci_builds
|
|
@ci_builds ||= Ci::Build.where(pipeline: pipelines)
|
|
end
|
|
|
|
def define_commit_vars
|
|
return git_not_found! unless commit
|
|
|
|
opts = diff_options
|
|
opts[:ignore_whitespace_change] = true if params[:format] == 'diff'
|
|
|
|
@diffs = commit.diffs(opts)
|
|
@notes_count = commit.notes.count
|
|
end
|
|
|
|
def define_note_vars
|
|
@grouped_diff_discussions = commit.notes.grouped_diff_discussions
|
|
@notes = commit.notes.non_diff_notes.fresh
|
|
|
|
Banzai::NoteRenderer.render(
|
|
@grouped_diff_discussions.values.flat_map(&:notes) + @notes,
|
|
@project,
|
|
current_user,
|
|
)
|
|
|
|
@note = @project.build_commit_note(commit)
|
|
|
|
@noteable = @commit
|
|
@comments_target = {
|
|
noteable_type: 'Commit',
|
|
commit_id: @commit.id
|
|
}
|
|
end
|
|
|
|
def define_status_vars
|
|
@ci_pipelines = project.pipelines.where(sha: commit.sha)
|
|
@statuses = CommitStatus.where(pipeline: @ci_pipelines).relevant
|
|
@builds = Ci::Build.where(pipeline: @ci_pipelines).relevant
|
|
end
|
|
|
|
def assign_change_commit_vars(mr_source_branch)
|
|
@commit = project.commit(params[:id])
|
|
@target_branch = params[:target_branch]
|
|
@mr_source_branch = mr_source_branch
|
|
@mr_target_branch = @target_branch
|
|
@commit_params = {
|
|
commit: @commit,
|
|
create_merge_request: params[:create_merge_request].present? || different_project?
|
|
}
|
|
end
|
|
end
|