kotovalexarian-likes-gitlab/sortix--sortix
1
0
Fork 0
mirror of https://gitlab.com/sortix/sortix.git synced 2023-02-13 20:55:38 -05:00
Code Releases Activity

Fix mkstemp(3) not rejecting bad templates.

Browse source 
Found by musl's libc-test.
This commit is contained in:
Jonas 'Sortie' Termansen 2014-08-20 01:13:56 +02:00
parent 40fd0fa3dc
commit 74fbbb3c78
1 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
libc/stdlib/mkstemp.cpp
View file

@ -1,6 +1,6 @@
/******************************************************************************* /*******************************************************************************
Copyright(C) Jonas 'Sortie' Termansen 2013. Copyright(C) Jonas 'Sortie' Termansen 2013, 2014.
This file is part of the Sortix C Library. This file is part of the Sortix C Library.
@ -29,13 +29,22 @@
extern "C" int mkstemp(char* templ) extern "C" int mkstemp(char* templ)
{ {
size_t templ_length = strlen(templ);
for ( size_t i = 0; i < 6; i++ )
{
if ( templ_length - i == 0 )
return errno = EINVAL, -1;
if ( templ[templ_length - i - 1] != 'X' )
return errno = EINVAL, -1;
}
int fd; int fd;
do do
{ {
size_t templ_len = strlen(templ); for ( size_t i = templ_length - 6; i < templ_length; i++ )
for ( size_t i = templ_len - 6UL; i < templ_len; i++ )
templ[i] = '0' + rand() % 10; templ[i] = '0' + rand() % 10;
} while ( (fd = open(templ, O_RDWR | O_EXCL | O_CREAT, 0666)) < 0 && } while ( (fd = open(templ, O_RDWR | O_EXCL | O_CREAT, 0666)) < 0 &&
(errno == EEXIST) ); (errno == EEXIST) );
return fd; return fd;
} }