From d312a801e339ab6140644a2f2b66ecde6869e490 Mon Sep 17 00:00:00 2001 From: makeworld Date: Wed, 22 Dec 2021 20:39:17 -0500 Subject: [PATCH] Lint fix --- display/download.go | 2 ++ display/handlers.go | 2 ++ sysopen/open_browser_darwin.go | 1 + sysopen/open_browser_unix.go | 1 + sysopen/open_browser_windows.go | 1 + webbrowser/open_browser_darwin.go | 1 + webbrowser/open_browser_unix.go | 2 ++ webbrowser/open_browser_windows.go | 1 + 8 files changed, 11 insertions(+) diff --git a/display/download.go b/display/download.go index fd08e14..41c1301 100644 --- a/display/download.go +++ b/display/download.go @@ -191,6 +191,7 @@ func open(u string, resp *gemini.Response) { Error("File Opening Error", "Error executing custom command: "+err.Error()) return } + //nolint:errcheck go proc.Wait() // Prevent zombies, see #219 Info("Opened with " + cmd[0]) return @@ -221,6 +222,7 @@ func open(u string, resp *gemini.Response) { Error("File Opening Error", "Error executing custom command: "+err.Error()) return } + //nolint:errcheck go proc.Wait() // Prevent zombies, see #219 Info("Opened with " + cmd[0]) } diff --git a/display/handlers.go b/display/handlers.go index 2fa95c9..7d48849 100644 --- a/display/handlers.go +++ b/display/handlers.go @@ -59,6 +59,7 @@ func handleHTTP(u string, showInfo bool) bool { Error("HTTP Error", "Error executing custom browser command: "+err.Error()) return false } + //nolint:errcheck go proc.Wait() // Prevent zombies, see #219 Info("Opened with: " + config.HTTPCommand[0]) @@ -116,6 +117,7 @@ func handleOther(u string) { if err != nil { Error("URL Error", "Error executing custom command: "+err.Error()) } + //nolint:errcheck go proc.Wait() // Prevent zombies, see #219 Info("Opened with: " + handler[0]) App.Draw() diff --git a/sysopen/open_browser_darwin.go b/sysopen/open_browser_darwin.go index 11d0f8a..1355986 100644 --- a/sysopen/open_browser_darwin.go +++ b/sysopen/open_browser_darwin.go @@ -12,6 +12,7 @@ func Open(path string) (string, error) { if err != nil { return "", err } + //nolint:errcheck go proc.Wait() // Prevent zombies, see #219 return "Opened in default system viewer", nil } diff --git a/sysopen/open_browser_unix.go b/sysopen/open_browser_unix.go index 76e0ab9..799709f 100644 --- a/sysopen/open_browser_unix.go +++ b/sysopen/open_browser_unix.go @@ -29,6 +29,7 @@ func Open(path string) (string, error) { if err := proc.Start(); err != nil { return "", err } + //nolint:errcheck go proc.Wait() // Prevent zombies, see #219 return "Opened in default system viewer", nil default: diff --git a/sysopen/open_browser_windows.go b/sysopen/open_browser_windows.go index b2323ff..815594d 100644 --- a/sysopen/open_browser_windows.go +++ b/sysopen/open_browser_windows.go @@ -13,6 +13,7 @@ func Open(path string) (string, error) { if err != nil { return "", err } + //nolint:errcheck go proc.Wait() // Prevent zombies, see #219 return "Opened in default system viewer", nil } diff --git a/webbrowser/open_browser_darwin.go b/webbrowser/open_browser_darwin.go index fd393a4..38e00a7 100644 --- a/webbrowser/open_browser_darwin.go +++ b/webbrowser/open_browser_darwin.go @@ -12,6 +12,7 @@ func Open(url string) (string, error) { if err != nil { return "", err } + //nolint:errcheck go proc.Wait() // Prevent zombies, see #219 return "Opened in system default web browser", nil } diff --git a/webbrowser/open_browser_unix.go b/webbrowser/open_browser_unix.go index 14d01eb..00d5af1 100644 --- a/webbrowser/open_browser_unix.go +++ b/webbrowser/open_browser_unix.go @@ -38,6 +38,7 @@ func Open(url string) (string, error) { if err := proc.Start(); err != nil { return "", err } + //nolint:errcheck go proc.Wait() // Prevent zombies, see #219 return "Opened in system default web browser", nil case envBrowser != "": @@ -45,6 +46,7 @@ func Open(url string) (string, error) { if err := proc.Start(); err != nil { return "", err } + //nolint:errcheck go proc.Wait() // Prevent zombies, see #219 return "Opened in system default web browser", nil default: diff --git a/webbrowser/open_browser_windows.go b/webbrowser/open_browser_windows.go index 4cff6a8..3e5d5f8 100644 --- a/webbrowser/open_browser_windows.go +++ b/webbrowser/open_browser_windows.go @@ -13,6 +13,7 @@ func Open(url string) (string, error) { if err != nil { return "", err } + //nolint:errcheck go proc.Wait() // Prevent zombies, see #219 return "Opened in system default web browser", nil }