From 30884c22a2ba2eaeeab8476a6a356f0f18526442 Mon Sep 17 00:00:00 2001 From: Markus Schirp Date: Mon, 8 Jul 2013 17:57:25 +0200 Subject: [PATCH] Remove literal array mutation that adds an element It turns out this mutation is not "universal". Meaning not in all scenarios this extra element triggers an edge case the specs have to cover. --- config/flay.yml | 2 +- lib/mutant/mutator/node/literal/array.rb | 1 - .../mutant/mutator/node/literal/array_spec.rb | 3 --- .../mutator/node/literal/empty_array_spec.rb | 17 ----------------- 4 files changed, 1 insertion(+), 22 deletions(-) delete mode 100644 spec/unit/mutant/mutator/node/literal/empty_array_spec.rb diff --git a/config/flay.yml b/config/flay.yml index 9466323b..ca6e1429 100644 --- a/config/flay.yml +++ b/config/flay.yml @@ -1,3 +1,3 @@ --- threshold: 16 -total_score: 684 +total_score: 680 diff --git a/lib/mutant/mutator/node/literal/array.rb b/lib/mutant/mutator/node/literal/array.rb index 37620a06..bb8008d9 100644 --- a/lib/mutant/mutator/node/literal/array.rb +++ b/lib/mutant/mutator/node/literal/array.rb @@ -34,7 +34,6 @@ module Mutant emit_self(*dup_children) mutate_child(index) end - emit_self(s(:nil), *children) end end # Array diff --git a/spec/unit/mutant/mutator/node/literal/array_spec.rb b/spec/unit/mutant/mutator/node/literal/array_spec.rb index 22f2332b..5a94fccc 100644 --- a/spec/unit/mutant/mutator/node/literal/array_spec.rb +++ b/spec/unit/mutant/mutator/node/literal/array_spec.rb @@ -21,9 +21,6 @@ describe Mutant::Mutator::Node::Literal, 'array' do # Empty array mutations << '[]' - - # Extra element - mutations << '[nil, true, false]' end it_should_behave_like 'a mutator' diff --git a/spec/unit/mutant/mutator/node/literal/empty_array_spec.rb b/spec/unit/mutant/mutator/node/literal/empty_array_spec.rb deleted file mode 100644 index f2cdb4aa..00000000 --- a/spec/unit/mutant/mutator/node/literal/empty_array_spec.rb +++ /dev/null @@ -1,17 +0,0 @@ -require 'spec_helper' - -describe Mutant::Mutator::Node::Literal, 'empty array' do - let(:source) { '[]' } - - let(:mutations) do - mutations = [] - - # Literal replaced with nil - mutations << 'nil' - - # Extra element - mutations << '[nil]' - end - - it_should_behave_like 'a mutator' -end