free_mutant/lib/mutant/mutator/node/send.rb
Michael Herold f6b9b8b095
Stop mutation of #to_i to implicit self
The mutations of all calls to `#to_i` include one that mutates the call into a
call to `Integer`. This is a great mutation in all calses where there is an
explicit receiver for the `#to_i` call. However, the way that the implicit call
to `self.to_i` is parsed results in a receiver of `nil` instead of `self`.

As such, we want to limit this particular mutation to calls to `#to_i` that have
an explicit receiver. This feels like the correct behavior because the result of
the mutation would be (if it parsed): `Integer(nil)`, which doesn't retain the
intended behavior of the original source.

Another way to approach this would be to mutate the code to `Integer(self)`, but
that doesn't feel as correct to me because if you're using the implicit `self`
with a call to `#to_i`, you likely are not implementing the strict `#to_int`
method as well, which `Integer` relies on.

This fix feels like the right mix of correctness and minimal invasiveness.

Closes #738
2018-06-17 16:53:59 -05:00

257 lines
7.2 KiB
Ruby

module Mutant
class Mutator
class Node
# Namespace for send mutators
# rubocop:disable ClassLength
class Send < self
include AST::Types
handle(:send)
children :receiver, :selector
SELECTOR_REPLACEMENTS = IceNine.deep_freeze(
reverse_map: %i[map each],
kind_of?: %i[instance_of?],
is_a?: %i[instance_of?],
reverse_each: %i[each],
reverse_merge: %i[merge],
map: %i[each],
flat_map: %i[map],
sample: %i[first last],
pop: %i[last],
shift: %i[first],
first: %i[last],
last: %i[first],
send: %i[public_send __send__],
__send__: %i[public_send],
method: %i[public_method],
gsub: %i[sub],
eql?: %i[equal?],
to_s: %i[to_str],
to_i: %i[to_int],
to_a: %i[to_ary to_set],
to_h: %i[to_hash],
at: %i[fetch key?],
fetch: %i[key?],
values_at: %i[fetch_values],
match: %i[match?],
'=~': %i[match?],
:[] => %i[at fetch key?],
:== => %i[eql? equal?],
:>= => %i[> == eql? equal?],
:<= => %i[< == eql? equal?],
:> => %i[== >= eql? equal?],
:< => %i[== <= eql? equal?]
)
RECEIVER_SELECTOR_REPLACEMENTS = IceNine.deep_freeze(
Date: {
parse: %i[jd civil strptime iso8601 rfc3339 xmlschema rfc2822 rfc822 httpdate jisx0301]
}
)
private
# Emit mutations
#
# @return [undefined]
def dispatch
emit_singletons
if meta.index_assignment?
run(Index::Assign)
else
non_index_dispatch
end
end
# Perform non index dispatch
#
# @return [undefined]
def non_index_dispatch
if meta.binary_method_operator?
run(Binary)
elsif meta.attribute_assignment?
run(AttributeAssignment)
else
normal_dispatch
end
end
# AST metadata for node
#
# @return [AST::Meta::Send]
def meta
AST::Meta::Send.new(node)
end
memoize :meta
# Arguments being send
#
# @return [Enumerable<Parser::AST::Node>]
alias_method :arguments, :remaining_children
private :arguments
# Perform normal, non special case dispatch
#
# @return [undefined]
def normal_dispatch
emit_naked_receiver
emit_selector_replacement
emit_selector_specific_mutations
emit_argument_propagation
emit_receiver_selector_mutations
mutate_receiver
mutate_arguments
end
# Emit mutations which only correspond to one selector
#
# @return [undefined]
def emit_selector_specific_mutations
emit_const_get_mutation
emit_integer_mutation
emit_dig_mutation
emit_double_negation_mutation
emit_lambda_mutation
emit_drop_mutation
end
# Emit selector mutations specific to top level constants
#
# @return [undefined]
def emit_receiver_selector_mutations
return unless meta.receiver_possible_top_level_const?
RECEIVER_SELECTOR_REPLACEMENTS
.fetch(receiver.children.last, EMPTY_HASH)
.fetch(selector, EMPTY_ARRAY)
.each(&method(:emit_selector))
end
# Emit mutation from `!!foo` to `foo`
#
# @return [undefined]
def emit_double_negation_mutation
return unless selector.equal?(:!) && n_send?(receiver)
negated = AST::Meta::Send.new(meta.receiver)
emit(negated.receiver) if negated.selector.equal?(:!)
end
# Emit mutation from proc definition to lambda
#
# @return [undefined]
def emit_lambda_mutation
emit(s(:send, nil, :lambda)) if meta.proc?
end
# Emit mutation for `#dig`
#
# - Mutates `foo.dig(a, b)` to `foo.fetch(a).dig(b)`
# - Mutates `foo.dig(a)` to `foo.fetch(a)`
#
# @return [undefined]
def emit_dig_mutation
return if !selector.equal?(:dig) || arguments.none?
head, *tail = arguments
fetch_mutation = s(:send, receiver, :fetch, head)
return emit(fetch_mutation) if tail.empty?
emit(s(:send, fetch_mutation, :dig, *tail))
end
# Emit mutation `foo[n..-1]` -> `foo.drop(n)`
#
# @return [undefined]
def emit_drop_mutation
return if !selector.equal?(:[]) || !arguments.one? || !n_irange?(arguments.first)
start, ending = *arguments.first
return unless ending.eql?(s(:int, -1))
emit(s(:send, receiver, :drop, start))
end
# Emit mutation from `to_i` to `Integer(...)`
#
# @return [undefined]
def emit_integer_mutation
return unless receiver && selector.equal?(:to_i)
emit(s(:send, nil, :Integer, receiver))
end
# Emit mutation from `const_get` to const literal
#
# @return [undefined]
def emit_const_get_mutation
return unless selector.equal?(:const_get) && n_sym?(arguments.first)
emit(s(:const, receiver, AST::Meta::Symbol.new(arguments.first).name))
end
# Emit selector replacement
#
# @return [undefined]
def emit_selector_replacement
SELECTOR_REPLACEMENTS.fetch(selector, EMPTY_ARRAY).each(&method(:emit_selector))
end
# Emit naked receiver mutation
#
# @return [undefined]
def emit_naked_receiver
emit(receiver) if receiver
end
# Mutate arguments
#
# @return [undefined]
def mutate_arguments
emit_type(receiver, selector)
remaining_children_with_index.each do |_node, index|
mutate_child(index)
delete_child(index)
end
end
# Emit argument propagation
#
# @return [undefined]
def emit_argument_propagation
node = arguments.first
emit(node) if arguments.one? && !NOT_STANDALONE.include?(node.type)
end
# Emit receiver mutations
#
# @return [undefined]
def mutate_receiver
return unless receiver
emit_implicit_self
emit_receiver_mutations do |node|
!n_nil?(node)
end
end
# Emit implicit self mutation
#
# @return [undefined]
def emit_implicit_self
emit_receiver(nil) if n_self?(receiver) && !(
KEYWORDS.include?(selector) ||
METHOD_OPERATORS.include?(selector) ||
meta.attribute_assignment?
)
end
end # Send
end # Node
end # Mutator
end # Mutant