kotovalexarian
/
lpr-partynest
Archived
1
0
Fork 0
Code

Remove unnecessary validations

This commit is contained in:
Alex Kotov 2019-09-30 17:32:53 +05:00
parent ccd238b1ba
commit b58c0848c5
Signed by: kotovalexarian
GPG Key ID: 553C0EBBEB5D5F08
2 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/models/contact.rb
View File

@ -24,10 +24,6 @@ class Contact < ApplicationRecord
# Validations #
###############
validates :contact_list, presence: true
validates :contact_network, presence: true
validates :value,
presence: true,
uniqueness: { scope: %i[contact_list_id contact_network_id] }

16
spec/models/contact_spec.rb
View File

@ -6,15 +6,23 @@ RSpec.describe Contact do
subject { create :some_contact }
describe '#contact_list' do
it { is_expected.to belong_to(:contact_list) }
it { is_expected.to belong_to(:contact_list).required }
it { is_expected.to validate_presence_of :contact_list }
it do
is_expected.to \
validate_presence_of(:contact_list)
.with_message(:required)
end
end
describe '#contact_network' do
it { is_expected.to belong_to(:contact_network) }
it { is_expected.to belong_to(:contact_network).required }
it { is_expected.to validate_presence_of :contact_network }
it do
is_expected.to \
validate_presence_of(:contact_network)
.with_message(:required)
end
end
describe '#value' do