rubygems
/
dry-core
1
0
Fork 0
Code Packages Releases Activity

Handle case when no memoizer module exist

This commit is contained in:
Nikita Shilnikov 2022-10-31 10:38:03 +03:00
parent 4162673039
commit 3781de6690
No known key found for this signature in database
GPG Key ID: E569D1D64C40E241
2 changed files with 30 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/dry/core/memoizable.rb
View File

@ -16,7 +16,7 @@ module Dry
super
memoizer = base.ancestors.find { _1.is_a?(Memoizer) }
base.prepend(memoizer.dup)
base.prepend(memoizer.dup) if memoizer
end
end

42
spec/dry/core/memoizable_spec.rb
View File

@ -210,24 +210,40 @@ RSpec.describe Dry::Core::Memoizable do
context "inheritance" do
let(:subclass) { Class.new(klass) }
before do
klass.define_method(:nodes) { [:root] }
klass.define_method(:path) { [*nodes, :leaf] }
klass.memoize(:nodes, :path)
context "with memoisation" do
before do
klass.define_method(:nodes) { [:root] }
klass.define_method(:path) { [*nodes, :leaf] }
klass.memoize(:nodes, :path)
subclass.define_method(:nodes) { [*super(), :node] }
subclass.define_method(:nodes) { [*super(), :node] }
end
let(:subclass_instance) do
subclass.new
end
it "memoizes results separately" do
expect(instance.nodes).to eql([:root])
expect(instance.path).to eql([:root, :leaf])
expect(subclass_instance.nodes).to eql([:root, :node])
expect(subclass_instance.path).to eql([:root, :node, :leaf])
end
end
let(:subclass_instance) do
subclass.new
end
context "inheritance w/o module" do
before do
klass.define_method(:nodes) { [:root] }
end
it "memoizes results separately" do
expect(instance.nodes).to eql([:root])
expect(instance.path).to eql([:root, :leaf])
let(:subclass_instance) do
subclass.new
end
expect(subclass_instance.nodes).to eql([:root, :node])
expect(subclass_instance.path).to eql([:root, :node, :leaf])
it "doesn't throw an error" do
expect(subclass_instance.nodes).to eql([:root])
end
end
end
end