rubygems
/
pry
1
0
Fork 0
Code Packages Releases Activity

Merge pull request #2253 from dduugg/lazy-eval-regex 

Short circuit eval regexes in finding module definition
This commit is contained in:
Kyrylo Silin 2022-08-19 10:53:42 +03:00 committed by GitHub
parent 0633835d5d e0ecbb3b28
commit 43c2d3c794
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lib/pry/wrapped_module/candidate.rb
View File

@ -98,14 +98,15 @@ class Pry
# line number is one-indexed.
def first_line_of_module_definition(file, line)
searchable_lines = lines_for_file(file)[0..(line - 2)]
searchable_lines.rindex { |v| class_regexes.any? { |r| r =~ v } } + 1
searchable_lines.rindex { |v| module_definition_first_line?(v) } + 1
end
def class_regexes
def module_definition_first_line?(line)
mod_type_string = wrapped.class.to_s.downcase
[/(^|=)\s*#{mod_type_string}\s+(?:(?:\w*)::)*?#{wrapped.name.split(/::/).last}/,
/^\s*(::)?#{wrapped.name.split(/::/).last}\s*?=\s*?#{wrapped.class}/,
/^\s*(::)?#{wrapped.name.split(/::/).last}\.(class|instance)_eval/]
wrapped_name_last = wrapped.name.split(/::/).last
/(^|=)\s*#{mod_type_string}\s+(?:(?:\w*)::)*?#{wrapped_name_last}/ =~ line ||
/^\s*(::)?#{wrapped_name_last}\s*?=\s*?#{wrapped.class}/ =~ line ||
/^\s*(::)?#{wrapped_name_last}\.(class|instance)_eval/ =~ line
end
# This method is used by `Candidate#source_location` as a