Commit Graph

23 Commits

Author SHA1 Message Date
Douglas Eichelberger 6c2e2f54ae Complete Style/ExpandPathArguments todo 2022-09-11 15:16:17 -07:00
Douglas Eichelberger 0e06fc6ab2 Complete Style/SymbolArray todo 2022-09-11 15:15:36 -07:00
André Luis Leal Cardoso Junior d1aee59994 Prevents Ruby 3.1 incompatibility error. You can enable this cop when Ruby 2.4 support is dropped. 2021-12-27 12:06:50 -03:00
Kyrylo Silin 18c45d26c5 rubocop: enable the Style/FrozenStringLiteralComment cop
This will greatly ease Pry support on Ruby 3.0 (when it's out).
2019-05-08 00:13:17 +03:00
Kyrylo Silin b92065d465 helpers/command_helpers: add tests, refactor variable names
First of all, we move the spec file from `spec` to `spec/helpers`. This is where
it is supposed to be.

Next, we add tests for all the methods that the module defines. During this
process I had to change `module_function` to `extend self`. Rubocop doesn't like
it for some unknown to me reason, so I had to disable the rule. There's no harm
in doing so.

Finally, I refactored some methods (low-hanging fruits only) and discovered that
the `command_error` method is not necessary at all.

All in all, this module is a lot better now but I feel like it shouldn't exist
at all, since almost all methods are very specific to certain Pry commands. It's
hardly a general purpose module for Pry plugins.
2019-03-30 20:53:06 +02:00
Kyrylo Silin 674a44d9a7 rubocop: ignore Gemspec/RequiredRubyVersion 2019-03-24 18:49:40 +02:00
Kyrylo Silin b938bddf0a rubocop: configure the Style/CommentedKeyword cop 2019-03-24 01:57:44 +02:00
Kyrylo Silin 8edffe65ef rubocop: disable the Style/Documentation cop
On a normal day I would keep it enabled but I don't really fancy documenting 138
classes...
2019-03-24 01:56:00 +02:00
Kyrylo Silin 8d97eb84f1 rubocop: disable Style/DoubleNegation
This cop makes sense to me, however a lot of our code has offences that are not
fixable on the same level. To avoid them we'd need to redesign API of some
classes, which isn't worth it.
2019-03-23 20:03:52 +02:00
Kyrylo Silin cb5eaab409 Gemfile: remove groups
We plan to use SimpleCov and Bundler.require gets in the way. Without it Gemfile
groups are useless, so I am removing them.

I am also removing the silly `Bundler/OrderedGems` cop, one of the most useless
cops you can add.
2019-03-08 00:46:50 +02:00
Kyrylo Silin 4956376f13 rubocop: fix offences of the Metrics/LineLength cop
I realise that some code might be less readable now, but now that we set a good
default limit, we protect the codebase from further mess. It's important to do
this to prevent adding more mess to already messy code that we have. :doctor:
2019-03-03 17:37:58 +02:00
Kyrylo Silin 23ccad1506 rubocop: embrace the Style/SymbolArray cop 2019-03-02 16:26:36 +02:00
Kyrylo Silin 3da9f10c1b rubocop: disable the Style/StringLiterals cop 2019-03-02 16:01:45 +02:00
Kyrylo Silin 080d2b0b3a rubocop: fix offences of the Style/SingleLineMethods cop 2019-03-02 15:42:52 +02:00
Kyrylo Silin 501e949921 rubocop: fix offences of the Style/ExpandPathArguments cop 2019-03-02 11:03:51 +02:00
Kyrylo Silin b98cff1b85 rubocop: fix offences of the Style/ClassAndModuleChildren cop 2019-02-27 02:23:52 +02:00
Kyrylo Silin e1f12f1c6c rubocop: fix offences of the Layout/DotPosition cop 2019-02-25 00:11:05 +02:00
Kyrylo Silin d37f154150 rubocop: don't check fixtures for Layout/CommentIndentation 2019-02-25 00:00:27 +02:00
r-obert 642588dfe9
Add API documentation for Pry::Config (#1892) 2018-12-01 08:16:18 +01:00
Kyrylo Silin 5bf2a5b15a rubocop: temporarily ignore certain Naming/MethodName offences
The build is failing because of this.
2018-11-04 18:01:16 +08:00
Kyrylo Silin 8588b36f62 rubocop: disable Layout/IndentHeredoc
This cop suggests to install a library to format heredocs. LOL
2018-11-04 00:49:55 +08:00
Kyrylo Silin 269808c6ba rubocop: disable the Style/NumericPredicate cop
This is very opinionated and not necessary to follow.
2018-10-20 00:32:30 +08:00
Kyrylo Silin a5c0718731 rubocop: generate config
The config ignores all violations for now. We will be fixing them at our own
pace.
2018-10-06 20:07:27 +08:00