rubygems
/
rails
1
0
Fork 0
Code Packages Releases Activity
rails/.rubocop.yml

341 lines
6.3 KiB
YAML
Raw Permalink Normal View History

Bump rubocop to 0.71
2019-06-06 05:38:19 +00:00
require:
Tweak unreachable assertion tests in the block of `assert_raises` I found an unexpected use of assertion in the block of `assert_raise` when I implemented https://github.com/rubocop/rubocop-minitest/pull/137. It is expected to be asserted after an exception is raised in `assert_raise` block, but in actually it is not asserted after an exception is raised. Therefore, this PR removes or updates assertions that have not been asserted after an exception has raised. This PR will add `rubocop-minitest` and enable `Minitest/UnreachableAssertion` cop to able similar auto-detection, but will remove `rubocop-minitest` from this PR if you don't like it.
2021-06-24 10:46:21 +00:00
- rubocop-minitest
Update RuboCop to v0.90 Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
2020-09-06 01:07:04 +00:00
- rubocop-packaging
Bump rubocop to 0.71
2019-06-06 05:38:19 +00:00
- rubocop-performance
- rubocop-rails
Bump RuboCop to 0.67.2 Performance cops will be extracted from RuboCop to RuboCop Performance when next RuboCop 0.68 will be released. https://github.com/rubocop-hq/rubocop/issues/5977 RuboCop 0.67 is its transition period. Since rails/rails repository uses Performance cops, This PR added rubocop-performance gem to Gemfile. And this PR fixes some offenses using the following auto-correct. ```console % bundle exec rubocop -a Offenses: activerecord/test/cases/connection_adapters/connection_handlers_multi_db_test.rb:212:26: C: [Corrected] Layout/SpaceAroundOperators: Operator = > should be surrounded by a single space. "primary" => { adapter: "sqlite3", database: "db/primary.sqlite3" } ^^ activerecord/test/cases/connection_adapters/connection_handlers_multi_db_test.rb:239:26: C: [Corrected] Layout/SpaceAroundOperators: Operator => should be surrounded by a single space. "primary" => { adapter: "sqlite3", database: "db/primary.sqlite3" } ^^ actionview/test/template/resolver_shared_tests.rb:1:1: C: [Corrected] Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true. module ResolverSharedTests ^ actionview/test/template/resolver_shared_tests.rb:10:33: C: [Corrected] Layout/SpaceAroundEqualsInParameterDefault: Surrounding space missing in default value assignment. def with_file(filename, source="File at #{filename}") ^ actionview/test/template/resolver_shared_tests.rb:106:5: C: [Corrected] Rails/RefuteMethods: Prefer assert_not_same over refute_same. refute_same a, b ^^^^^^^^^^^ 2760 files inspected, 5 offenses detected, 5 offenses corrected ```
2019-04-16 08:05:50 +00:00
Add codeclimate and rubocop config files We're going to be experimenting with a new bot for them. This will not cause anything to start affecting new PRs yet, but it will have data sent to them so they can do "dry run" stuff on their end. The rubocop file is based on our documented style guide. I've only included rules which are either already consistently applied throughout the entire codebase, or where added lines should be following the guideline regardless of the surrounding code (such as hash syntax)
2016-06-13 14:29:50 +00:00
AllCops:
Update `TargetRubyVersion` to 2.7 in `.rubocop.yml`
2021-02-04 20:12:44 +00:00
TargetRubyVersion: 2.7
adds a few cops and sorts
2016-08-06 15:45:37 +00:00
# RuboCop has a bunch of cops enabled by default. This setting tells RuboCop
Fix a typo
2016-08-07 11:06:51 +00:00
# to ignore them, so only the ones explicitly set in this file are enabled.
Add codeclimate and rubocop config files We're going to be experimenting with a new bot for them. This will not cause anything to start affecting new PRs yet, but it will have data sent to them so they can do "dry run" stuff on their end. The rubocop file is based on our documented style guide. I've only included rules which are either already consistently applied throughout the entire codebase, or where added lines should be following the guideline regardless of the surrounding code (such as hash syntax)
2016-06-13 14:29:50 +00:00
DisabledByDefault: true
Disable rubocop suggestions
2021-01-26 23:41:59 +00:00
SuggestExtensions: false
adds a few cops and sorts
2016-08-06 15:45:37 +00:00
Exclude:
Less Pure Copping: cop-out tmp folders for generated Rails apps After having run the railties tests locally and running Rubocop, you'd see lots of violations for the Rails apps generated in tmp folders. Don't consider those violations as violating.
2019-10-07 00:15:32 +00:00
- '**/tmp/**/*'
adds a few cops and sorts
2016-08-06 15:45:37 +00:00
- '**/templates/**/*'
- '**/vendor/**/*'
Shave a couple of allocations off Journey scan & parse
2016-12-24 14:33:02 +00:00
- 'actionpack/lib/action_dispatch/journey/parser.rb'
Import Action Mailbox
2018-12-24 20:16:22 +00:00
- 'actionmailbox/test/dummy/**/*'
Import Action Text
2019-01-05 00:43:11 +00:00
- 'actiontext/test/dummy/**/*'
Exclude all `node_modules` from the RuboCop check For avoiding check against `node_modules` in railties's test dir.
2019-04-07 11:30:14 +00:00
- '**/node_modules/**/*'
Add codeclimate and rubocop config files We're going to be experimenting with a new bot for them. This will not cause anything to start affecting new PRs yet, but it will have data sent to them so they can do "dry run" stuff on their end. The rubocop file is based on our documented style guide. I've only included rules which are either already consistently applied throughout the entire codebase, or where added lines should be following the guideline regardless of the surrounding code (such as hash syntax)
2016-06-13 14:29:50 +00:00
Remove Rubocop's comments from Rails code base PR#32381 added Rubocop's comments to some tests files in order to exclude `Performance/RedundantMerge`. Turn off `Performance` cops for tests files via `Exclude` in `.rubocop.yml`. Context https://github.com/rails/rails/pull/32381#discussion_r205212331
2018-07-26 08:33:49 +00:00
Performance:
Exclude:
- '**/test/**/*'
Bump RuboCop to 0.58.2 ## Summary RuboCop 0.58.2 was released. https://github.com/rubocop-hq/rubocop/releases/tag/v0.58.2 And rubocop-0-58 channel is available in Code Climate. https://github.com/codeclimate/codeclimate/releases/tag/v0.76.0 https://github.com/codeclimate/codeclimate/commit/38f21f0 In addition, the following changes are made in this PR. - Replace Custom cops with Rails cops - Add jaro_winkler gem to Gemfile.lock ### Replace Custom cops with Rails cops These are compatible replacements. - Replace `CustomCops/AssertNot` cop with `Rails/AssertNot` cop. - Replace `CustomCops/RefuteNot` cop with `Rails/RefuteMethods` cop. With this replacement, it was decided to use cop of RuboCop itself. It removes the code related to CustomCops accordingly. ### Add jaro_winkler gem to Gemfile.lock Since RuboCop 0.57.0 depends on jaro_winkler gem, it has been added to Gemfile.lock.
2018-07-03 03:11:28 +00:00
# Prefer assert_not over assert !
Rails/AssertNot:
Add custom RuboCop for `assert_not` over `refute` Since at least cf4afc4 we have preferred `assert_not` methods over `refute` methods. I have seen plenty of comments in PRs about this, and we have tried to fix it a few times (5294ad8, e45f176, 8910f12, 41f50be, d4cfd54, 48a183e, and 211adb4), but the `refute` methods keep sneaking back in. This custom RuboCop will take care of enforcing this preference, so we don't have to think about it again. I suspect there are other similar stylistic preferences that could be solved with some custom RuboCops, so I will definitely keep my eyes open. `assert_not` over `assert !` might be a good candidate, for example. I wasn't totally sure if `ci/custom_cops` was the best place to put this, but nothing else seemed quite right. At one point I had it set up as a gem, but I think custom cops like this would have limited value in another context. I want to see how code climate handles the new cops before autocorrecting the existing violations. If things go as expected, I will push another commit with those corrections.
2018-04-04 00:50:00 +00:00
Include:
Allow rubocop check more files This commit fix pattern of filenames for `CustomCops/AssertNot` and `CustomCops/RefuteNot`. rubocop should check every file under `test/`. Related to #32441, #32605
2018-04-19 20:25:39 +00:00
- '**/test/**/*'
Add custom RuboCop for `assert_not` over `refute` Since at least cf4afc4 we have preferred `assert_not` methods over `refute` methods. I have seen plenty of comments in PRs about this, and we have tried to fix it a few times (5294ad8, e45f176, 8910f12, 41f50be, d4cfd54, 48a183e, and 211adb4), but the `refute` methods keep sneaking back in. This custom RuboCop will take care of enforcing this preference, so we don't have to think about it again. I suspect there are other similar stylistic preferences that could be solved with some custom RuboCops, so I will definitely keep my eyes open. `assert_not` over `assert !` might be a good candidate, for example. I wasn't totally sure if `ci/custom_cops` was the best place to put this, but nothing else seemed quite right. At one point I had it set up as a gem, but I think custom cops like this would have limited value in another context. I want to see how code climate handles the new cops before autocorrecting the existing violations. If things go as expected, I will push another commit with those corrections.
2018-04-04 00:50:00 +00:00
Bump RuboCop to 0.58.2 ## Summary RuboCop 0.58.2 was released. https://github.com/rubocop-hq/rubocop/releases/tag/v0.58.2 And rubocop-0-58 channel is available in Code Climate. https://github.com/codeclimate/codeclimate/releases/tag/v0.76.0 https://github.com/codeclimate/codeclimate/commit/38f21f0 In addition, the following changes are made in this PR. - Replace Custom cops with Rails cops - Add jaro_winkler gem to Gemfile.lock ### Replace Custom cops with Rails cops These are compatible replacements. - Replace `CustomCops/AssertNot` cop with `Rails/AssertNot` cop. - Replace `CustomCops/RefuteNot` cop with `Rails/RefuteMethods` cop. With this replacement, it was decided to use cop of RuboCop itself. It removes the code related to CustomCops accordingly. ### Add jaro_winkler gem to Gemfile.lock Since RuboCop 0.57.0 depends on jaro_winkler gem, it has been added to Gemfile.lock.
2018-07-03 03:11:28 +00:00
# Prefer assert_not_x over refute_x
Rails/RefuteMethods:
Add RuboCop for `assert_not` over `assert !` We added `assert_not` in f75addd "to replace warty 'assert !foo'". fa8d35b agrees that it is warty, and so do I. This custom Rubocop rule turns the wart into a violation. As with my last custom cop, https://github.com/rails/rails/pull/32441, I want to make sure this looks right on code climate before pushing another commit to autocorrect everything. @toshimaru I just noticed https://github.com/toshimaru/rubocop-rails/pull/26 Is there a better way to add these custom cops, or were you saying we shouldn't have custom cops at all?
2018-04-17 12:37:35 +00:00
Include:
Allow rubocop check more files This commit fix pattern of filenames for `CustomCops/AssertNot` and `CustomCops/RefuteNot`. rubocop should check every file under `test/`. Related to #32441, #32605
2018-04-19 20:25:39 +00:00
- '**/test/**/*'
Add RuboCop for `assert_not` over `assert !` We added `assert_not` in f75addd "to replace warty 'assert !foo'". fa8d35b agrees that it is warty, and so do I. This custom Rubocop rule turns the wart into a violation. As with my last custom cop, https://github.com/rails/rails/pull/32441, I want to make sure this looks right on code climate before pushing another commit to autocorrect everything. @toshimaru I just noticed https://github.com/toshimaru/rubocop-rails/pull/26 Is there a better way to add these custom cops, or were you saying we shouldn't have custom cops at all?
2018-04-17 12:37:35 +00:00
Enable Rails/IndexBy and Rails/IndexWith cops Followup to d3599d8affa90b60b4e9ab24fdbd35477b5ac06d, which applied this style to the existing codebase.
2020-04-19 22:36:05 +00:00
Rails/IndexBy:
Enabled: true
Rails/IndexWith:
Enabled: true
adds a few cops and sorts
2016-08-06 15:45:37 +00:00
# Prefer &&/|| over and/or.
Style/AndOr:
Add a new rule to rubocop
2016-07-20 03:35:11 +00:00
Enabled: true
Add codeclimate and rubocop config files We're going to be experimenting with a new bot for them. This will not cause anything to start affecting new PRs yet, but it will have data sent to them so they can do "dry run" stuff on their end. The rubocop file is based on our documented style guide. I've only included rules which are either already consistently applied throughout the entire codebase, or where added lines should be following the guideline regardless of the surrounding code (such as hash syntax)
2016-06-13 14:29:50 +00:00
adds a few cops and sorts
2016-08-06 15:45:37 +00:00
# Align `when` with `case`.
rubocop namespace changes from `Style` to `Layout` Refer https://github.com/bbatsov/rubocop/pull/4278/commits/54166bf76ba76b14f1bbc8a34165f175dbc3f227 for the commit ``` /path/to/rails/.rubocop.yml: Style/CaseIndentation has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/CommentIndentation has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLines has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundClassBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundMethodBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundModuleBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/IndentationConsistency has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/IndentationWidth has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAfterColon has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAfterComma has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundEqualsInParameterDefault has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundKeyword has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundOperators has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceBeforeFirstArg has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceBeforeBlockBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideBlockBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideHashLiteralBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideParens has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/Tab has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/TrailingBlankLines has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/TrailingWhitespace has the wrong namespace - should be Layout ```
2017-05-24 18:33:50 +00:00
Layout/CaseIndentation:
Add a new rule to rubocop
2016-07-20 03:35:11 +00:00
Enabled: true
Add codeclimate and rubocop config files We're going to be experimenting with a new bot for them. This will not cause anything to start affecting new PRs yet, but it will have data sent to them so they can do "dry run" stuff on their end. The rubocop file is based on our documented style guide. I've only included rules which are either already consistently applied throughout the entire codebase, or where added lines should be following the guideline regardless of the surrounding code (such as hash syntax)
2016-06-13 14:29:50 +00:00
Enable `Layout/ClosingHeredocIndentation` cop
2019-11-24 00:44:32 +00:00
Layout/ClosingHeredocIndentation:
Enabled: true
Fix odd closing parenthesis by enabling the `Layout/ClosingParenthesisIndentation` cop
2021-06-04 08:35:02 +00:00
Layout/ClosingParenthesisIndentation:
Enabled: true
Fix broken comments indentation caused by rubocop auto-correct [ci skip] All indentation was normalized by rubocop auto-correct at 80e66cc4d90bf8c15d1a5f6e3152e90147f00772. But comments was still kept absolute position. This commit aligns comments with method definitions for consistency.
2016-09-14 08:57:52 +00:00
# Align comments with method definitions.
rubocop namespace changes from `Style` to `Layout` Refer https://github.com/bbatsov/rubocop/pull/4278/commits/54166bf76ba76b14f1bbc8a34165f175dbc3f227 for the commit ``` /path/to/rails/.rubocop.yml: Style/CaseIndentation has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/CommentIndentation has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLines has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundClassBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundMethodBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundModuleBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/IndentationConsistency has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/IndentationWidth has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAfterColon has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAfterComma has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundEqualsInParameterDefault has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundKeyword has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundOperators has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceBeforeFirstArg has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceBeforeBlockBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideBlockBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideHashLiteralBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideParens has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/Tab has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/TrailingBlankLines has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/TrailingWhitespace has the wrong namespace - should be Layout ```
2017-05-24 18:33:50 +00:00
Layout/CommentIndentation:
Fix broken comments indentation caused by rubocop auto-correct [ci skip] All indentation was normalized by rubocop auto-correct at 80e66cc4d90bf8c15d1a5f6e3152e90147f00772. But comments was still kept absolute position. This commit aligns comments with method definitions for consistency.
2016-09-14 08:57:52 +00:00
Enabled: true
Enable autocorrect for `Lint/EndAlignment` cop ### Summary This PR changes .rubocop.yml. Regarding the code using `if ... else ... end`, I think the coding style that Rails expects is as follows. ```ruby var = if cond a else b end ``` However, the current .rubocop.yml setting does not offense for the following code. ```ruby var = if cond a else b end ``` I think that the above code expects offense to be warned. Moreover, the layout by autocorrect is unnatural. ```ruby var = if cond a else b end ``` This PR adds a setting to .rubocop.yml to make an offense warning and autocorrect as expected by the coding style. And this change also fixes `case ... when ... end` together. Also this PR itself is an example that arranges the layout using `rubocop -a`. ### Other Information Autocorrect of `Lint/EndAlignment` cop is `false` by default. https://github.com/bbatsov/rubocop/blob/v0.51.0/config/default.yml#L1443 This PR changes this value to `true`. Also this PR has changed it together as it is necessary to enable `Layout/ElseAlignment` cop to make this behavior.
2018-01-18 03:09:16 +00:00
Layout/ElseAlignment:
Enabled: true
Rubocop 0.54 Fix `.rubocop.yml: Lint/EndAlignment has the wrong namespace - should be Layout` warning
2018-04-21 17:13:34 +00:00
# Align `end` with the matching keyword or starting expression except for
# assignments, where it should be aligned with the LHS.
Layout/EndAlignment:
Enabled: true
EnforcedStyleAlignWith: variable
AutoCorrect: true
Enable `Layout/EndOfLine` to prevent \r\n is included in the future Follow up to a1afc7726b3f9a59eb2dbc21fbd7aa59927cc889.
2021-04-24 14:59:19 +00:00
Layout/EndOfLine:
Enabled: true
Enable Layout/EmptyLineAfterMagicComment cop
2017-07-10 13:36:57 +00:00
Layout/EmptyLineAfterMagicComment:
Enabled: true
Enable `Layout/EmptyLinesAroundAccessModifier` cop We sometimes say "✂️ newline after `private`" in a code review (e.g. https://github.com/rails/rails/pull/18546#discussion_r23188776, https://github.com/rails/rails/pull/34832#discussion_r244847195). Now `Layout/EmptyLinesAroundAccessModifier` cop have new enforced style `EnforcedStyle: only_before` (https://github.com/rubocop-hq/rubocop/pull/7059). That cop and enforced style will reduce the our code review cost.
2019-06-12 12:30:49 +00:00
Layout/EmptyLinesAroundAccessModifier:
Enabled: true
EnforcedStyle: only_before
Enable `Layout/EmptyLinesAroundBlockBody` to reduce review cost in the future We sometimes ask "✂️ extra blank lines" to a contributor in reviews like https://github.com/rails/rails/pull/33337#discussion_r201509738. It is preferable to deal automatically without depending on manpower.
2018-07-12 12:29:48 +00:00
Layout/EmptyLinesAroundBlockBody:
Enabled: true
adds a few cops and sorts
2016-08-06 15:45:37 +00:00
# In a regular class definition, no empty lines around the body.
rubocop namespace changes from `Style` to `Layout` Refer https://github.com/bbatsov/rubocop/pull/4278/commits/54166bf76ba76b14f1bbc8a34165f175dbc3f227 for the commit ``` /path/to/rails/.rubocop.yml: Style/CaseIndentation has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/CommentIndentation has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLines has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundClassBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundMethodBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundModuleBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/IndentationConsistency has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/IndentationWidth has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAfterColon has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAfterComma has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundEqualsInParameterDefault has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundKeyword has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundOperators has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceBeforeFirstArg has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceBeforeBlockBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideBlockBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideHashLiteralBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideParens has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/Tab has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/TrailingBlankLines has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/TrailingWhitespace has the wrong namespace - should be Layout ```
2017-05-24 18:33:50 +00:00
Layout/EmptyLinesAroundClassBody:
Add a new rule to rubocop
2016-07-20 03:35:11 +00:00
Enabled: true
Add codeclimate and rubocop config files We're going to be experimenting with a new bot for them. This will not cause anything to start affecting new PRs yet, but it will have data sent to them so they can do "dry run" stuff on their end. The rubocop file is based on our documented style guide. I've only included rules which are either already consistently applied throughout the entire codebase, or where added lines should be following the guideline regardless of the surrounding code (such as hash syntax)
2016-06-13 14:29:50 +00:00
Add `Style/EmptyLinesAroundMethodBody` in `.rubocop.yml` and remove extra empty lines
2017-02-12 11:44:15 +00:00
# In a regular method definition, no empty lines around the body.
rubocop namespace changes from `Style` to `Layout` Refer https://github.com/bbatsov/rubocop/pull/4278/commits/54166bf76ba76b14f1bbc8a34165f175dbc3f227 for the commit ``` /path/to/rails/.rubocop.yml: Style/CaseIndentation has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/CommentIndentation has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLines has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundClassBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundMethodBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundModuleBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/IndentationConsistency has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/IndentationWidth has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAfterColon has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAfterComma has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundEqualsInParameterDefault has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundKeyword has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundOperators has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceBeforeFirstArg has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceBeforeBlockBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideBlockBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideHashLiteralBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideParens has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/Tab has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/TrailingBlankLines has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/TrailingWhitespace has the wrong namespace - should be Layout ```
2017-05-24 18:33:50 +00:00
Layout/EmptyLinesAroundMethodBody:
Add `Style/EmptyLinesAroundMethodBody` in `.rubocop.yml` and remove extra empty lines
2017-02-12 11:44:15 +00:00
Enabled: true
adds a few cops and sorts
2016-08-06 15:45:37 +00:00
# In a regular module definition, no empty lines around the body.
rubocop namespace changes from `Style` to `Layout` Refer https://github.com/bbatsov/rubocop/pull/4278/commits/54166bf76ba76b14f1bbc8a34165f175dbc3f227 for the commit ``` /path/to/rails/.rubocop.yml: Style/CaseIndentation has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/CommentIndentation has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLines has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundClassBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundMethodBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundModuleBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/IndentationConsistency has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/IndentationWidth has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAfterColon has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAfterComma has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundEqualsInParameterDefault has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundKeyword has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundOperators has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceBeforeFirstArg has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceBeforeBlockBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideBlockBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideHashLiteralBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideParens has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/Tab has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/TrailingBlankLines has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/TrailingWhitespace has the wrong namespace - should be Layout ```
2017-05-24 18:33:50 +00:00
Layout/EmptyLinesAroundModuleBody:
Add a new rule to rubocop
2016-07-20 03:35:11 +00:00
Enabled: true
Enable a few more rubocop rules
2016-07-17 07:10:45 +00:00
adds a few cops and sorts
2016-08-06 15:45:37 +00:00
# Use Ruby >= 1.9 syntax for hashes. Prefer { a: :b } over { :a => :b }.
Style/HashSyntax:
Add a new rule to rubocop
2016-07-20 03:35:11 +00:00
Enabled: true
Enable a few more rubocop rules
2016-07-17 07:10:45 +00:00
explain the meaning of some RuboCop config options [ci skip] For consistency mainly. Also, some have a name that could make the reader think they enforce the opposite of what they do, because the default is not visible there.
2016-07-21 11:49:13 +00:00
# Method definitions after `private` or `protected` isolated calls need one
# extra level of indentation.
rubocop namespace changes from `Style` to `Layout` Refer https://github.com/bbatsov/rubocop/pull/4278/commits/54166bf76ba76b14f1bbc8a34165f175dbc3f227 for the commit ``` /path/to/rails/.rubocop.yml: Style/CaseIndentation has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/CommentIndentation has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLines has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundClassBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundMethodBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundModuleBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/IndentationConsistency has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/IndentationWidth has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAfterColon has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAfterComma has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundEqualsInParameterDefault has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundKeyword has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundOperators has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceBeforeFirstArg has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceBeforeBlockBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideBlockBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideHashLiteralBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideParens has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/Tab has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/TrailingBlankLines has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/TrailingWhitespace has the wrong namespace - should be Layout ```
2017-05-24 18:33:50 +00:00
Layout/IndentationConsistency:
Add a new rule to rubocop
2016-07-20 03:35:11 +00:00
Enabled: true
Bump RuboCop to 0.74.0 ### Summary RuboCop 0.74.0 has been released. https://github.com/rubocop-hq/rubocop/releases/tag/v0.74.0 And rubocop-0-74 channel is available in Code Climate. https://github.com/codeclimate/codeclimate/releases/tag/v0.85.5 This PR specifies the same RuboCop Performance (1.3.0) and RuboCop Rails (2.0.0) versions as Code Climate's Gemfile.lock. https://github.com/codeclimate/codeclimate-rubocop/blob/channel/rubocop-0-74/Gemfile.lock#L51-L55 Also, the `EnforcedStyle` of `Layout/IndentationConsistency` has been renamed from `EnforcedStyle: rails` to `EnforcedStyle: indented_internal_methods` - https://github.com/rubocop-hq/rubocop/pull/7113 - https://github.com/rubocop-hq/rubocop/pull/7163 And this commit disables `Layout/SpaceAroundOperators` that was changed from RuboCop 0.74 by rubocop-hq/rubocop#7211. cf. https://github.com/rails/rails/pull/36943#issuecomment-521659529
2019-08-15 12:56:18 +00:00
EnforcedStyle: indented_internal_methods
Enable a few more rubocop rules
2016-07-17 07:10:45 +00:00
adds a few cops and sorts
2016-08-06 15:45:37 +00:00
# Two spaces, no tabs (for indentation).
rubocop namespace changes from `Style` to `Layout` Refer https://github.com/bbatsov/rubocop/pull/4278/commits/54166bf76ba76b14f1bbc8a34165f175dbc3f227 for the commit ``` /path/to/rails/.rubocop.yml: Style/CaseIndentation has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/CommentIndentation has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLines has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundClassBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundMethodBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundModuleBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/IndentationConsistency has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/IndentationWidth has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAfterColon has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAfterComma has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundEqualsInParameterDefault has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundKeyword has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundOperators has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceBeforeFirstArg has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceBeforeBlockBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideBlockBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideHashLiteralBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideParens has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/Tab has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/TrailingBlankLines has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/TrailingWhitespace has the wrong namespace - should be Layout ```
2017-05-24 18:33:50 +00:00
Layout/IndentationWidth:
Add a new rule to rubocop
2016-07-20 03:35:11 +00:00
Enabled: true
Enable a few more rubocop rules
2016-07-17 07:10:45 +00:00
Enable `Layout/LeadingCommentSpace` to not allow cosmetic changes in the future Follow up of #31432.
2017-12-14 08:30:54 +00:00
Layout/LeadingCommentSpace:
Enabled: true
rubocop namespace changes from `Style` to `Layout` Refer https://github.com/bbatsov/rubocop/pull/4278/commits/54166bf76ba76b14f1bbc8a34165f175dbc3f227 for the commit ``` /path/to/rails/.rubocop.yml: Style/CaseIndentation has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/CommentIndentation has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLines has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundClassBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundMethodBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundModuleBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/IndentationConsistency has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/IndentationWidth has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAfterColon has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAfterComma has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundEqualsInParameterDefault has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundKeyword has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundOperators has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceBeforeFirstArg has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceBeforeBlockBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideBlockBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideHashLiteralBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideParens has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/Tab has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/TrailingBlankLines has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/TrailingWhitespace has the wrong namespace - should be Layout ```
2017-05-24 18:33:50 +00:00
Layout/SpaceAfterColon:
Add more rubocop rules about whitespaces
2016-10-29 03:05:58 +00:00
Enabled: true
rubocop namespace changes from `Style` to `Layout` Refer https://github.com/bbatsov/rubocop/pull/4278/commits/54166bf76ba76b14f1bbc8a34165f175dbc3f227 for the commit ``` /path/to/rails/.rubocop.yml: Style/CaseIndentation has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/CommentIndentation has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLines has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundClassBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundMethodBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundModuleBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/IndentationConsistency has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/IndentationWidth has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAfterColon has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAfterComma has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundEqualsInParameterDefault has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundKeyword has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundOperators has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceBeforeFirstArg has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceBeforeBlockBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideBlockBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideHashLiteralBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideParens has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/Tab has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/TrailingBlankLines has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/TrailingWhitespace has the wrong namespace - should be Layout ```
2017-05-24 18:33:50 +00:00
Layout/SpaceAfterComma:
Add more rubocop rules about whitespaces
2016-10-29 03:05:58 +00:00
Enabled: true
Enable `Layout/SpaceAfterSemicolon` cop to avoid newly adding odd spacing Ref https://github.com/rails/rails/commit/59ff1ba30d9f4d34b4d478104cc3f453e553c67a#diff-38fb97fba84b1ef0f311c4110a597c44R35
2018-12-07 23:11:38 +00:00
Layout/SpaceAfterSemicolon:
Enabled: true
rubocop namespace changes from `Style` to `Layout` Refer https://github.com/bbatsov/rubocop/pull/4278/commits/54166bf76ba76b14f1bbc8a34165f175dbc3f227 for the commit ``` /path/to/rails/.rubocop.yml: Style/CaseIndentation has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/CommentIndentation has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLines has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundClassBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundMethodBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundModuleBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/IndentationConsistency has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/IndentationWidth has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAfterColon has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAfterComma has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundEqualsInParameterDefault has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundKeyword has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundOperators has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceBeforeFirstArg has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceBeforeBlockBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideBlockBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideHashLiteralBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideParens has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/Tab has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/TrailingBlankLines has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/TrailingWhitespace has the wrong namespace - should be Layout ```
2017-05-24 18:33:50 +00:00
Layout/SpaceAroundEqualsInParameterDefault:
Add more rubocop rules about whitespaces
2016-10-29 03:05:58 +00:00
Enabled: true
rubocop namespace changes from `Style` to `Layout` Refer https://github.com/bbatsov/rubocop/pull/4278/commits/54166bf76ba76b14f1bbc8a34165f175dbc3f227 for the commit ``` /path/to/rails/.rubocop.yml: Style/CaseIndentation has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/CommentIndentation has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLines has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundClassBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundMethodBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundModuleBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/IndentationConsistency has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/IndentationWidth has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAfterColon has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAfterComma has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundEqualsInParameterDefault has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundKeyword has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundOperators has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceBeforeFirstArg has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceBeforeBlockBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideBlockBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideHashLiteralBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideParens has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/Tab has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/TrailingBlankLines has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/TrailingWhitespace has the wrong namespace - should be Layout ```
2017-05-24 18:33:50 +00:00
Layout/SpaceAroundKeyword:
Add more rubocop rules about whitespaces
2016-10-29 03:05:58 +00:00
Enabled: true
Re-enable `Layout/SpaceAroundOperators` cop We prefer space around operators, but `Layout/SpaceAroundOperators` cop was temporarily disabled in #36943 since that cop changed to check alignment strictly somehow. In RuboCop 1.0.0, that is fixed by https://github.com/rubocop-hq/rubocop/pull/8906. Related https://github.com/rails/rails/pull/38034#discussion_r359845661, https://github.com/rails/rails/pull/39770#discussion_r448829561.
2020-10-22 07:12:38 +00:00
Layout/SpaceAroundOperators:
Enabled: true
Enable `Layout/SpaceBeforeComma` rubocop rule, and fixed more Follow up of #31390.
2017-12-12 11:00:50 +00:00
Layout/SpaceBeforeComma:
Enable `Layout/SpaceAfterSemicolon` cop to avoid newly adding odd spacing Ref https://github.com/rails/rails/commit/59ff1ba30d9f4d34b4d478104cc3f453e553c67a#diff-38fb97fba84b1ef0f311c4110a597c44R35
2018-12-07 23:11:38 +00:00
Enabled: true
Enable `Layout/SpaceBeforeComma` rubocop rule, and fixed more Follow up of #31390.
2017-12-12 11:00:50 +00:00
Layout/SpaceBeforeComment Enabled: true
2019-04-11 16:20:25 +00:00
Layout/SpaceBeforeComment:
Enabled: true
rubocop namespace changes from `Style` to `Layout` Refer https://github.com/bbatsov/rubocop/pull/4278/commits/54166bf76ba76b14f1bbc8a34165f175dbc3f227 for the commit ``` /path/to/rails/.rubocop.yml: Style/CaseIndentation has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/CommentIndentation has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLines has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundClassBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundMethodBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundModuleBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/IndentationConsistency has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/IndentationWidth has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAfterColon has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAfterComma has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundEqualsInParameterDefault has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundKeyword has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundOperators has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceBeforeFirstArg has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceBeforeBlockBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideBlockBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideHashLiteralBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideParens has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/Tab has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/TrailingBlankLines has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/TrailingWhitespace has the wrong namespace - should be Layout ```
2017-05-24 18:33:50 +00:00
Layout/SpaceBeforeFirstArg:
Enable `Layout/SpaceAfterSemicolon` cop to avoid newly adding odd spacing Ref https://github.com/rails/rails/commit/59ff1ba30d9f4d34b4d478104cc3f453e553c67a#diff-38fb97fba84b1ef0f311c4110a597c44R35
2018-12-07 23:11:38 +00:00
Enabled: true
Add more rubocop rules about whitespaces
2016-10-29 03:05:58 +00:00
Enable `Style/DefWithParentheses` rubocop rule The def with blank `()` was newly added in #31176, but we have not used the blank `()` style in most part of our code base. So I've enabled `Style/DefWithParentheses` to prevent to newly added the code.
2017-11-27 06:16:12 +00:00
Style/DefWithParentheses:
Enabled: true
adds a few cops and sorts
2016-08-06 15:45:37 +00:00
# Defining a method with parameters needs parentheses.
Style/MethodDefParentheses:
Enabled: true
Enable `Style/ExplicitBlockArgument` cop This reduce the stack size which is beneficial for exceptions performance. See: https://gist.github.com/byroot/cb3bcadcc3701c2518d002fb8d3a4e7a However the cop is unsafe because it might change the block arity, so it can run into some false positives.
2021-09-05 14:29:32 +00:00
Style/ExplicitBlockArgument:
Enabled: true
Use frozen-string-literal in ActiveSupport
2017-07-09 12:06:36 +00:00
Style/FrozenStringLiteralComment:
Enabled: true
EnforcedStyle: always
Use frozen string literal in actionview/
2017-07-23 15:36:41 +00:00
Exclude:
- 'actionview/test/**/*.builder'
- 'actionview/test/**/*.ruby'
Use frozen string literal in actionpack/
2017-07-24 20:20:53 +00:00
- 'actionpack/test/**/*.builder'
- 'actionpack/test/**/*.ruby'
Remove frozen_string_literal comment from activestorage's migration The activestorage's migration is used as template for apps Related to #30348
2017-08-22 05:32:27 +00:00
- 'activestorage/db/migrate/**/*.rb'
Add foreign key to active_storage_attachments for `blob_id` via new migration We need this in order to be able to add this migration for users that use ActiveStorage during update their apps from Rails 5.2 to Rails 6.0. Related to #33405 `rake app:update` should update active_storage `rake app:update` should execute `rake active_storage:update` if it is used in the app that is being updated. It will add new active_storage's migrations to users' apps during update Rails. Context https://github.com/rails/rails/pull/33405#discussion_r204239399 Also, see a related discussion in the Campfire: https://3.basecamp.com/3076981/buckets/24956/chats/12416418@1236713081
2018-07-23 00:33:25 +00:00
- 'activestorage/db/update_migrate/**/*.rb'
Import Action Mailbox
2018-12-24 20:16:22 +00:00
- 'actionmailbox/db/migrate/**/*.rb'
Import Action Text
2019-01-05 00:43:11 +00:00
- 'actiontext/db/migrate/**/*.rb'
Use frozen-string-literal in ActiveSupport
2017-07-09 12:06:36 +00:00
Enable `Style/MapToHash` cop Ruby 2.6 added block argument processing to `Enumerable#to_h`. https://bugs.ruby-lang.org/issues/15143 Rails 7 requires Ruby 2.7.0 or higher, so the new feature can use it. `Style/MapToHash` cop will detect it. And this cop in the `Style` department, but this seems to improve performance as follows: ```ruby # map_to_hash.rb require 'benchmark/ips' ARRAY = (1..100).to_a HASH = {foo: 1, bar: 2} Benchmark.ips do |x| x.report('array.map.to_h') { ARRAY.map { |v| [v, v * 2] }.to_h } x.report('array.to_h') { ARRAY.to_h { |v| [v, v * 2] } } x.compare! end Benchmark.ips do |x| x.report('hash.map.to_h') { HASH.map { |k, v| [k.to_s, v * 2] }.to_h } x.report('hash.to_h') { HASH.to_h { |k, v| [k.to_s, v * 2] } } x.compare! end ``` ```console % ruby map_to_hash.rb Warming up -------------------------------------- array.map.to_h 9.063k i/100ms array.to_h 9.609k i/100ms Calculating ------------------------------------- array.map.to_h 89.063k (± 3.9%) i/s - 453.150k in 5.096572s array.to_h 96.449k (± 1.7%) i/s - 490.059k in 5.082529s Comparison: array.to_h: 96448.7 i/s array.map.to_h: 89063.4 i/s - 1.08x (± 0.00) slower Warming up -------------------------------------- hash.map.to_h 106.284k i/100ms hash.to_h 149.354k i/100ms Calculating ------------------------------------- hash.map.to_h 1.102M (± 2.2%) i/s - 5.527M in 5.019657s hash.to_h 1.490M (± 0.9%) i/s - 7.468M in 5.013264s Comparison: hash.to_h: 1489707.0 i/s hash.map.to_h: 1101561.5 i/s - 1.35x (± 0.00) slower ``` `Style/MapToHash` cop ... https://docs.rubocop.org/rubocop/1.25/cops_style.html#stylemaptohash
2022-02-25 17:45:24 +00:00
Style/MapToHash:
Enabled: true
Add `Style/RedundantFreeze` to remove redudant `.freeze` Since Rails 6.0 will support Ruby 2.4.1 or higher `# frozen_string_literal: true` magic comment is enough to make string object frozen. This magic comment is enabled by `Style/FrozenStringLiteralComment` cop. * Exclude these files not to auto correct false positive `Regexp#freeze` - 'actionpack/lib/action_dispatch/journey/router/utils.rb' - 'activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb' It has been fixed by https://github.com/rubocop-hq/rubocop/pull/6333 Once the newer version of RuboCop released and available at Code Climate these exclude entries should be removed. * Replace `String#freeze` with `String#-@` manually if explicit frozen string objects are required - 'actionpack/test/controller/test_case_test.rb' - 'activemodel/test/cases/type/string_test.rb' - 'activesupport/lib/active_support/core_ext/string/strip.rb' - 'activesupport/test/core_ext/string_ext_test.rb' - 'railties/test/generators/actions_test.rb'
2018-02-28 04:33:37 +00:00
Style/RedundantFreeze:
Enabled: true
Add three new rubocop rules Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository.
2016-08-16 07:30:11 +00:00
# Use `foo {}` not `foo{}`.
rubocop namespace changes from `Style` to `Layout` Refer https://github.com/bbatsov/rubocop/pull/4278/commits/54166bf76ba76b14f1bbc8a34165f175dbc3f227 for the commit ``` /path/to/rails/.rubocop.yml: Style/CaseIndentation has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/CommentIndentation has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLines has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundClassBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundMethodBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundModuleBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/IndentationConsistency has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/IndentationWidth has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAfterColon has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAfterComma has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundEqualsInParameterDefault has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundKeyword has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundOperators has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceBeforeFirstArg has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceBeforeBlockBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideBlockBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideHashLiteralBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideParens has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/Tab has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/TrailingBlankLines has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/TrailingWhitespace has the wrong namespace - should be Layout ```
2017-05-24 18:33:50 +00:00
Layout/SpaceBeforeBlockBraces:
Add three new rubocop rules Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository.
2016-08-16 07:30:11 +00:00
Enabled: true
# Use `foo { bar }` not `foo {bar}`.
rubocop namespace changes from `Style` to `Layout` Refer https://github.com/bbatsov/rubocop/pull/4278/commits/54166bf76ba76b14f1bbc8a34165f175dbc3f227 for the commit ``` /path/to/rails/.rubocop.yml: Style/CaseIndentation has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/CommentIndentation has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLines has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundClassBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundMethodBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundModuleBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/IndentationConsistency has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/IndentationWidth has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAfterColon has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAfterComma has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundEqualsInParameterDefault has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundKeyword has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundOperators has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceBeforeFirstArg has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceBeforeBlockBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideBlockBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideHashLiteralBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideParens has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/Tab has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/TrailingBlankLines has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/TrailingWhitespace has the wrong namespace - should be Layout ```
2017-05-24 18:33:50 +00:00
Layout/SpaceInsideBlockBraces:
Add three new rubocop rules Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository.
2016-08-16 07:30:11 +00:00
Enabled: true
Change the empty block style to have space inside of the block
2018-09-25 17:18:20 +00:00
EnforcedStyleForEmptyBraces: space
Add three new rubocop rules Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository.
2016-08-16 07:30:11 +00:00
# Use `{ a: 1 }` not `{a:1}`.
rubocop namespace changes from `Style` to `Layout` Refer https://github.com/bbatsov/rubocop/pull/4278/commits/54166bf76ba76b14f1bbc8a34165f175dbc3f227 for the commit ``` /path/to/rails/.rubocop.yml: Style/CaseIndentation has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/CommentIndentation has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLines has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundClassBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundMethodBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundModuleBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/IndentationConsistency has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/IndentationWidth has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAfterColon has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAfterComma has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundEqualsInParameterDefault has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundKeyword has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundOperators has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceBeforeFirstArg has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceBeforeBlockBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideBlockBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideHashLiteralBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideParens has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/Tab has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/TrailingBlankLines has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/TrailingWhitespace has the wrong namespace - should be Layout ```
2017-05-24 18:33:50 +00:00
Layout/SpaceInsideHashLiteralBraces:
Add three new rubocop rules Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository.
2016-08-16 07:30:11 +00:00
Enabled: true
rubocop namespace changes from `Style` to `Layout` Refer https://github.com/bbatsov/rubocop/pull/4278/commits/54166bf76ba76b14f1bbc8a34165f175dbc3f227 for the commit ``` /path/to/rails/.rubocop.yml: Style/CaseIndentation has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/CommentIndentation has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLines has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundClassBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundMethodBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundModuleBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/IndentationConsistency has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/IndentationWidth has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAfterColon has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAfterComma has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundEqualsInParameterDefault has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundKeyword has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundOperators has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceBeforeFirstArg has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceBeforeBlockBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideBlockBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideHashLiteralBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideParens has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/Tab has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/TrailingBlankLines has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/TrailingWhitespace has the wrong namespace - should be Layout ```
2017-05-24 18:33:50 +00:00
Layout/SpaceInsideParens:
Add more rubocop rules about whitespaces
2016-10-29 03:05:58 +00:00
Enabled: true
adds a few cops and sorts
2016-08-06 15:45:37 +00:00
# Check quotes usage according to lint rule below.
Style/StringLiterals:
Enabled: true
EnforcedStyle: double_quotes
# Detect hard tabs, no hard tabs.
Bump rubocop to 0.82 (#38980) * Bump rubocop to 0.82 The `Layout/Tab` cop has been renamed to `Layout/IndentationStyle` ref: https://github.com/rubocop-hq/rubocop/releases/tag/v0.82.0 No other code changes required. * Bump rubocop-rails to 2.5.2 No code-changes required. [Tejas Bubane + Rafael Mendonça França]
2020-04-17 18:24:33 +00:00
Layout/IndentationStyle:
adds a few cops and sorts
2016-08-06 15:45:37 +00:00
Enabled: true
Bump RuboCop version to 0.77 https://github.com/rubocop-hq/rubocop/releases/tag/v0.77.0 * Update cop names to changed as follows: ``` $ bundle exec rubocop Error: The `Layout/IndentFirstArgument` cop has been renamed to `Layout/FirstArgumentIndentation`. (obsolete configuration found in .rubocop.yml, please update it) The `Layout/TrailingBlankLines` cop has been renamed to `Layout/TrailingEmptyLines`. (obsolete configuration found in .rubocop.yml, please update it) The `Lint/StringConversionInInterpolation` cop has been renamed to `Lint/RedundantStringCoercion`. (obsolete configuration found in .rubocop.yml, please update it) $ ``` * Auto correct these offenses: ``` $ bundle exec rubocop -a ... snip ... Offenses: activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb:104:11: C: [Corrected] Style/RedundantReturn: Redundant return detected. return true ^^^^^^ activerecord/lib/active_record/reflection.rb:622:15: C: [Corrected] Style/RedundantReturn: Redundant return detected. return inverse_name ^^^^^^ activerecord/lib/active_record/table_metadata.rb:48:9: C: [Corrected] Style/RedundantReturn: Redundant return detected. return self ^^^^^^ 2812 files inspected, 3 offenses detected, 3 offenses corrected $ ```
2019-11-27 23:53:47 +00:00
# Empty lines should not have any spaces.
Layout/TrailingEmptyLines:
adds a few cops and sorts
2016-08-06 15:45:37 +00:00
Enabled: true
# No trailing whitespace.
rubocop namespace changes from `Style` to `Layout` Refer https://github.com/bbatsov/rubocop/pull/4278/commits/54166bf76ba76b14f1bbc8a34165f175dbc3f227 for the commit ``` /path/to/rails/.rubocop.yml: Style/CaseIndentation has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/CommentIndentation has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLines has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundClassBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundMethodBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/EmptyLinesAroundModuleBody has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/IndentationConsistency has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/IndentationWidth has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAfterColon has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAfterComma has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundEqualsInParameterDefault has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundKeyword has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceAroundOperators has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceBeforeFirstArg has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceBeforeBlockBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideBlockBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideHashLiteralBraces has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/SpaceInsideParens has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/Tab has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/TrailingBlankLines has the wrong namespace - should be Layout /path/to/rails/.rubocop.yml: Style/TrailingWhitespace has the wrong namespace - should be Layout ```
2017-05-24 18:33:50 +00:00
Layout/TrailingWhitespace:
adds a few cops and sorts
2016-08-06 15:45:37 +00:00
Enabled: true
# Use quotes for string literals when they are enough.
Enabled GitHub Actions to run the latest RuboCop 0.76.0 Updated the default Ruby workflow: * Trigger this action for pull request and push * Install requried OS packages for Active Record connection adapters * Removing `gem install bundler` because Ruby 2.6 already installs it * Run RuboCop in parallel by `bundle exec rubocop --parallel` * Rename `ruby.yml` to `rubocop.yml` to represent the workflow Bump RuboCop to 0.76.0 and rename `Style/UnneededPercentQ` to `Style/RedundantPercentQ` ```ruby $ bundle exec rubocop Error: The `Style/UnneededPercentQ` cop has been renamed to `Style/RedundantPercentQ`. (obsolete configuration found in .rubocop.yml ``` Removed `.codeclimate.yml`
2019-08-20 12:52:53 +00:00
Style/RedundantPercentQ:
Add a new rule to rubocop
2016-07-20 03:35:11 +00:00
Enabled: true
Enable `Lint/AmbiguousOperator` and `Lint/AmbiguousRegexpLiteral` cops To avoid newly adding the warnings, which are frequently addressed. ac721c855203ac7570545c0e85fe086f8e94d94a 951383bd9afa4a71c17e56d1d4eb5866da851483 8a0f235fd3bd3f3c813fa7034c6d741831e55c3e c33c03e80cbe9f27274b45fe55f93bad3af988fb 424b2019830ea4c08e86ba9ff9600aa23a54cb4f
2019-03-06 01:01:33 +00:00
Lint/AmbiguousOperator:
Enabled: true
Lint/AmbiguousRegexpLiteral:
Enabled: true
Enable `Lint/DuplicateRequire` cop Closes #40644. Co-authored-by: luccafort <konishi.tatsuro@moneyforward.co.jp>
2021-01-09 05:40:47 +00:00
Lint/DuplicateRequire:
Enabled: true
Enable `Lint/DuplicateMagicComment` cop This PR enables `Lint/DuplicateMagicComment` cop to resolve the background of https://github.com/rubocop/rubocop/issues/11043. And this PR bumps RuboCop version because the cop was introduced in RuboCop 1.37.0: https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md#1370-2022-10-20
2022-11-14 06:58:38 +00:00
Lint/DuplicateMagicComment:
Enabled: true
Enable Lint/DuplicateMethods rubocop rule
2021-11-15 18:51:28 +00:00
Lint/DuplicateMethods:
Enabled: true
Enable `Lint/ErbNewArguments` cop to avoid the deprecated arguments warning Related 5754a29a974d31cab2b4392716b9825a3d910a69. And follows Ruby standard library style https://github.com/ruby/ruby/commit/3406c5d.
2019-02-01 05:16:55 +00:00
Lint/ErbNewArguments:
Enabled: true
Enable Performance/OpenStruct
2022-02-17 22:16:42 +00:00
Enable Lint/EnsureReturn cop
2022-02-05 23:51:03 +00:00
Lint/EnsureReturn:
Enabled: true
Enable `Lint/ErbNewArguments` cop to avoid the deprecated arguments warning Related 5754a29a974d31cab2b4392716b9825a3d910a69. And follows Ruby standard library style https://github.com/ruby/ruby/commit/3406c5d.
2019-02-01 05:16:55 +00:00
adds a few cops and sorts
2016-08-06 15:45:37 +00:00
# Use my_method(my_arg) not my_method( my_arg ) or my_method my_arg.
Lint/RequireParentheses:
Enabled: true
Merge pull request #31005 from shuheiktgw/remove_unnecessary_semicolons Removed unnecessary semicolons
2017-10-28 12:15:34 +00:00
Bump RuboCop version to 0.77 https://github.com/rubocop-hq/rubocop/releases/tag/v0.77.0 * Update cop names to changed as follows: ``` $ bundle exec rubocop Error: The `Layout/IndentFirstArgument` cop has been renamed to `Layout/FirstArgumentIndentation`. (obsolete configuration found in .rubocop.yml, please update it) The `Layout/TrailingBlankLines` cop has been renamed to `Layout/TrailingEmptyLines`. (obsolete configuration found in .rubocop.yml, please update it) The `Lint/StringConversionInInterpolation` cop has been renamed to `Lint/RedundantStringCoercion`. (obsolete configuration found in .rubocop.yml, please update it) $ ``` * Auto correct these offenses: ``` $ bundle exec rubocop -a ... snip ... Offenses: activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb:104:11: C: [Corrected] Style/RedundantReturn: Redundant return detected. return true ^^^^^^ activerecord/lib/active_record/reflection.rb:622:15: C: [Corrected] Style/RedundantReturn: Redundant return detected. return inverse_name ^^^^^^ activerecord/lib/active_record/table_metadata.rb:48:9: C: [Corrected] Style/RedundantReturn: Redundant return detected. return self ^^^^^^ 2812 files inspected, 3 offenses detected, 3 offenses corrected $ ```
2019-11-27 23:53:47 +00:00
Lint/RedundantStringCoercion:
Enable `Lint/StringConversionInInterpolation` rubocop rule To prevent redundant `to_s` like https://github.com/rails/rails/pull/32923#discussion_r189460008 automatically in the future.
2018-05-21 12:04:01 +00:00
Enabled: true
Enable Lint/UriEscapeUnescape cop not to allow using obsolete methods in the future Follow up #33627.
2018-08-16 04:05:05 +00:00
Lint/UriEscapeUnescape:
Enabled: true
Add back Lint/UselessAssignment Fix: #43169
2021-09-06 14:24:37 +00:00
Lint/UselessAssignment:
Enabled: true
Enable `Lint/DeprecatedClassMethods` cop to avoid using deprecated methods
2019-01-09 03:00:08 +00:00
Lint/DeprecatedClassMethods:
Enabled: true
Enable Style/ParenthesesAroundCondition cop To prevent style check in review like https://github.com/rails/rails/pull/33608#discussion_r211087605.
2018-08-18 23:12:05 +00:00
Style/ParenthesesAroundCondition:
Enabled: true
Enable HashTransformKeys and HashTransformValues cops Followup to 88fe76e69328d38942130e16fb65f4aa1b5d1a6b. These are new in RuboCop 0.80.0, and enforce a style we already prefer for performance reasons (see df81f2e5f5df46c9c1db27530bbd301b6e23c4a7).
2020-02-20 22:37:32 +00:00
Style/HashTransformKeys:
Enabled: true
Style/HashTransformValues:
Enabled: true
Enable `Style/RedundantBegin` cop to avoid newly adding redundant begin block Currently we sometimes find a redundant begin block in code review (e.g. https://github.com/rails/rails/pull/33604#discussion_r209784205). I'd like to enable `Style/RedundantBegin` cop to avoid that, since rescue/else/ensure are allowed inside do/end blocks in Ruby 2.5 (https://bugs.ruby-lang.org/issues/12906), so we'd probably meets with that situation than before.
2018-12-20 17:44:01 +00:00
Style/RedundantBegin:
Enabled: true
Enable `Style/RedundantReturn` rubocop rule, and fixed a couple more Follow up of #31004.
2017-10-31 22:32:04 +00:00
Style/RedundantReturn:
Enabled: true
AllowMultipleReturnValues: true
feat(rubocop): Add Style/RedundantRegexpEscape - This cop will help in removing unnecessary escaping inside Regexp literals.
2020-09-07 11:13:53 +00:00
Style/RedundantRegexpEscape:
Enabled: true
Merge pull request #31005 from shuheiktgw/remove_unnecessary_semicolons Removed unnecessary semicolons
2017-10-28 12:15:34 +00:00
Style/Semicolon:
Enabled: true
AllowAsExpressionSeparator: true
Add cop for preferring 'Foo.method' over 'Foo::method'
2018-02-22 06:26:48 +00:00
# Prefer Foo.method over Foo::method
Style/ColonMethodCall:
Enabled: true
Turn on performance based cops Use attr_reader/attr_writer instead of methods method is 12% slower Use flat_map over map.flatten(1) flatten is 66% slower Use hash[]= instead of hash.merge! with single arguments merge! is 166% slower See https://github.com/rails/rails/pull/32337 for more conversation
2018-03-30 02:29:55 +00:00
Style/TrivialAccessors:
Enabled: true
Enable `Style/RedundantCondition` cop
2022-07-20 19:25:23 +00:00
# Prefer a = b || c over a = b ? b : c
Style/RedundantCondition:
Enabled: true
Use `bind_call(obj, ...)` instead of `bind(obj).call(...)` `bind_call(obj, ...)` is a faster alternative to `bind(obj).call(...)`. https://bugs.ruby-lang.org/issues/15955 Also, enable `Performance/BindCall` cop to detect those in the future.
2021-02-08 07:57:53 +00:00
Performance/BindCall:
Enabled: true
Turn on performance based cops Use attr_reader/attr_writer instead of methods method is 12% slower Use flat_map over map.flatten(1) flatten is 66% slower Use hash[]= instead of hash.merge! with single arguments merge! is 166% slower See https://github.com/rails/rails/pull/32337 for more conversation
2018-03-30 02:29:55 +00:00
Performance/FlatMap:
Enabled: true
Enable `Performance/MapCompact` cop Follow up to #42053.
2021-04-23 07:31:19 +00:00
Performance/MapCompact:
Enabled: true
use ruby 2.7's filter_map instead of select + map Related: c3d7794, bbbc861
2021-04-26 21:55:33 +00:00
Performance/SelectMap:
Enabled: true
Turn on performance based cops Use attr_reader/attr_writer instead of methods method is 12% slower Use flat_map over map.flatten(1) flatten is 66% slower Use hash[]= instead of hash.merge! with single arguments merge! is 166% slower See https://github.com/rails/rails/pull/32337 for more conversation
2018-03-30 02:29:55 +00:00
Performance/RedundantMerge:
Enabled: true
Enable Start/EndWith and RegexpMatch cops In cases where the MatchData object is not used, this provides a speed-up: https://github.com/JuanitoFatas/fast-ruby/#stringmatch-vs-stringmatch-vs-stringstart_withstringend_with-code-start-code-end
2018-07-28 21:37:17 +00:00
Performance/StartWith:
Enabled: true
Performance/EndWith:
Enabled: true
Performance/RegexpMatch:
Enabled: true
Enable `Performance/UnfreezeString` cop In Ruby 2.3 or later, `String#+@` is available and `+@` is faster than `dup`. ```ruby # frozen_string_literal: true require "bundler/inline" gemfile(true) do source "https://rubygems.org" gem "benchmark-ips" end Benchmark.ips do |x| x.report('+@') { +"" } x.report('dup') { "".dup } x.compare! end ``` ``` $ ruby -v benchmark.rb ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-linux] Warming up -------------------------------------- +@ 282.289k i/100ms dup 187.638k i/100ms Calculating ------------------------------------- +@ 6.775M (± 3.6%) i/s - 33.875M in 5.006253s dup 3.320M (± 2.2%) i/s - 16.700M in 5.032125s Comparison: +@: 6775299.3 i/s dup: 3320400.7 i/s - 2.04x slower ```
2018-05-17 08:32:27 +00:00
Enable `Performance/ReverseEach` cop to avoid newly adding `reverse.each` https://github.com/rails/rails/pull/35451#discussion_r262746834
2019-03-06 00:31:55 +00:00
Performance/ReverseEach:
Enabled: true
Enable `Performance/StringReplacement` cop Follow up to #42054.
2021-04-23 07:15:32 +00:00
Performance/StringReplacement:
Enabled: true
Enable `Performance/UnfreezeString` cop In Ruby 2.3 or later, `String#+@` is available and `+@` is faster than `dup`. ```ruby # frozen_string_literal: true require "bundler/inline" gemfile(true) do source "https://rubygems.org" gem "benchmark-ips" end Benchmark.ips do |x| x.report('+@') { +"" } x.report('dup') { "".dup } x.compare! end ``` ``` $ ruby -v benchmark.rb ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-linux] Warming up -------------------------------------- +@ 282.289k i/100ms dup 187.638k i/100ms Calculating ------------------------------------- +@ 6.775M (± 3.6%) i/s - 33.875M in 5.006253s dup 3.320M (± 2.2%) i/s - 16.700M in 5.032125s Comparison: +@: 6775299.3 i/s dup: 3320400.7 i/s - 2.04x slower ```
2018-05-17 08:32:27 +00:00
Performance/UnfreezeString:
Enabled: true
Update rubocop-performance gem and enable Performance/DeletePrefix and Performance/DeleteSuffix cops
2020-05-24 00:23:46 +00:00
Performance/DeletePrefix:
Enabled: true
Performance/DeleteSuffix:
Enabled: true
Tweak unreachable assertion tests in the block of `assert_raises` I found an unexpected use of assertion in the block of `assert_raise` when I implemented https://github.com/rubocop/rubocop-minitest/pull/137. It is expected to be asserted after an exception is raised in `assert_raise` block, but in actually it is not asserted after an exception is raised. Therefore, this PR removes or updates assertions that have not been asserted after an exception has raised. This PR will add `rubocop-minitest` and enable `Minitest/UnreachableAssertion` cop to able similar auto-detection, but will remove `rubocop-minitest` from this PR if you don't like it.
2021-06-24 10:46:21 +00:00
Enable Performance/OpenStruct
2022-02-17 22:16:42 +00:00
Performance/OpenStruct:
Enabled: true
Update `rubocop-performance` and enable more performance-related cops
2022-08-26 12:03:38 +00:00
Performance/InefficientHashSearch:
Enabled: true
Performance/ConstantRegexp:
Enabled: true
Performance/RedundantStringChars:
Enabled: true
Performance/StringInclude:
Enabled: true
Enable `Minitest/AssertRaisesWithRegexpArgument` cop Follow up #45965. The commit to enable `Minitest/AssertRaisesWithRegexpArgument` cop was forgotten.
2022-09-08 09:20:01 +00:00
Minitest/AssertRaisesWithRegexpArgument:
Enabled: true
fix remaining asserts that should be assert_equal Found using Minitest/AssertWithExpectedArgument. Also enabled the rule per feedback and fixed 29 additional violations
2022-02-25 02:53:41 +00:00
Minitest/AssertWithExpectedArgument:
Enabled: true
Enable Minitest/SkipEnsure I believe this was supposed to be included in 1b736a8
2022-09-21 01:20:17 +00:00
Minitest/SkipEnsure:
Enabled: true
Tweak unreachable assertion tests in the block of `assert_raises` I found an unexpected use of assertion in the block of `assert_raise` when I implemented https://github.com/rubocop/rubocop-minitest/pull/137. It is expected to be asserted after an exception is raised in `assert_raise` block, but in actually it is not asserted after an exception is raised. Therefore, this PR removes or updates assertions that have not been asserted after an exception has raised. This PR will add `rubocop-minitest` and enable `Minitest/UnreachableAssertion` cop to able similar auto-detection, but will remove `rubocop-minitest` from this PR if you don't like it.
2021-06-24 10:46:21 +00:00
Minitest/UnreachableAssertion:
Enabled: true