From 2290fce88baa32b3045b4ff14333a57a896576ec Mon Sep 17 00:00:00 2001
From: Alex Kotov <kotovalexarian@gmail.com>
Date: Mon, 30 May 2022 13:02:16 +0300
Subject: [PATCH] mruby: fix code style

---
 pkgs/mruby/.rubocop.yml |  4 ++
 pkgs/mruby/test/ntoa.rb | 82 +++++++++--------------------------------
 2 files changed, 22 insertions(+), 64 deletions(-)

diff --git a/pkgs/mruby/.rubocop.yml b/pkgs/mruby/.rubocop.yml
index 47331f5..770d679 100644
--- a/pkgs/mruby/.rubocop.yml
+++ b/pkgs/mruby/.rubocop.yml
@@ -45,6 +45,10 @@ Style/FrozenStringLiteralComment:
 Style/HashAsLastArrayItem:
   Enabled: false
 
+Style/NumericPredicate:
+  # Numeric#negative? is not available in mruby
+  Enabled: false
+
 Style/PerlBackrefs:
   Enabled: false
 
diff --git a/pkgs/mruby/test/ntoa.rb b/pkgs/mruby/test/ntoa.rb
index 0236028..62f3d1c 100644
--- a/pkgs/mruby/test/ntoa.rb
+++ b/pkgs/mruby/test/ntoa.rb
@@ -1,89 +1,43 @@
+def common_assert(expected, result)
+  assert_true result.instance_of? String
+  assert_true result.frozen?
+  assert_equal expected, result
+end
+
 def test_utoa(number, base, expected)
-  result = KernAux.utoa(number, base)
-
-  assert_true result.instance_of? String
-  assert_true result.frozen?
-  assert_equal expected, result
-
-  result = KernAux.utoa(number, base, nil)
-
-  assert_true result.instance_of? String
-  assert_true result.frozen?
-  assert_equal expected, result
-
-  result = KernAux.utoa(number, base, '')
-
-  assert_true result.instance_of? String
-  assert_true result.frozen?
-  assert_equal expected, result
+  common_assert expected, KernAux.utoa(number, base)
+  common_assert expected, KernAux.utoa(number, base, nil)
+  common_assert expected, KernAux.utoa(number, base, '')
 end
 
 def test_itoa(number, base, expected)
-  result = KernAux.itoa(number, base)
-
-  assert_true result.instance_of? String
-  assert_true result.frozen?
-  assert_equal expected, result
-
-  result = KernAux.itoa(number, base, nil)
-
-  assert_true result.instance_of? String
-  assert_true result.frozen?
-  assert_equal expected, result
-
-  result = KernAux.itoa(number, base, '')
-
-  assert_true result.instance_of? String
-  assert_true result.frozen?
-  assert_equal expected, result
+  common_assert expected, KernAux.itoa(number, base)
+  common_assert expected, KernAux.itoa(number, base, nil)
+  common_assert expected, KernAux.itoa(number, base, '')
 end
 
 def test_utoax(number, base, prefix, expected)
-  result = KernAux.utoa(number, base, prefix)
-
-  assert_true result.instance_of? String
-  assert_true result.frozen?
-  assert_equal expected, result
+  common_assert expected, KernAux.utoa(number, base, prefix)
 end
 
 def test_itoax(number, base, prefix, expected)
-  result = KernAux.itoa(number, base, prefix)
-
-  assert_true result.instance_of? String
-  assert_true result.frozen?
-  assert_equal expected, result
+  common_assert expected, KernAux.itoa(number, base, prefix)
 end
 
 def test_utoa10(number, expected)
-  result = KernAux.utoa10(number)
-
-  assert_true result.instance_of? String
-  assert_true result.frozen?
-  assert_equal expected, result
+  common_assert expected, KernAux.utoa10(number)
 end
 
 def test_itoa10(number, expected)
-  result = KernAux.itoa10(number)
-
-  assert_true result.instance_of? String
-  assert_true result.frozen?
-  assert_equal expected, result
+  common_assert expected, KernAux.itoa10(number)
 end
 
 def test_utoa16(number, expected)
-  result = KernAux.utoa16(number)
-
-  assert_true result.instance_of? String
-  assert_true result.frozen?
-  assert_equal expected, result
+  common_assert expected, KernAux.utoa16(number)
 end
 
 def test_itoa16(number, expected)
-  result = KernAux.itoa16(number)
-
-  assert_true result.instance_of? String
-  assert_true result.frozen?
-  assert_equal expected, result
+  common_assert expected, KernAux.itoa16(number)
 end
 
 assert 'KernAux.utoa' do