tailix
/
libkernaux
mirror of https://github.com/tailix/libkernaux.git
1
0
Fork 0
Code Releases Activity

Main: src/multiboot2/info_convert.c: Improve func "KernAux_Multiboot2_Info_to_memmap"

This commit is contained in:
Alex Kotov 2022-06-15 14:11:42 +03:00
parent edf6d1b36d
commit 49470c251c
Signed by: kotovalexarian
GPG Key ID: 553C0EBBEB5D5F08
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/multiboot2/info_convert.c
View File

@ -33,6 +33,10 @@ bool KernAux_Multiboot2_Info_to_memmap(
KERNAUX_MULTIBOOT2_ITAG_MEMORY_MAP
);
// FIXME: Basic memory info tag may not be provided by some boot loaders on
// EFI platforms if EFI boot services are enabled and available for the
// loaded image (EFI boot services not terminated tag exists in Multiboot2
// information structure).
if (basic_memory_info_tag_base == NULL || memory_map_tag_base == NULL) {
return false;
}
@ -46,7 +50,12 @@ bool KernAux_Multiboot2_Info_to_memmap(
(const struct KernAux_Multiboot2_ITag_MemoryMap*)
memory_map_tag_base;
(void)basic_memory_info_tag;
// FIXME: The value returned for upper memory is maximally the address of
// the first upper memory hole minus 1 megabyte. It is not guaranteed to be
// this value.
const size_t memory_size = (size_t)basic_memory_info_tag->mem_upper * 1024;
KernAux_MemMap_init(memmap, memory_size);
(void)memory_map_tag;
return false;