kotovalexarian-likes-github
/
active_record_union
mirror of https://github.com/brianhempel/active_record_union
1
0
Fork 0
Code Releases Activity

bah travis

This commit is contained in:
Brian Hempel 2019-04-02 14:52:13 -05:00
parent 19f1137329
commit 3cb6e38a12
3 changed files with 29 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
rails_5_1.gemfile
View File

@ -10,4 +10,4 @@ gem 'rails', '~> 5.1.0'
# https://bitbucket.org/ged/ruby-pg/issues/270/pg-100-x64-mingw32-rails-server-not-start # https://bitbucket.org/ged/ruby-pg/issues/270/pg-100-x64-mingw32-rails-server-not-start
gem 'pg', '~> 0.21' gem 'pg', '~> 0.21'
gem 'sqlite3', '~> 1.4.0' gem 'sqlite3', '~> 1.3.6'

2
rails_5_2.gemfile
View File

@ -7,4 +7,4 @@ gem 'rails', '~> 5.2.0'
gem 'pg' gem 'pg'
gem 'sqlite3', '~> 1.4.0' gem 'sqlite3', '~> 1.3.6'

36
spec/union_spec.rb
View File

@ -105,9 +105,15 @@ describe ActiveRecord::Relation do
context "in SQLite" do context "in SQLite" do
it "lets ORDER BY in query subselects throw a syntax error" do it "lets ORDER BY in query subselects throw a syntax error" do
expect(union.to_sql.squish).to eq( if ([ActiveRecord::VERSION::MAJOR, ActiveRecord::VERSION::MINOR] <=> [5, 2]) >= 0
"SELECT \"posts\".* FROM ( SELECT \"posts\".* FROM \"posts\" WHERE \"posts\".\"user_id\" = 1 ORDER BY \"posts\".\"created_at\" ASC UNION SELECT \"posts\".* FROM \"posts\" WHERE (created_at > '#{SQL_TIME}') ORDER BY \"posts\".\"created_at\" ASC ) \"posts\" ORDER BY \"posts\".\"created_at\" ASC" expect(union.to_sql.squish).to eq(
) "SELECT \"posts\".* FROM ( SELECT \"posts\".* FROM \"posts\" WHERE \"posts\".\"user_id\" = 1 ORDER BY \"posts\".\"created_at\" ASC UNION SELECT \"posts\".* FROM \"posts\" WHERE (created_at > '2014-07-19 00:00:00') ORDER BY \"posts\".\"created_at\" ASC ) \"posts\" ORDER BY \"created_at\" ASC"
)
else
expect(union.to_sql.squish).to eq(
"SELECT \"posts\".* FROM ( SELECT \"posts\".* FROM \"posts\" WHERE \"posts\".\"user_id\" = 1 ORDER BY \"posts\".\"created_at\" ASC UNION SELECT \"posts\".* FROM \"posts\" WHERE (created_at > '#{SQL_TIME}') ORDER BY \"posts\".\"created_at\" ASC ) \"posts\" ORDER BY \"posts\".\"created_at\" ASC"
)
end
expect{union.to_a}.to raise_error(ActiveRecord::StatementInvalid) expect{union.to_a}.to raise_error(ActiveRecord::StatementInvalid)
end end
end end
@ -115,9 +121,15 @@ describe ActiveRecord::Relation do
context "in Postgres" do context "in Postgres" do
it "wraps query subselects in parentheses to allow ORDER BY clauses" do it "wraps query subselects in parentheses to allow ORDER BY clauses" do
Databases.with_postgres do Databases.with_postgres do
expect(union.to_sql.squish).to eq( if ([ActiveRecord::VERSION::MAJOR, ActiveRecord::VERSION::MINOR] <=> [5, 2]) >= 0
"SELECT \"posts\".* FROM ( (SELECT \"posts\".* FROM \"posts\" WHERE \"posts\".\"user_id\" = 1 ORDER BY \"posts\".\"created_at\" ASC) UNION (SELECT \"posts\".* FROM \"posts\" WHERE (created_at > '#{SQL_TIME}') ORDER BY \"posts\".\"created_at\" ASC) ) \"posts\" ORDER BY \"posts\".\"created_at\" ASC" expect(union.to_sql.squish).to eq(
) "SELECT \"posts\".* FROM ( (SELECT \"posts\".* FROM \"posts\" WHERE \"posts\".\"user_id\" = 1 ORDER BY \"posts\".\"created_at\" ASC) UNION (SELECT \"posts\".* FROM \"posts\" WHERE (created_at > '2014-07-19 00:00:00') ORDER BY \"posts\".\"created_at\" ASC) ) \"posts\" ORDER BY \"created_at\" ASC"
)
else
expect(union.to_sql.squish).to eq(
"SELECT \"posts\".* FROM ( (SELECT \"posts\".* FROM \"posts\" WHERE \"posts\".\"user_id\" = 1 ORDER BY \"posts\".\"created_at\" ASC) UNION (SELECT \"posts\".* FROM \"posts\" WHERE (created_at > '#{SQL_TIME}') ORDER BY \"posts\".\"created_at\" ASC) ) \"posts\" ORDER BY \"posts\".\"created_at\" ASC"
)
end
expect{union.to_a}.to_not raise_error expect{union.to_a}.to_not raise_error
end end
end end
@ -126,9 +138,15 @@ describe ActiveRecord::Relation do
context "in MySQL" do context "in MySQL" do
it "wraps query subselects in parentheses to allow ORDER BY clauses" do it "wraps query subselects in parentheses to allow ORDER BY clauses" do
Databases.with_mysql do Databases.with_mysql do
expect(union.to_sql.squish).to eq( if ([ActiveRecord::VERSION::MAJOR, ActiveRecord::VERSION::MINOR] <=> [5, 2]) >= 0
"SELECT `posts`.* FROM ( (SELECT `posts`.* FROM `posts` WHERE `posts`.`user_id` = 1 ORDER BY `posts`.`created_at` ASC) UNION (SELECT `posts`.* FROM `posts` WHERE (created_at > '#{SQL_TIME}') ORDER BY `posts`.`created_at` ASC) ) `posts` ORDER BY `posts`.`created_at` ASC" expect(union.to_sql.squish).to eq(
) "SELECT `posts`.* FROM ( (SELECT `posts`.* FROM `posts` WHERE `posts`.`user_id` = 1 ORDER BY `posts`.`created_at` ASC) UNION (SELECT `posts`.* FROM `posts` WHERE (created_at > '2014-07-19 00:00:00') ORDER BY `posts`.`created_at` ASC) ) `posts` ORDER BY `created_at` ASC"
)
else
expect(union.to_sql.squish).to eq(
"SELECT `posts`.* FROM ( (SELECT `posts`.* FROM `posts` WHERE `posts`.`user_id` = 1 ORDER BY `posts`.`created_at` ASC) UNION (SELECT `posts`.* FROM `posts` WHERE (created_at > '#{SQL_TIME}') ORDER BY `posts`.`created_at` ASC) ) `posts` ORDER BY `posts`.`created_at` ASC"
)
end
expect{union.to_a}.to_not raise_error expect{union.to_a}.to_not raise_error
end end
end end